paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-14 10:57:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

handle_push_notification: Remove the if condition.

Browse Source 
'if apple_devices or android_devices' doesn't servce any purpose.
This commit is contained in:
Umair Khan
2017-05-12 10:50:18 +05:00
committed by Tim Abbott
parent c4e5b75ead
commit fc0b9358e7
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
zerver/lib/push_notifications.py
View File

@@ -382,14 +382,13 @@ def handle_push_notification(user_profile_id, missed_message):
apple_devices = list(PushDeviceToken.objects.filter(user=user_profile, apple_devices = list(PushDeviceToken.objects.filter(user=user_profile,
kind=PushDeviceToken.APNS)) kind=PushDeviceToken.APNS))
if apple_devices or android_devices: # TODO: set badge count in a better way
# TODO: set badge count in a better way if apple_devices:
if apple_devices: send_apple_push_notification(user_profile.id, apple_devices,
send_apple_push_notification(user_profile.id, apple_devices, badge=1, zulip=apns_payload)
badge=1, zulip=apns_payload)
if android_devices: if android_devices:
send_android_push_notification(android_devices, gcm_payload) send_android_push_notification(android_devices, gcm_payload)
except UserMessage.DoesNotExist: except UserMessage.DoesNotExist:
logging.error("Could not find UserMessage with message_id %s" % (missed_message['message_id'],)) logging.error("Could not find UserMessage with message_id %s" % (missed_message['message_id'],))