paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 23:13:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

rest: Add assertions for entries from supported methods.

Browse Source 
Mypy considers that "Tuple[Any, ...]" is incompatible with
"Union[Tuple[Callable[..., HttpResponse], Set[str]], HttpResponse]".

handler, view_flags = entry is sufficient to suppress the error, but we
also add assertions for full measure.

Signed-off-by: Zixuan James Li <p359101898@gmail.com>
This commit is contained in:
Zixuan James Li
2022-08-15 14:58:15 -04:00
committed by Tim Abbott
parent c0287473b9
commit fcba35036b
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
zerver/lib/rest.py
View File

@@ -90,7 +90,10 @@ def get_target_view_function_or_response(
if method_to_use in supported_methods: if method_to_use in supported_methods:
entry = supported_methods[method_to_use] entry = supported_methods[method_to_use]
if isinstance(entry, tuple): if isinstance(entry, tuple):
return entry handler, view_flags = entry
assert callable(handler)
assert isinstance(view_flags, set)
return handler, view_flags
return supported_methods[method_to_use], set() return supported_methods[method_to_use], set()
return json_method_not_allowed(list(supported_methods.keys())) return json_method_not_allowed(list(supported_methods.keys()))