paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-21 23:19:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

push_notifications: Format blockquotes properly in text_output.

Browse Source 
New output is of the format:

Hamlet said:
> Polonius said:
> > This is the.
> > Second layer of nesting.
> First layer of nesting.

Fixes #9251.
This commit is contained in:
Rohitt Vashishtha
2018-05-02 10:31:29 +05:30
committed by Tim Abbott
parent d345564ce2
commit fd06380701
2 changed files with 18 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
zerver/lib/push_notifications.py
View File

@@ -445,13 +445,24 @@ def get_mobile_push_content(rendered_content: Text) -> Text:
# Handles realm emojis, avatars etc.
if elem.tag == "img":
return elem.get("alt", "")
if elem.tag == 'blockquote':
return '' # To avoid empty line before quote text
return elem.text or ''
return elem.text or ""
def format_as_quote(quote_text: Text) -> Text:
quote_text_list = filter(None, quote_text.split('\n')) # Remove empty lines
quote_text = '\n'.join(map(lambda x: "> "+x, quote_text_list))
quote_text += '\n'
return quote_text
def process(elem: LH.HtmlElement) -> Text:
plain_text = get_text(elem)
sub_text = ''
for child in elem:
plain_text += process(child)
sub_text += process(child)
if elem.tag == 'blockquote':
sub_text = format_as_quote(sub_text)
plain_text += sub_text
plain_text += elem.tail or ""
return plain_text