paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

left_sidebar: Refactor left_sidebar.hbs structures for readability.

Browse Source 
This commit renames the classes and IDs in the views area
(formerly global filters) to a set of flexible values all
prefixed in some way with `left-sidebar-navigation`.

This is meant to make the styles and structures in the area
more readable, while also keeping things flexible into the
future as this area's elements change.

Co-Authored-By: Hardik Dharmani <Ddharmani99@gmail.com>
This commit is contained in:
Karl Stolley
2023-10-10 14:00:28 -05:00
committed by Tim Abbott
parent 7e776b9c76
commit fd0dd3acd8
7 changed files with 35 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
web/e2e-tests/stars.test.ts
View File

@@ -28,7 +28,7 @@ async function toggle_test_star_message(page: Page): Promise<void> {
}
async function test_narrow_to_starred_messages(page: Page): Promise<void> {
await page.click('#global_filters a[href^="#narrow/is/starred"]');
await page.click('#left-sidebar-navigation-list a[href^="#narrow/is/starred"]');
await common.check_messages_sent(page, "zfilt", [["Verona > stars", [message]]]);
// Go back to all messages narrow.