paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-07 15:33:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

resize: Call resize_app after hiding recent topics first time.

Browse Source 
See the code comment for why it is being called. We also remove the
unused `message_feed_shown` which was added to be used for this
purpose.

I decided to not call this with `requestAnimationFrame` since it
is changing position of elements in DOM and not letting browser
do a reflow after that can lead to wrong calculations later on.
This commit is contained in:
Aman Agrawal
2022-11-21 13:41:24 +00:00
committed by Tim Abbott
parent a0f42edaa2
commit fd422a4dd8
3 changed files with 12 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
static/js/recent_topics_ui.js
View File

@@ -18,6 +18,7 @@ import * as message_util from "./message_util";
import * as message_view_header from "./message_view_header";
import * as narrow from "./narrow";
import * as narrow_state from "./narrow_state";
import * as navbar_alerts from "./navbar_alerts";
import * as navigate from "./navigate";
import {page_params} from "./page_params";
import * as people from "./people";
@@ -43,6 +44,7 @@ import * as user_status from "./user_status";
import * as user_topics from "./user_topics";
let topics_widget;
let message_list_displayed_before;
// Sets the number of avatars to display.
// Rest of the avatars, if present, are displayed as {+x}
const MAX_AVATAR = 4;
@@ -893,8 +895,16 @@ export function hide() {
// before it completely re-rerenders.
message_view_header.render_title_area();
// Fire our custom event
$("#message_feed_container").trigger("message_feed_shown");
if (!message_list_displayed_before) {
// Hack: If the app is loaded directly to recent topics, then we
// need to arrange to call navbar_alerts.resize_app when we first
// visit a message list. This is a workaround for bugs where the
// floating recipient bar will be invisible (as well as other
// alignment issues) when they are initially rendered in the
// background because recent topics is displayed.
message_list_displayed_before = true;
navbar_alerts.resize_app();
}
// This makes sure user lands on the selected message
// and not always at the top of the narrow.