paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-30 11:33:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

drafts: Append a space to draft when restoring it.

Browse Source 
If a user starts typing before they see that a draft was restored,
this makes that experience a little smoother by adding some
separation between the old draft and the new text.
This commit is contained in:
evykassirer
2024-03-19 15:34:10 -07:00
committed by Tim Abbott
parent d48de6da08
commit fd4246def5
2 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
web/e2e-tests/drafts.test.ts
View File

@@ -54,7 +54,7 @@ async function test_restore_stream_message_draft_by_opening_compose_box(page: Pa
await common.check_compose_state(page, {
stream: "Denmark",
topic: "tests",
content: "Test stream message.",
content: "Test stream message. ",
});
await page.click("#compose_close");
await page.waitForSelector("#send_message_form", {visible: false});
@@ -74,7 +74,7 @@ async function test_restore_private_message_draft_by_opening_composebox(page: Pa
await page.waitForSelector("#private_message_recipient", {visible: true});
await common.check_form_contents(page, "form#send_message_form", {
content: "Test direct message.",
content: "Test direct message. ",
});
await page.click("#compose_close");
await page.waitForSelector("#private_message_recipient", {visible: false});

7
web/src/compose_actions.ts
View File

@@ -312,7 +312,12 @@ export function start(raw_opts: ComposeActionsStartOpts): void {
const possible_last_draft = drafts.get_last_draft_based_on_compose_state();
if (possible_last_draft !== undefined) {
opts.draft_id = possible_last_draft.id;
opts.content = possible_last_draft.content;
// Add a space at the end so that if the user starts typing
// as soon as the composebox opens, they have a bit of separation
// from the restored draft. This won't result in a long trail of
// spaces if a draft is restored several times, because we trim
// whitespace whenever we save drafts.
opts.content = possible_last_draft.content + " ";
}
}