paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-12 18:06:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

unread: Fix {get_msg_ids,num_unread}_for_person type confusion.

Browse Source 
These methods take a comma-separated string of user IDs; don’t pass a
number.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
This commit is contained in:
Anders Kaseorg
2020-01-31 17:47:48 -08:00
committed by Tim Abbott
parent 6aacc4195e
commit fd9557aa0c
2 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
frontend_tests/node_tests/unread.js
View File

@@ -443,10 +443,10 @@ run_test('private_messages', () => {
}; };
people.add_in_realm(bob); people.add_in_realm(bob);
assert.equal(unread.num_unread_for_person(alice.user_id), 0); assert.equal(unread.num_unread_for_person(alice.user_id.toString()), 0);
assert.equal(unread.num_unread_for_person(bob.user_id), 0); assert.equal(unread.num_unread_for_person(bob.user_id.toString()), 0);
assert.deepEqual(unread.get_msg_ids_for_person(alice.user_id), []); assert.deepEqual(unread.get_msg_ids_for_person(alice.user_id.toString()), []);
assert.deepEqual(unread.get_msg_ids_for_person(bob.user_id), []); assert.deepEqual(unread.get_msg_ids_for_person(bob.user_id.toString()), []);
assert.deepEqual(unread.get_msg_ids_for_person(), []); assert.deepEqual(unread.get_msg_ids_for_person(), []);
assert.deepEqual(unread.get_msg_ids_for_private(), []); assert.deepEqual(unread.get_msg_ids_for_private(), []);
@@ -461,20 +461,20 @@ run_test('private_messages', () => {
flags: ['read'], flags: ['read'],
}; };
unread.process_loaded_messages([message, read_message]); unread.process_loaded_messages([message, read_message]);
assert.equal(unread.num_unread_for_person(alice.user_id), 1); assert.equal(unread.num_unread_for_person(alice.user_id.toString()), 1);
assert.equal(unread.num_unread_for_person(''), 0); assert.equal(unread.num_unread_for_person(''), 0);
assert.deepEqual(unread.get_msg_ids_for_person(alice.user_id), [message.id]); assert.deepEqual(unread.get_msg_ids_for_person(alice.user_id.toString()), [message.id]);
assert.deepEqual(unread.get_msg_ids_for_person(bob.user_id), []); assert.deepEqual(unread.get_msg_ids_for_person(bob.user_id.toString()), []);
assert.deepEqual(unread.get_msg_ids_for_private(), [message.id]); assert.deepEqual(unread.get_msg_ids_for_private(), [message.id]);
assert.deepEqual(unread.get_all_msg_ids(), [message.id]); assert.deepEqual(unread.get_all_msg_ids(), [message.id]);
unread.mark_as_read(message.id); unread.mark_as_read(message.id);
assert.equal(unread.num_unread_for_person(alice.user_id), 0); assert.equal(unread.num_unread_for_person(alice.user_id.toString()), 0);
assert.equal(unread.num_unread_for_person(''), 0); assert.equal(unread.num_unread_for_person(''), 0);
assert.deepEqual(unread.get_msg_ids_for_person(alice.user_id), []); assert.deepEqual(unread.get_msg_ids_for_person(alice.user_id.toString()), []);
assert.deepEqual(unread.get_msg_ids_for_person(bob.user_id), []); assert.deepEqual(unread.get_msg_ids_for_person(bob.user_id.toString()), []);
assert.deepEqual(unread.get_msg_ids_for_private(), []); assert.deepEqual(unread.get_msg_ids_for_private(), []);
assert.deepEqual(unread.get_all_msg_ids(), []); assert.deepEqual(unread.get_all_msg_ids(), []);
const counts = unread.get_counts(); const counts = unread.get_counts();

2
static/js/buddy_data.js
View File

@@ -140,7 +140,7 @@ function get_num_unread(user_id) {
if (unread.suppress_unread_counts) { if (unread.suppress_unread_counts) {
return 0; return 0;
} }
return unread.num_unread_for_person(user_id); return unread.num_unread_for_person(user_id.toString());
} }
exports.my_user_status = function (user_id) { exports.my_user_status = function (user_id) {