paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-09 08:26:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

zcommand: Raise error when command doesn't begin with a slash.

Browse Source
This commit is contained in:
Rhea Parekh
2018-06-21 22:53:35 +05:30
committed by showell
parent b22d266667
commit fdef1d8d91
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
zerver/lib/zcommand.py
View File

@@ -6,7 +6,9 @@ from zerver.lib.actions import do_set_user_display_setting
from zerver.lib.exceptions import JsonableError from zerver.lib.exceptions import JsonableError
def process_zcommands(content: str, user_profile: UserProfile) -> Dict[str, Any]: def process_zcommands(content: str, user_profile: UserProfile) -> Dict[str, Any]:
command = content.replace('/', '') if not content.startswith('/'):
raise JsonableError(_('There should be a leading slash in the zcommand.'))
command = content[1:]
if command == 'ping': if command == 'ping':
ret = dict() # type: Dict[str, Any] ret = dict() # type: Dict[str, Any]

4
zerver/tests/test_zcommand.py
View File

@@ -13,6 +13,10 @@ class ZcommandTest(ZulipTestCase):
result = self.client_post("/json/zcommand", payload) result = self.client_post("/json/zcommand", payload)
self.assert_json_error(result, "No such command: boil-ocean") self.assert_json_error(result, "No such command: boil-ocean")
payload = dict(command="boil-ocean")
result = self.client_post("/json/zcommand", payload)
self.assert_json_error(result, "There should be a leading slash in the zcommand.")
def test_ping_zcommand(self) -> None: def test_ping_zcommand(self) -> None:
self.login(self.example_email("hamlet")) self.login(self.example_email("hamlet"))