paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-13 18:36:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Migrate Bootstrap modal calls to overlay calls.

Browse Source 
In d0f8515b50, it was noticed that
Bootstrap's `hide` and `show` calls can cause race conditions.
So, migrate to our `overlay` calls to handle Bootstrap modals.
This commit is contained in:
Ganesh Pawar
2021-04-29 12:03:00 +05:30
committed by Tim Abbott
parent 6e4735a4e9
commit fe147757c9
6 changed files with 16 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
static/js/popovers.js
View File

@@ -369,7 +369,7 @@ export function hide_mobile_message_buttons_popover() {
}
export function hide_user_profile() {
$("#user-profile-modal").modal("hide");
overlays.close_modal("#user-profile-modal");
}
export function show_user_profile(user) {
@@ -396,7 +396,7 @@ export function show_user_profile(user) {
};
$("#user-profile-modal-holder").html(render_user_profile_modal(args));
$("#user-profile-modal").modal("show");
overlays.open_modal("#user-profile-modal");
settings_account.initialize_custom_user_type_fields(
"#user-profile-modal #content",