paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 15:03:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Migrate Bootstrap modal calls to overlay calls.

Browse Source 
In d0f8515b50, it was noticed that
Bootstrap's `hide` and `show` calls can cause race conditions.
So, migrate to our `overlay` calls to handle Bootstrap modals.
This commit is contained in:
Ganesh Pawar
2021-04-29 12:03:00 +05:30
committed by Tim Abbott
parent 6e4735a4e9
commit fe147757c9
6 changed files with 16 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
static/js/stream_popover.js
View File

@@ -18,6 +18,7 @@ import {$t, $t_html} from "./i18n";
import * as message_edit from "./message_edit";
import * as muting from "./muting";
import * as muting_ui from "./muting_ui";
import * as overlays from "./overlays";
import {page_params} from "./page_params";
import * as popovers from "./popovers";
import * as resize from "./resize";
@@ -363,7 +364,7 @@ function build_move_topic_to_stream_popover(e, current_stream_id, topic_name) {
);
stream_bar.decorate(current_stream_name, stream_header_colorblock, false);
$("#move_topic_modal").modal("show");
overlays.open_modal("#move_topic_modal");
}
export function register_click_handlers() {