paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-17 20:41:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

messsage_lists: Extract method to delete a rendered list.

Browse Source
This commit is contained in:
Aman Agrawal
2024-09-10 05:33:05 +00:00
committed by Tim Abbott
parent 0507f65da5
commit fee108949d
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
web/src/message_lists.ts
View File

@@ -94,6 +94,11 @@ export function set_current(msg_list: MessageList | undefined): void {
current = msg_list; current = msg_list;
} }
function delete_message_list(message_list: MessageList): void {
message_list.view.$list.remove();
rendered_message_lists.delete(message_list.id);
}
export function update_current_message_list(msg_list: MessageList | undefined): void { export function update_current_message_list(msg_list: MessageList | undefined): void {
// Since we change `current` message list in the function, we need to decide if the // Since we change `current` message list in the function, we need to decide if the
// current message list needs to be cached or discarded. // current message list needs to be cached or discarded.
@@ -105,8 +110,7 @@ export function update_current_message_list(msg_list: MessageList | undefined):
// current message list from the DOM. // current message list from the DOM.
if (current && !current.should_preserve_current_rendered_state()) { if (current && !current.should_preserve_current_rendered_state()) {
// Remove the current message list from the DOM. // Remove the current message list from the DOM.
current.view.$list.remove(); delete_message_list(current);
rendered_message_lists.delete(current.id);
} else { } else {
// We plan to keep the current message list cached. // We plan to keep the current message list cached.
current?.view.$list.removeClass("focused-message-list"); current?.view.$list.removeClass("focused-message-list");
@@ -116,8 +120,7 @@ export function update_current_message_list(msg_list: MessageList | undefined):
if (current?.data.filter.is_in_home()) { if (current?.data.filter.is_in_home()) {
for (const [id, msg_list] of rendered_message_lists) { for (const [id, msg_list] of rendered_message_lists) {
if (id !== current.id && msg_list.data.filter.is_in_home()) { if (id !== current.id && msg_list.data.filter.is_in_home()) {
msg_list.view.$list.remove(); delete_message_list(msg_list);
rendered_message_lists.delete(id);
// We only expect to have one instance of a message list filter cached. // We only expect to have one instance of a message list filter cached.
break; break;
} }