paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 14:03:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

people: Extract name diacritics removal logic.

Browse Source 
This is done as a prep commit to use this new function in
`query_matches_person` to introduce caching on the diacritic-less full
name.

(cherry picked from commit cb0a598481)
This commit is contained in:
apoorvapendse
2025-04-18 12:46:24 +05:30
committed by Tim Abbott
parent 456a644fad
commit ff4860ddbc
1 changed files with 30 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
web/src/people.ts
View File

@@ -1228,20 +1228,39 @@ export function get_people_for_search_bar(query: string): User[] {
return filter_all_persons(pred);
}
export function build_termlet_matcher(termlet: string): (user: User) => boolean {
termlet = termlet.trim();
export function should_remove_diacritics_for_query(query_lower_case: string): boolean {
// We only do diacritic-sensitive matching for queries that do not
// contain diacritics themselves.
//
// TODO: This check is too strict; ideally we'd check for presence
// of diacritics; punctuation should not be relevant.
return /^[a-z]+$/.test(query_lower_case);
}
const is_ascii = /^[a-z]+$/.test(termlet);
export function maybe_remove_diacritics_from_name(
user: User,
should_remove_diacritics: boolean,
): string {
// Callers should compute should_remove_diacritics using
// should_remove_diacritics_for_query. It's fastest if the caller
// computes that once outside the loop over all users.
if (should_remove_diacritics) {
// Reuse removed diacritics version of the `full_name` if
// present, since it's expensive to compute.
user.name_with_diacritics_removed ??= typeahead.remove_diacritics(user.full_name);
return user.name_with_diacritics_removed;
}
return user.full_name;
}
export function build_termlet_matcher(termlet: string): (user: User) => boolean {
// Note: termlets are required to be lower case.
termlet = termlet.trim();
const should_remove_diacritics = should_remove_diacritics_for_query(termlet);
return function (user: User): boolean {
let full_name = user.full_name;
// Only ignore diacritics if the query is plain ascii
if (is_ascii) {
if (user.name_with_diacritics_removed === undefined) {
user.name_with_diacritics_removed = typeahead.remove_diacritics(full_name);
}
full_name = user.name_with_diacritics_removed;
}
const full_name = maybe_remove_diacritics_from_name(user, should_remove_diacritics);
const names = full_name.toLowerCase().split(" ");
return names.some((name) => name.startsWith(termlet));