From ffb29ddaf1ad309645a0c49ee8b6fd936f44fe57 Mon Sep 17 00:00:00 2001
From: Sampriti Panda <sampdingo@hotmail.com>
Date: Mon, 23 Jul 2018 23:15:36 +0530
Subject: [PATCH] subs: Replace tr block with t in subs handlebars template.

The `tr` block does clones the `options` array (which contains the
entire subscriptions data set) very inefficiently, which leads to the
rendering being very slow.

We don't need a `tr` block here, as there is no dynamic content that
needs to be replaced.
---
 static/templates/stream_creation_form.handlebars |  4 +---
 static/templates/stream_types.handlebars         | 14 ++++----------
 2 files changed, 5 insertions(+), 13 deletions(-)

diff --git a/static/templates/stream_creation_form.handlebars b/static/templates/stream_creation_form.handlebars
index 106755e026..07844db965 100644
--- a/static/templates/stream_creation_form.handlebars
+++ b/static/templates/stream_creation_form.handlebars
@@ -24,9 +24,7 @@
                     {{t "Stream permissions" }}
                 </div>
                 <div class="stream-creation-info">
-                    {{#tr this}}
-                    These settings are explained in detail in the <a target="_blank" href="/help/stream-permissions">help center</a>.
-                    {{/tr}}
+                    {{t 'These settings are explained in detail in the <a target="_blank" href="/help/stream-permissions">help center</a>.'}}
                 </div>
 
                 {{ partial "stream_types" "is_public" true }}
diff --git a/static/templates/stream_types.handlebars b/static/templates/stream_types.handlebars
index 5227263f60..788c12f327 100644
--- a/static/templates/stream_types.handlebars
+++ b/static/templates/stream_types.handlebars
@@ -2,32 +2,26 @@
     <li>
         <label class="radio">
             <input type="radio" name="privacy" value="public" {{#if is_public}}checked{{/if}} />
-            {{#tr this}}
-            <b>Public:</b> anyone can join; anyone can view complete message history without joining
-            {{/tr}}
+            {{t '<b>Public:</b> anyone can join; anyone can view complete message history without joining' }}
         </label>
     </li>
     <li>
         <label class="radio">
             <input type="radio" name="privacy" value="invite-only-public-history" {{#if is_private_with_public_history}}checked{{/if}} />
-            {{#tr this}}
-            <b>Private, shared history:</b> must be invited by a member; new members can view complete message history; hidden from non-administrator users
-            {{/tr}}
+            {{t '<b>Private, shared history:</b> must be invited by a member; new members can view complete message history; hidden from non-administrator users' }}
         </label>
     </li>
     <li>
         <label class="radio">
             <input type="radio" name="privacy" value="invite-only" {{#if is_private}}checked{{/if}} />
-            {{#tr this}}
-            <b>Private, protected history:</b> must be invited by a member; new members can only see messages sent after they join; hidden from non-administrator users
-            {{/tr}}
+            {{t '<b>Private, protected history:</b> must be invited by a member; new members can only see messages sent after they join; hidden from non-administrator users' }}
         </label>
     </li>
     <li>
         <label class="checkbox">
             <input type="checkbox" name="is-announcement-only" value="is-announcement-only" {{#if is_announcement_only}}checked{{/if}}/>
             <span></span>
-            {{#tr this}}Restrict posting to organization administrators{{/tr}}
+            {{t 'Restrict posting to organization administrators' }}
         </label>
     </li>
 </ul>