paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-22 07:21:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings_components: Remove unnecessary toString calls.

Browse Source 
The value for which the toString is called is already a string, so
there is no need to call it. It would have been added to make sure
that linter does not complain, so added an assert statement for it.
This commit is contained in:
Sahil Batra
2024-08-28 19:20:20 +05:30
committed by Tim Abbott
parent 764083d31b
commit ffeb542b22
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
web/src/settings_components.ts
View File

@@ -990,9 +990,10 @@ export function populate_data_for_realm_settings_request(
}
if (property_name === "org_join_restrictions") {
assert(typeof input_value === "string");
data = {
...data,
...get_request_data_for_org_join_restrictions(input_value.toString()),
...get_request_data_for_org_join_restrictions(input_value),
};
continue;
}
@@ -1038,11 +1039,10 @@ export function populate_data_for_stream_settings_request(
if (input_value !== undefined && input_value !== null) {
const property_name = extract_property_name($input_elem);
if (property_name === "stream_privacy") {
assert(typeof input_value === "string");
data = {
...data,
...settings_data.get_request_data_for_stream_privacy(
input_value.toString(),
),
...settings_data.get_request_data_for_stream_privacy(input_value),
};
continue;
}