Commit Graph

9109 Commits

Author SHA1 Message Date
Sayam Samal
c3aaaa2303 left_sidebar: Fix focus styles for back to channels link in DM list. 2025-07-25 13:13:05 -07:00
Sayam Samal
ac0f3a0817 left_sidebar: Fix ENTER key behavior in back to channels in DM list.
This commit addresses the issue where pressing the ENTER key on the
"back to channels" link in the zoomed in direct messages list did not
perform the intended action by adding the `trigger-click-on-enter`
class to the element.
2025-07-25 13:13:05 -07:00
Sayam Samal
fa266701e0 left_sidebar: Make DM list back to channels link keyboard accessible. 2025-07-25 13:13:05 -07:00
Sayam Samal
63200b9e9e left_sidebar: Fix ENTER key navigation in more conversations in DM list.
This commit addresses the issue where pressing the ENTER key on the
"more conversations" link in the direct messages list did not perform
the intended action by adding a `trigger-click-on-enter` class to the
element.

This allows the `process_enter_key` function to explicitly trigger a
click event on the element when the ENTER key is pressed, ensuring that
the associated click handler is called.
2025-07-25 13:13:05 -07:00
Sayam Samal
9ce596fbd8 left_sidebar: Fix focus styles for show more conversations in DM list. 2025-07-25 13:13:05 -07:00
Sayam Samal
41bc50f2d6 left_sidebar: Fix focus styles of items in DM list. 2025-07-25 13:13:05 -07:00
Sayam Samal
c41b1e2a60 left_sidebar: Fix focus styles for stream list. 2025-07-25 13:13:05 -07:00
Sayam Samal
52c8307031 left_sidebar: Fix focus styles for topic list. 2025-07-25 13:13:05 -07:00
Alya Abbott
8b72f51156 recent: Follow current pattern for placeholder text.
We no longer show keyboard shortcuts in placeholders.
2025-07-25 12:37:31 -07:00
Karl Stolley
b5e011565f portico: Prevent label styling from affecting altcha-label. 2025-07-25 11:55:54 -07:00
Sahil Batra
34cb0034e1 settings: Handle long names better in susbcribers and members list.
This commit updates the subscribers and group members table CSS to
use fixed layout. This helps in having user pill take the width if
available and we can show more characters.

Previously the width of name in user pill was set to have a max
width of 165px which meant the there was some empty unused space in
the rows especially on narrow screens when email column was hidden.

Fixes #35157.
2025-07-25 11:21:23 -07:00
Aman Agrawal
1d7b9ea83c compose_tooltips: Fix message edit tooltip visible without mousemove.
Fixes #34009

Fixed by only initializing tippy instance once user moves mouse.
2025-07-25 11:10:07 -07:00
Maneesh Shukla
074850ef5d message-edit-tooltips: Fix the breaking tooltips on rerender.
Fixes: #35217.
2025-07-25 11:10:07 -07:00
Karl Stolley
6341bf192d compose_attention: Handle general-topic corner case. 2025-07-25 11:07:58 -07:00
Karl Stolley
cb96ddc1ff compose_attention: Handle cases where topics are undefined. 2025-07-25 11:07:58 -07:00
Karl Stolley
1bba4c2a99 recent_view: Don't apply line-clamping to 1:1 DMs. 2025-07-24 16:49:53 -07:00
Karl Stolley
ea58f35941 recent_view: Ensure all DMs get an identifying class. 2025-07-24 16:49:53 -07:00
Shubham Padia
cb852b0fa6 help-beta: Add ZulipTip custom component that does not have a header.
We do not want to have a heading for every tip and thus we created a
custom component for our aside. We want to add a lightbulb icon and the
text `Tip:` is bold as a prefix for every tip as if it was already part
of the text. To do that, we cannot insert both of those as html seperate
from the slot html, we had to access the slot html and insert both of
them into the HTML tree.
2025-07-24 12:00:26 -07:00
Aman Agrawal
500e40f786 inbox: Attempt to fix inbox scrolling to top on scrolling down.
We focus on the middle row instead of the top which is what we
use for recent view. Recent view doesn't have this problem, AFAIK,
so hopefully this will fix it.
2025-07-24 11:58:29 -07:00
Vector73
6f8cb2b787 message_delete: Refactor message delete functions in a new file. 2025-07-24 11:53:34 -07:00
Pratik Chanda
9a283d0641 css: Fix selector for user-pill-container so that it isn't overridden.
This commit improves the selector for user-pill-container so
that rules for it aren't overridden by parent styles. Also fixes
the user pill min-widdth being overridden.
2025-07-24 11:48:48 -07:00
Karl Stolley
8a833311de left_sidebar: Correct filter-input ellipsis bug in Safari. 2025-07-24 11:47:13 -07:00
Karl Stolley
9720fc93c3 left_sidebar: Correct filter-input scrollbar artifact. 2025-07-24 11:47:13 -07:00
Karl Stolley
56739f950c poll_widget: Disallow poll-vote count collapsing. 2025-07-23 16:18:36 -07:00
Sayam Samal
9a49007ef1 showroom: Fix wrong process name for desktop notifications banner. 2025-07-23 12:01:33 -07:00
Sayam Samal
d00cf1a0e8 banners: Improve responsiveness in normal banners.
This commit improves the responsiveness of normal banners by adopting a
flexbox layout for the label and action buttons. This change better
accommodates varying text lengths and button counts in the banners, due
to the natural flowy nature of flexboxes.

The key logic shift involves using `flex-basis` to manage layout
transitions: the label and the group of action buttons now wrap to
separate lines when the label's width is less than 60% of the banner
query container's width (60cqw).

This commit also updates the CSS for navbar banners to align with the
new flexbox layout between the label and the group of action buttons,
while also ensuring that the layout behavior of these banners remains
consistent with the previous implementation.
2025-07-23 12:01:33 -07:00
Karl Stolley
b26e54b724 compose: Disregard textarea-focus for low-attention setup.
As noted in the comment, focus in the recipient row is
better handled by event handlers elsewhere.

This change also allows us to avoid a race condition
when determining focus is deferred (as is the case
with the auto-opened compose box on DMs).
2025-07-23 11:58:47 -07:00
Karl Stolley
7515ed45be compose: Defer triggering focus.
This commit fixes a bug on iPad/Safari that caused
the entire viewport to scroll wildly when navigating
to lengthy DM conversations.

Co-Authored-By: Aman Agrawal <amanagr@zulip.com>
2025-07-23 11:58:45 -07:00
Karl Stolley
4ddaaead10 left_sidebar: Remove dead CSS that serves no purpose. 2025-07-23 11:54:26 -07:00
Karl Stolley
05abb17415 left_sidebar: Remove dead CSS that may cause hover cutoffs. 2025-07-23 11:54:26 -07:00
Vector73
6aac806f76 message_delete: Remove explicit is_spectator condition.
Removes explicit `is_spectator` condition when checking if
message can deleted as it is checked by
`user_has_permission_for_group_setting` function.
2025-07-23 11:52:48 -07:00
Aman Agrawal
94dc41f8cd inbox: Fix is_waiting_for_revive_current_focus not being reset.
`is_waiting_for_revive_current_focus` should be set to `true`
when inbox is hidden so that it be correctly checked when
it inbox is displayed later.
2025-07-23 11:50:20 -07:00
Aman Agrawal
42b5a9b8c1 inbox: Focus first row instead of header on keypress.
If the user has not scrolled and this is their first keypress,
focus on conversation row instead of a header.
2025-07-23 11:30:38 -07:00
Shubham Padia
6b66449352 help: Disallow class in svg.
When copying svg from other places e.g. lucide, class names are also
copied over. These classes are not defined in our css and thus have no
effect whether they are present or not. But if the svg has the class
property, unplugin-icon will not override that class property and apply
the defaultClass we have defined in astro.config.mjs. We need that class
for our icons to look as desired.
2025-07-23 11:24:12 -07:00
Vector73
fc415e1fc5 pill_container: Remove hardcoded HSL value from input_pill.css. 2025-07-23 11:13:07 -07:00
Karl Stolley
a4d70505ec left_sidebar: Normalize input-wrapper row height. 2025-07-22 20:59:02 -07:00
Aman Agrawal
04f7dd998b inbox: Don't changed focused element on the first user keypress.
This is important to let user know where the focused element is
before they start navigating.
2025-07-22 17:23:47 -07:00
Aman Agrawal
26f215cc8e inbox: Fix current_focus_id not updated on click.
If user is focused on search and clicks on a row, focus is
not shifted to row.
2025-07-22 17:23:47 -07:00
Aman Agrawal
0f1cccc1cc inbox: Don't show focus outlines without inbox relevant keypress.
Untill user uses a keypress that inbox handles, we don't show
focus outlines.
2025-07-22 17:23:47 -07:00
Aman Agrawal
626524ba8e inbox: Attempt to fix inbox scrolling to top unexpectedly.
Inbox can suddenly scroll to top due to a rerender when user
is trying to scroll down. A possible caues for this is
`move_focus_to_visible_area` being triggered on scroll but the
element located using:

```
document.elementFromPoint(inbox_center_x, inbox_row_below_filters);
```

being out of view. To fix it, we try to locate the element in the
same animation frame. This will remove the possibility of element
being out of view when we try to set focus to it.
2025-07-22 17:12:50 -07:00
Aman Agrawal
fa9165236d inbox_ui: Minor refactor.
Use `inbox-folder` class to check if the row is an inbox folder.
2025-07-22 17:04:56 -07:00
Aman Agrawal
e8aa6e9ecf inbox_ui: Fix scroll jumb when coming back when scrolled down.
Used the same method used to fix it in recent view.
2025-07-22 17:04:56 -07:00
Anders Kaseorg
abe36b2c3d eslint: Fix unicorn/require-module-specifiers.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2025-07-22 14:19:56 -07:00
Anders Kaseorg
adf10dcab9 eslint: Fix unicorn/no-array-reverse.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2025-07-22 14:19:56 -07:00
Karl Stolley
8b667be929 left_sidebar: Hold topic filter input to a single line. 2025-07-22 14:18:02 -07:00
Karl Stolley
b31b4c7451 Revert "inputs: Fix input icons' vertical alignment for multi-line inputs."
This reverts commit 39e467c0dd.
2025-07-22 14:18:02 -07:00
Shubham Padia
22d8c725eb icons: Do not allow stroke property via the style tag in svgs.
We already had a lint rule for this, but we did not disallow setting it
from the style side. This was breaking the icons changed in this commit
in our new astro help center.
2025-07-22 12:55:05 -07:00
Shubham Padia
d24f2972d4 icons: Do not allow fill property via the style tag in svgs.
We already had a lint rule for this, but we did not disallow setting it
from the style side. This was breaking the icons changed in this commit
in our new astro help center.
2025-07-22 12:55:05 -07:00
Evy Kassirer
3bb08183f7 stream_list: Remove unused references to stream-filters-label. 2025-07-22 12:15:54 -07:00
Evy Kassirer
c942900b69 stream_list: Hide channels on zoom-in using .hide instead of hide().
This gives us more control, for example `show()` was adding
`display: inline-block;` to channels after unhiding them
which was overriding other code (added for channel folders
in future commits) that was trying to hide the channels.
2025-07-22 12:15:21 -07:00