paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-07 07:23:22 +00:00
Code Issues Packages Projects Releases Wiki Activity
34,620 Commits 30 Branches 160 Tags
0ce06d45a1265825c83e5f4d806b6c3b8049ce39
Commit Graph

6060 Commits

Author SHA1 Message Date
Anders Kaseorg
0ce06d45a1 message_list_view: Convert message_containers from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
86dd98d481 message_list_view: Convert _rows from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
a6a19c6ace message_list_data: Convert id_set from object to Set. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
9fa9f37521 message_list_data: Convert msg_ids_to_remove from object to Set. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
dde035faf3 message_list_data: Convert _local_only from object to Set. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
2d18424da0 message_list_data: Convert _hash from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
bf32dfcb9f markdown: Convert realm_filter_map from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
0d6d36ae16 local_message: Convert already_used from object to Set. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
ec1ebc936b gear_menu: Convert scroll_positions from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
02fb1d4dd1 emoji_picker: Convert intermediate complete_emoji_catalog to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
0936381cfd echo: Convert waiting_for_ack from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
c42aca3cfb echo: Convert waiting_for_id from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
278420f908 debug: Convert sections from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
99bcd78273 debug: Convert ids from object to Set. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
265cca4756 blueslip: Convert reported_errors, last_report_attempt from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
2ddd3d046a echo: Further reduce local_id string vs. number confusion. 
New rule: local_id is always a string, local_id_float is always a
number.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
2834b051d2 js: Read zid with rows.id. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
d7d8632525 pygments_data: Replace JS module with JSON module. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:09:12 -08:00
Anders Kaseorg
e257253e64 emoji_codes: Replace JS module with JSON module. 
webpack optimizes JSON modules using JSON.parse("{…}"), which is
faster than the normal JavaScript parser.

Update the backend to use emoji_codes.json too instead of the three
separate JSON files.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:09:12 -08:00
Anders Kaseorg
72dddb7af6 zjsunit: Use assert in strict mode. 
This makes assert.equal and assert.deepEqual compare using === rather
than ==, to catch more bugs.

https://nodejs.org/api/assert.html#assert_strict_mode

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 08:16:26 -05:00
Steve Howell
483f1d153d minor: Remove "spread operator" todo comment. 
This comment was addressed in
59d55d1e06
 2020-02-12 06:10:32 -05:00
Anders Kaseorg
59d55d1e06 js: Use modern spread arguments syntax. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-11 17:43:35 -08:00
Hashir Sarwar
6e14c39468 top_left_corner: Don't export should_expand_pm_list(). 
We don't need to export `should_expand_pm_list` function
since we are not using it anywhere else.
 2020-02-11 14:14:59 -08:00
Anders Kaseorg
e66c4ea474 settings_invites: Convert invited_as_values from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-10 15:57:20 -08:00
Anders Kaseorg
ed032817c7 hotspots: Convert HOTSPOT_LOCATIONS from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-10 15:57:20 -08:00
Anders Kaseorg
ee68ef516d js: Convert _.isString to typeof. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-10 15:57:20 -08:00
Anders Kaseorg
a3e5fef663 js: Convert _.isObject to typeof. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-10 15:57:20 -08:00
Anders Kaseorg
9f07cf6b0e js: Convert _.values to Object.values. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-10 15:57:20 -08:00
Anders Kaseorg
7ca52f1e80 js: Convert _.keys to Object.keys. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-10 15:57:20 -08:00
Steve Howell
14396c3e32 presence: Prep for upcoming changes to server data. 
In the next commit we're going to change what the
server sends for the following:

    - page_params
    - server responses to /json/users/me/presence

We will **not** yet be changing the format of the data
that we get in events when users update their presence.

It's also just a bit in flux what our final formats
will be for various presence payloads, and different
optimizations may lead us to use different data
structures in different payloads.

So for now we decouple these two things:

    raw_info: this is intended to represent a
        snapshot of the latest data from the
        server, including some data like
        timestamps that are only used
        in downstream calculations and not
        user-facing

    exports.presence_info: this is calculated
        info for modules like buddy_data that
        just need to know active vs. idle and
        last_active_date

Another change that happens here is we rename
set_info_for_user to update_info_for_event,
which just makes it clear that the function
expects data in the "event" format (as opposed
to the format for page_params or server
responses).

As of now keeping the intermediate raw_info data
around feels slightly awkward, because we just
immediately calculate presence_info for any kind
of update.  This may be sorta surprising if you
just skim the code and see the various timeout
constants.  You would think we might be automatically
expiring "active" statuses in the client due to
the simple passage of time, but in fact the precise
places we do this are all triggered by new data
from the server and we re-calculate statuses
immediately.

(There are indirect ways that clients
have timing logic, since they ask the
server for new data at various intervals, but a
smarter client could simply expire users on its
own, or at least with a more efficient transfer
of info between it and the server. One of
the thing that complicates client-side logic
is that server and client clocks may be out
of sync.  Also, it's not inherently super expensive
to get updates from the server.)
 2020-02-10 14:37:44 -08:00
Steve Howell
75dbc4a2b1 presence: Extract presence.initialize(). 2020-02-10 14:37:44 -08:00
Anders Kaseorg
bafdf5229a js: Convert _.flatten(a, true) to [].concat(...a). 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-10 14:08:12 -08:00
Anders Kaseorg
62ad436c64 js: Convert _.compact(a) to a.filter(Boolean). 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-10 14:08:12 -08:00
Anders Kaseorg
d0b0a64af3 js: Convert _.isEmpty(a) to a.length !== 0. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-10 14:08:12 -08:00
Anders Kaseorg
8abf5da717 js: Convert _.isArray to Array.isArray. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-10 14:08:12 -08:00
Anders Kaseorg
e1cf5e4630 js: Convert _.reduce to less convoluted code. 
reduce is almost never a better solution than the alternatives.  Avoid
it.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-10 14:08:12 -08:00
Anders Kaseorg
612b237cec js: Convert remaining _.each(a, …) to a.forEach(…). 
The _.each calls with an inline function expression have already been
converted to for…of loops.  We could do that here, but using .forEach
when we’re just reusing an existing function seems like a good
guideline.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-10 14:08:12 -08:00
Anders Kaseorg
b566d11d69 js: Convert _.findIndex(a, …) to a.findIndex(…). 
And convert the corresponding function expressions to arrow style
while we’re here.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-10 14:08:12 -08:00
Anders Kaseorg
336a279005 js: Convert _.find(a, …) to a.find(…). 
And convert the corresponding function expressions to arrow style
while we’re here.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-10 14:08:12 -08:00
Anders Kaseorg
cdd774b790 js: Convert _.all(a, …), _.every(a, …) to a.every(…). 
And convert the corresponding function expressions to arrow style
while we’re here.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-10 14:08:12 -08:00
Anders Kaseorg
70ff164f89 js: Convert _.any(a, …), _.some(a, …) to a.some(…). 
And convert the corresponding function expressions to arrow style
while we’re here.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-10 14:08:12 -08:00
Anders Kaseorg
2285ee922e js: Convert _.contains(a, …) to a.includes(…). 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-10 14:08:12 -08:00
Anders Kaseorg
ef50346a29 js: Convert _.reject(a, … => …) to a.filter(… => !…). 
And convert the corresponding function expressions to arrow style
while we’re here.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-10 14:08:12 -08:00
Anders Kaseorg
4948240619 js: Convert _.filter(a, …) to a.filter(…). 
And convert the corresponding function expressions to arrow style
while we’re here.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-10 14:08:12 -08:00
Anders Kaseorg
ac7b09d57e js: Convert _.map(a, …) to a.map(…). 
And convert the corresponding function expressions to arrow style
while we’re here.

import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import K from "ast-types/gen/kinds";
import fs from "fs";
import path from "path";
import process from "process";

const checkExpression = (node: n.Node): node is K.ExpressionKind =>
  n.Expression.check(node);

for (const file of process.argv.slice(2)) {
  console.log("Parsing", file);
  const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
    parser: path.extname(file) === ".ts" ? tsParser : babelParser,
  });
  let changed = false;

  recast.visit(ast, {
    visitCallExpression(path) {
      const { callee, arguments: args } = path.node;
      if (
        n.MemberExpression.check(callee) &&
        !callee.computed &&
        n.Identifier.check(callee.object) &&
        callee.object.name === "_" &&
        n.Identifier.check(callee.property) &&
        callee.property.name === "map" &&
        args.length === 2 &&
        checkExpression(args[0]) &&
        checkExpression(args[1])
      ) {
        const [arr, fn] = args;
        path.replace(
          b.callExpression(b.memberExpression(arr, b.identifier("map")), [
            n.FunctionExpression.check(fn) ||
            n.ArrowFunctionExpression.check(fn)
              ? b.arrowFunctionExpression(
                  fn.params,
                  n.BlockStatement.check(fn.body) &&
                    fn.body.body.length === 1 &&
                    n.ReturnStatement.check(fn.body.body[0])
                    ? fn.body.body[0].argument || b.identifier("undefined")
                    : fn.body
                )
              : fn,
          ])
        );
        changed = true;
      }
      this.traverse(path);
    },
  });

  if (changed) {
    console.log("Writing", file);
    fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
  }
}

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-10 14:08:12 -08:00
Anders Kaseorg
719546641f js: Convert a.indexOf(…) !== -1 to a.includes(…). 
Babel polyfills this for us for Internet Explorer.

import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import K from "ast-types/gen/kinds";
import fs from "fs";
import path from "path";
import process from "process";

const checkExpression = (node: n.Node): node is K.ExpressionKind =>
  n.Expression.check(node);

for (const file of process.argv.slice(2)) {
  console.log("Parsing", file);
  const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
    parser: path.extname(file) === ".ts" ? tsParser : babelParser,
  });
  let changed = false;

  recast.visit(ast, {
    visitBinaryExpression(path) {
      const { operator, left, right } = path.node;
      if (
        n.CallExpression.check(left) &&
        n.MemberExpression.check(left.callee) &&
        !left.callee.computed &&
        n.Identifier.check(left.callee.property) &&
        left.callee.property.name === "indexOf" &&
        left.arguments.length === 1 &&
        checkExpression(left.arguments[0]) &&
        ((["===", "!==", "==", "!=", ">", "<="].includes(operator) &&
          n.UnaryExpression.check(right) &&
          right.operator == "-" &&
          n.Literal.check(right.argument) &&
          right.argument.value === 1) ||
          ([">=", "<"].includes(operator) &&
            n.Literal.check(right) &&
            right.value === 0))
      ) {
        const test = b.callExpression(
          b.memberExpression(left.callee.object, b.identifier("includes")),
          [left.arguments[0]]
        );
        path.replace(
          ["!==", "!=", ">", ">="].includes(operator)
            ? test
            : b.unaryExpression("!", test)
        );
        changed = true;
      }
      this.traverse(path);
    },
  });

  if (changed) {
    console.log("Writing", file);
    fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
  }
}

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-10 14:08:12 -08:00
Anders Kaseorg
788c5afbcf js: Convert _.indexOf(a, …) to a.indexOf(…). 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-10 14:08:12 -08:00
Anders Kaseorg
29dbf8ec77 schema: Convert _.find used as loop to for…of. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-10 14:08:12 -08:00
Anders Kaseorg
13b8bf830f message_viewport: Convert _.every used as loop to for…of. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-10 14:08:12 -08:00
Anders Kaseorg
4fbee73d1a emoji_picker: Convert _.any used as loop to for…of. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-10 14:08:12 -08:00