Anders Kaseorg
a682530fd4
node_tests: Enforce 100% coverage for test files.
...
This makes it easier to find obsolete parts of the tests that should
be cleaned up.
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2022-04-10 19:31:56 -04:00
Anders Kaseorg
f84a2c08d5
js: Prefix jQuery object variable names with $.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2022-03-16 12:52:07 -07:00
Steve Howell
9e657dd795
node tests: Use {override} in run_test.
2021-06-16 12:55:53 -04:00
Riken Shah
f95c539122
custom_check: Avoid use of assert to avoid confusion with assert.equal.
...
This commit bans the use of `assert` and replaces it
with `assert.ok` to avoid confusion with `assert.equal`.
Fixes #18687 .
2021-06-10 09:15:57 -07:00
Steve Howell
45fb7165b1
node tests: Test list cursor more directly.
...
This tests the basic mechanics of list_cursor
more directly than the activity node tests.
It also sets the stage to eliminate some
tests from activity.js while maintaining
100% coverage on list_cursor.
2021-05-18 14:16:55 -04:00
Steve Howell
dbd60d18fe
minor: Tweak list_cursor tests.
...
We just make the config a bit more explicit in
each test, and we use override to ensure that
stub functions aren't cruft.
2021-05-18 14:16:55 -04:00
Anders Kaseorg
3ef6f6e2e2
js: Convert static/js/blueslip.js to ES6 module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-03-17 08:47:15 -04:00
Anders Kaseorg
901a1e16cf
js: Convert static/js/list_cursor.js to ES6 module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-02-23 20:36:01 -08:00
Anders Kaseorg
89aa3155a9
node_tests: Don’t read from most deprecated global variables.
...
We still need to write to these globals with set_global because the
code being tested reads from them, but the tests themselves should
never need to read from them.
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-02-10 07:40:22 -08:00
Anders Kaseorg
21d432e12c
zjsunit: Deglobalize run_test.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2020-12-01 07:14:00 -05:00
Anders Kaseorg
425f1789e2
zjsunit: Deglobalize namespace.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2020-12-01 07:14:00 -05:00
Anders Kaseorg
7b03d48798
zjsunit: Deglobalize assert.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2020-12-01 07:14:00 -05:00
Anders Kaseorg
6ec808b8df
js: Add "use strict" directive to CommonJS files.
...
ES and TypeScript modules are strict by default and don’t need this
directive. ESLint will remind us to add it to new CommonJS files and
remove it from ES and TypeScript modules.
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2020-07-31 22:09:46 -07:00
Anders Kaseorg
2e94914be4
list_cursor: Convert list_cursor to an ES6 class ListCursor.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2020-07-26 17:00:05 -07:00
Anders Kaseorg
96dcc0ce6e
js: Use ES6 object literal shorthand syntax.
...
Generated by ESLint.
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2020-07-21 12:42:22 -07:00
Anders Kaseorg
f3726db89a
js: Normalize strings to double quotes.
...
Prettier would do this anyway, but it’s separated out for a more
reviewable diff. Generated by ESLint.
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2020-07-17 14:31:24 -07:00
Anders Kaseorg
615b7fcc2c
eslint: Enable arrow-body-style.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2020-07-03 16:55:50 -07:00
Rohitt Vashishtha
c8b0627ffe
zblueslip: Run blueslip.reset after each test.
...
This simplifies the blueslip interface to just declaring expected
errors and calling the code to test.
2020-04-20 08:17:20 -04:00
Steve Howell
f7b432afec
node tests: Auto-include zblueslip for node tests.
...
We already use blueslip stubs in ~45 tests, so we
may as well just auto-include it.
2020-04-03 12:56:49 -04:00
Steve Howell
df84c52a7f
zblueslip: Change API to expect/reset.
...
The `set_test_data` never made complete sense to
me, since it wasn't really data that we were
setting.
2020-04-03 12:56:49 -04:00
Steve Howell
bee592b44e
node tests: Bring list_cursor to 100% coverage.
...
We had some indirect coverage of this already, so
this mostly focuses on error cases and corner
cases.
2018-08-24 10:00:04 -07:00
