Earlier, we were passing the whole subscription object to the function
in order to check if the user was subscribed or not. In the future
commits, we want to check that without fetching and passing the complete
subscription object and this commit will help us do that.
When narrowed to an empty topic i.e. topic with no messages yet,
we show the topic name in the left sidebar topic list.
Earlier, it was not working for empty string topic.
This commit fixes the bug.
Instead of referring to users being added or removed from channels,
we now use subscribe or unsubscribed from channels.
Splits the article for adding and removing users from a channel
into separate articles: /help/subscribe-users-to-a-channel and
/help/unsubscribe-users-from-a-channel.
The URL redirects for the combined add/remove articles (for both
channel and stream terminology) go to the subscribe users to a
channel article.
This commit updates the styling of "Log in to browse
more channels" link in the left sidebar for logged out
users to match "BROWSE N MORE CHANNELS" link. If a string
exceeds the width of container then it would be wrapped
to the next line.
Fixes: #33108
For some cases, if the function called for testing events
changes some realm property using the realm object other
than the one derived from self.user_profile, then while
matching the states, self.user_profile still has the
old realm object.
This error occurred when opening the saved snippets dropdown while
editing a message caused by `get_offset_to_window()` expecting a
single JQuery element in the selected set. This function was used on
`$(this.dropdown_input_visible_selector)` which is a class selector
and can return multiple elements when multiple saved snippets button
are rendered.
This commit resolves this bug by creating dropdown widgets with unique
`widget_selector` for each saved snippets button.
Added `enable_guest_user_dm_warning` setting to decide whether
clients should show a warning when a user is composing to a guest
user in the organization.
Fixes#30078.
Co-authored-by: adnan-td <generaladnan139@gmail.com>
When we need to contact server to fetch messages around first
unread and we have `old_unreads_missing`, we use `first_unread`
as anchor instead of relying of first unread msg id calculated
locally for the narrow.
This commit also add the comma(,) and exclamation mark(!) to the
error messages wherever they were missing.
This commit modify the settings_change_error function to show the error
inside the modal, instead of the settings panel behind it.
Previously, if we had syntax in a URL slug that looked like a channel
ID, but we couldn't find the channel (say, beacuse it's a link to a
channel we're not subscribed to), parse_narrow would fail to parse it,
resulting in incorrect error handling.
This could break rendering of topic links that we want to process via
rendered_markdown.ts. I've confirmed that the web app's logic for
processing message_view.show does not require its caller to check the
channel ID is accessible.
The updated logic matches what we do in the mobile apps.
A regression was introduced in #33075 where user groups are only
rendered on the user profile modal once per page load since
user_groups_list_widget was not getting cleaned upon closing the modal.
Separates tests for Zoom and Big Blue Button video call
intgrations into separate sublcasses, ZoomVideoCallTest
and BigBlueButtonVideoCallTest respectively.
Refactors Realm.VIDEO_CHAT_PROIVDERS to have all the possible options
for video chat integrations, and use get_enabled_video_chat_providers
to compute the enabled options for the realm.
Prep for adding Zoom server to server video chat integration.
Earlier, in recent conversation, only streams had unread @-mention
indicators and DMs in recent conversation lacked them.
This commit introduces unread @-mention indicators for DM rows in recent
conversations using `unread_mention_dms` which stores `user_ids_string`
mapped to `message_id`s having mention.
Fixes: zulip#28849.
Earlier, in left sidebar, only streams had unread @-mention indicators
in individual streams and topics. DMs lacked unread @-mention
indicators.
This commit introduces unread @-mention indicators for DM rows in left
sidebar using `unread_mention_dms` which stores `user_ids_string` mapped
to `message_id`s having mention.
Fixes part of zulip#28849.
Earlier, only unread @-mentions in streams were shown in inbox view
while DMs lacked this indicators.
This commit introduces unread @-mention indicators for DM rows in inbox
view using `unread_mention_dms` which stores `user_ids_string` mapped to
`message_id`s having mention.
Fixes part of zulip#28849.
