Tim Abbott
9a83d21112
settings_users: Recalculate user ID lists after presence fetch.
...
This code is undertested, but it at least makes TypeScript happy.
2024-12-02 16:54:05 -08:00
Aman Agrawal
09e0ec35e1
narrow: Fix empty and_ depricated warning.
...
We can call `and_` with no arguments for `in-home` filter.
See https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/1682
for details.
2024-12-02 16:41:36 -08:00
Aman Agrawal
e5db6ac557
filter: Fix check for is personal filter.
2024-12-02 16:41:36 -08:00
Aman Agrawal
5ee62e599b
message_fetch: Extract function to standardize API parameters.
...
There some common checks we need to perform before requesting
messages from the server. We extract it to be used elsewhere.
2024-12-02 16:41:36 -08:00
Aman Agrawal
1954855b6a
message_fetch: Remove no longer needed check for home filter.
...
`Filter.public_terms` will return the same result even if the
narrow is combined feed. Since we are no longer passing
empty narrow parameters for combined feed, this condition is
not required.
2024-12-02 16:41:36 -08:00
Aman Agrawal
09c9db7b18
message_fetch: Remove inaccurate comment.
...
This comment became inaccurate as we made combined feed to no longer
be a special view.
2024-12-02 16:41:36 -08:00
Aman Agrawal
967fa0e24b
message_events: Remove non matching edited msgs from search result.
2024-12-02 16:41:36 -08:00
Aman Agrawal
6ca04056dc
message_list: Don't rerender if no messages were removed.
2024-12-02 16:41:36 -08:00
Aman Agrawal
17874e5747
message_events: Avoid populating from outdated cached msg data.
...
When we will no longer clear cached data on moving messages in
later commits, we have to clear cached data for the new filter when
changing narrow to avoid the message list from being populated
from it since the cached msg data is not updated as per the moved
topic and needs to be updated.
2024-12-02 16:41:36 -08:00
Aman Agrawal
1e13e3b287
message_events: Add comment.
2024-12-02 16:41:36 -08:00
Aman Agrawal
3fef305557
message_fetch: Extract part of post message fetch process.
...
This will be useful to separately call when restoring msg list
from cached msg list data.
2024-12-02 16:41:36 -08:00
Maneesh Shukla
dc70e50643
presence_data: Create new function to fetch data.
...
This change introduces a new function, fetch_presence_user_setting,
to retrieve presence data of users. The function fetches data for a very
long duration by setting the `history_limit_days` parameter to 365*1000.
Fixes #31039 .
2024-12-02 16:32:08 -08:00
Karl Stolley
e3fca21b27
buddy_list: Use opaque hover color for headings.
2024-12-02 16:11:17 -08:00
evykassirer
a6835fc2db
buddy_list: Show unsubscribed participants in participants list.
...
If a participant is unsubscribed, we still want to show them in
the participants list, since users might expect them to be there
anyways. We also already calculate the count including the
unsubscribed participants, so this fixes a bug where the count
could be higher than the list of people.
2024-12-02 13:19:19 -08:00
Aman Agrawal
35ffaff1f6
tusd: Allow user to upload files during preregistration.
...
Allow user to upload files during preregistration. This will be used
to upload import data.
Co-authored-by: Alex Vandiver <alexmv@zulip.com >
2024-12-02 10:21:45 -08:00
Aman Agrawal
2de868487b
confirmation: Allow using used confirmation objects if required.
2024-12-02 10:21:03 -08:00
Aman Agrawal
a8d0667b46
preregistration: Add field to track import progress.
...
We add a field to track user's progress and other details
during the import process.
2024-12-02 10:21:03 -08:00
Lauryn Menard
7a40462aed
support: Use datetime for push notification data in remote support.
2024-12-02 10:09:19 -08:00
Shubham Padia
6dcd4c4ca6
stream: Rename function to get defaults for stream permission groups.
2024-12-02 10:05:53 -08:00
Anders Kaseorg
a35addda73
eslint: Switch typescript-eslint to projectService.
...
This is recommended in typescript-eslint@8.
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2024-12-01 22:14:35 -08:00
Anders Kaseorg
d78902fac3
e2e-tests: Move test credentials to a JSON file.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2024-12-01 22:14:35 -08:00
Anders Kaseorg
5fbb60a849
lint: Correct path to ESLint configuration.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2024-12-01 22:14:35 -08:00
Anders Kaseorg
0b52105ebb
eslint: Provide empty webpack configuration.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2024-12-01 22:14:35 -08:00
Anders Kaseorg
7344340fe0
tsconfig: Remove *.js exclusion.
...
This improves the editor experience for *.js, and there’s not a big
performance impact anymore.
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2024-12-01 22:14:35 -08:00
Harsh
48200b1adc
recent: Fix showing No matches message while loading.
...
This commit ensures that "No conversations
match your filters." message is not displayed
while Recent conversations is loading
fixes #32503 .
2024-12-01 20:56:05 -08:00
Sahil Batra
0d5d305a47
register: Optmize computing can_invite_others_to_realm.
...
We already have fetched all the groups that the user is
member of, so we can just check if can_invite_users_group
is included in that list of groups like we do for similar
fields like can_create_public_streams, etc.
This helps us in saving a DB query.
Fixes #32408 .
2024-12-01 19:33:55 -08:00
Anders Kaseorg
dd3ed187f1
integrations: Convert module to TypeScript.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2024-12-01 19:33:16 -08:00
Anders Kaseorg
4dcd9b163e
integrations: Devirtualize pointless “dispatch” abstraction.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2024-12-01 19:33:16 -08:00
Shubham Padia
343741f621
stream: Fetch system groups in one query for group setting defaults.
...
Right now, the number of queries has remained the same, but when we add
more settings in the future, we won't be increasing the number of
queries when iterating over stream permission group settings.
2024-12-01 19:32:22 -08:00
Shubham Padia
940b7e38f8
stream: Use existing group declarations for can_unsubscribe_others.
...
The test was declaring all groups again and creating them, this commit
ensures that it uses the share-able code.
2024-12-01 19:32:22 -08:00
Shubham Padia
2a6765d8cf
stream: Remove unused variable from stream settings.
2024-12-01 19:32:22 -08:00
Shubham Padia
bfd5089837
stream_create: Loop over group setting when setting up widgets.
2024-12-01 19:32:22 -08:00
Shubham Padia
217bd0a334
stream: Loop over group settings for setup_group_setting_widgets.
...
We won't have to add another block of code here when adding a new
setting in the future.
2024-12-01 19:32:22 -08:00
Shubham Padia
dbf9f2d181
stream: Use generic update_stream_permission_group_setting.
...
We will not have to create a new function for every setting that we add
in the future.
2024-12-01 19:32:22 -08:00
Shubham Padia
771e076f1c
stream: Fix expected fields for group settings in a generic way.
2024-12-01 19:32:22 -08:00
Shubham Padia
b64cb102c2
stream: Handle group settings in a generic way in check_stream_update.
2024-12-01 19:32:22 -08:00
Shubham Padia
1139977f64
stream: Make group setting handling generic for add subscriptions.
2024-12-01 19:32:22 -08:00
Shubham Padia
9f6764a70a
stream: Do not use hardcoded default values for group settings.
...
We were using admins group as a hardcoded value for the default of
`can_remove_subscribers_group`, now we use a function to get the value
of the default group.
2024-12-01 19:32:22 -08:00
Anders Kaseorg
fcba1f03c4
drafts_overlay_ui: Convert module to TypeScript.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2024-11-30 18:41:42 -08:00
Anders Kaseorg
9c6d776a5c
messages_overlay_ui: Accept undefined for set_initial_element.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2024-11-30 18:41:42 -08:00
Anders Kaseorg
6c651f257d
messages_overlay_ui: Use strings as ids.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2024-11-30 18:41:42 -08:00
Aman Agrawal
fc6a479dc5
for-business: Remove Akamai quote.
2024-11-30 18:38:52 -08:00
Aman Agrawal
cca3c96f99
hello: Replace Akamai with Pilot logo.
2024-11-30 18:38:52 -08:00
Anders Kaseorg
d2c465960d
stream_popover: Treat propagate_mode as optional.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2024-11-30 18:38:11 -08:00
Aman Agrawal
94e0f66409
topics: Fix topic order after moving message without automated notice.
...
Previously, when a message was moved between two topics without
sending an automated notice, the ordering of these topics in the
left sidebar was not updated.
This is because the updated `max_message_id` of
`stream_topic_history` was always computed before the moved
message object's topic/channel were updated. This caused the
`max_message_id` of `stream_topic_history` which determines
the ordering of topics to always be the same.
This is fixed by making sure that the channel/topics of the objects
of the messages which were supposed to be moved were updated
before we compute this `max_message_id`
Co-authored-by: Rohan Gudimetla <rohan.gudimetla07@gmail.com >
2024-11-30 18:37:36 -08:00
Anders Kaseorg
1bf3bc0f18
dependencies: Move stylelint-high-performance-animation to devDependencies.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2024-11-27 23:27:38 -08:00
Anders Kaseorg
040469ada8
dependencies: Move @babel/register to devDependencies.
...
This is not needed in production as of #32327 .
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2024-11-27 23:27:38 -08:00
Anders Kaseorg
ee11d73c1f
user_card_popover: Convert module to TypeScript.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2024-11-27 22:05:38 -08:00
Anders Kaseorg
d8d8e620e7
topic_popover: Convert module to TypeScript.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2024-11-27 22:02:43 -08:00
Anders Kaseorg
5d94541b6d
dependencies: Downgrade @uppy/tus from 4.1.4 to 4.1.3.
...
It seems 4.1.4 is causing the client to ask the server to delete each
upload immediately when it succeeds.
https://chat.zulip.org/#narrow/channel/9-issues/topic/broken.20image.20uploads/near/1989833
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2024-11-27 21:58:59 -08:00