paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-07 07:23:22 +00:00
Code Issues Packages Projects Releases Wiki Activity
9,179 Commits 30 Branches 160 Tags
1613cad6f68460b3ae59285c4275c7de50a4b51c
Commit Graph

3 Commits

Author SHA1 Message Date
Jason Michalski
1613cad6f6 Separate the global message data from the list display data 
The messages being passed to the handlebars templates were global
messages which we were adding per list details to, show name bar etc.
This causes rendering bugs when you try to rerender a message, because a
different list may have changed it. This commit moves the global message
data to a msg attribute on the message_container which will contain the
per list attributes.

(imported from commit 26b1f0d2c72d6288a6d3e7ed5f8692426f2a97ad)
 2014-03-18 15:02:31 -04:00
Jason Michalski
c38c9cf894 Me messages should always display the sender 
(imported from commit af42ed8dcb9f4bc44e66d4973b9e613302647e12)
 2014-03-16 15:14:57 -04:00
Jason Michalski
a9235a74f4 Split the group merging logic form the DOM update logic 
The goal is to have a more data centric piece that can be unit tested.
We also try to minimise the number of one off jQuery DOM updates and
rerender handlebars fragments instead. This will prevent the
message_group and DOM from drifting apart and not being able to rerender
correctly.

(imported from commit 03f09803f2bc0c3b8187f76f2cfe90be9f7512a3)
 2014-03-14 20:48:59 -04:00