We align bottom border radius with that of the popover to get
border to appear around the bottom edges.
`height` was not required on `emoji-picker-popover` as the height
is already being limited by `.emoji-popover-emoji-map` which
is enough to get the scrolling effect on overflow.
Earlier, for 'realm_mandatory_topics=False' the compose_state.topic
was set much later in the 'update_topic_displayed_text' codepath.
It resulted in buggy placeholder behaviour because '$input.val()'
in 'update_placeholder_visibility' returned an outdated value.
This commit fixes the bug by setting compose_state.topic early.
Previously, `update_topic_displayed_text` used
`.show(10, update_placeholder_visibility)`, which introduced a delay
before updating the topic placeholder visibility.
This caused a bug where consecutive calls to
`update_topic_displayed_text` due to 'focus' and 'blur' on topic box
within a short duration resulted in setting the `visibility: hidden`
twice before the `visibility: visible` due to focus was set.
The delay resulted in overlapping placeholder.
This commit removes the delay to ensure immediate execution,
preventing inconsistencies.
Previously, clicking on the bouncing "..." (indicating an ongoing
edit) did not open the edit history modal, even when the message had
prior edits. This made it difficult for users to view the edit history
while an edit was in progress.
This commit updates the behavior so that if a message has an edit
history, clicking on the bouncing "..." will open the edit history
modal, just as clicking on the "EDITED" notice does. If no prior edits
exist, the indicator doesn't show any tooltip.
This was happening since the conditions for `reference` being
hidden assumed that the reference was in message feed which
excludes the navbar and compose box area.
To fix it, we only set `show_as_overlay_if_reference_hidden_at_trigger`
as `true` if the reference is inside the message feed.
This does lookups by email address, which is very much a legacy way to
do things, and could throw exceptions if trying to lookup details on
an unknown user ID.
This is part of an effort to remove all pixel font sizes
from most stylesheets. We won't scale this with font size
because the flatpickr doesn't scale with font size.
Commit dd7cf277 added a condition in `render_and_show_preview`
function to skip rendering if the compose box’s preview mode
wasn’t active. This broke preview mode in message editing, as
it relies on the same function.
This commit fixes the issue by refactoring `render_and_show_preview`
to accept an element instead of hardcoding `#compose` when checking
for preview mode, and updates its usages accordingly.
Previously, the URL was updated only on "change" event, waiting for
a focus shift from the text inputs. Switched it to "input" so that the
user can see the effects of the changes they're making as they're doing
it.
- Made the branch-filtering checks uniform across all the integrations,
by adding a helper function to git.py, and re-using it.
- Instead of checking if the name of the branch that generated the
event is a substring of the "branches" parameter, we now check if
there's an exact match.
For example, if there are two branches named "main" and
"release/v1.0-main", and the user wants to track pushes to only the
"release/v1.0-main" branch, they wouldn't have been able to
previously, it will always track pushes to both branches. There was no
way to filter out the smaller named branch when there were overlaps.
Edited the git-append-branches.md macro to match the previous
git-branches-additional-feature.md macro, and moved it inside the
webhook-url-with-bot-email.md macro, as it's only ever used
immediately after that macro.
- generate-integration-url.md has been long replaced by the
generate-webhook-url-basic.md.
- webhook-url.md was only being used inside the above macro.
Updated the Git-related integrations that support branch filtering:
- Removed the branch-filtering configuration option, and its macro.
- Added a new macro that integrates the branch-filtering instruction
with the Generate-URL step.
The new macro `generate-webhook-url-with-branch-filtering` builds off of
the `generate-webhook-url-basic` macro, adding only the branch filtering
instruction. But, it does not re-use the macro, instead duplicates it,
to avoid the newline break that would be added otherwise.
This commit resolves the misalignment issue for the privacy icons and
stream names along with their horizontal alignment with the subscription
button. The icons were previously not properly placed with the text,
causing a visual discrepancy.
While we're at it, we replace the first-of-type/last-of-type styles
with normal classes elements, which is more performant and readable.
Fixed#31521.
Co-authored-by: Aditya Kumar Kasaudhan <74228301+Aditya8840@users.noreply.github.com>
This commit ensures the `message_edit_history_visibility_raw`
parameter is validated using the policy names defined in the
`MessageEditHistoryVisibilityPolicyEnum`, used in the
`update_realm()` function in the `zerver/views/realm.py` file.
Follow up of #32840.
The cron jobs are potentially wrapped by Sentry, which logs "cron
failures" and sends emails. We would like those failures to only be
when the cron job itself failed to run successfully -- not when the
underlying metric is outside of its normal range. We would like to
differentiate a failure of the monitoring infrastructure from a
failure of what it is monitoring.
Swap to return 0 on everything except "unknown" results.
