paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-08 16:01:58 +00:00
Code Issues Packages Projects Releases Wiki Activity
47,904 Commits 30 Branches 160 Tags
16b51ef437f9b074711a76b1c4a09dbaa7f3e6d3
Commit Graph

90 Commits

Author SHA1 Message Date
Anders Kaseorg
f84a2c08d5 js: Prefix jQuery object variable names with $. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-16 12:52:07 -07:00
Anders Kaseorg
513207523c js: Fix various sloppy uses of String#replace. 
Prefer a regexp match over using String#replace to strip expected
prefixes and suffixes because (a) it implicitly verifies that the
input has the expected format and (b) it won’t unexpectedly strip from
the middle of the string.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 12:26:49 -08:00
Anders Kaseorg
c6b372b471 js: Simplify indexing arrays from the end with Array#at. 
https://github.com/tc39/proposal-relative-indexing-method

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-01-24 09:58:54 -08:00
Aini-Alem Robertson
e9d80390cc stats: Remove complex regex badly implementing toLocaleString. 
This regular expression to add commas to a large number is hard to
read and produces less useful output than using the standard browser
API for doing this.

Fixes #20416.
 2021-12-02 14:35:56 -08:00
Anders Kaseorg
ad7466a2bf dependencies: Upgrade JavaScript dependencies. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-06-08 10:15:52 -07:00
Anders Kaseorg
2004a85fb1 i18n: Automatically convert remaining JavaScript messages to FormatJS. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-13 17:41:10 -07:00
Anders Kaseorg
9985ce077b stats: Convert total message to FormatJS. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-13 17:41:10 -07:00
Aman Agrawal
2e2ff568ba stats: Show tooltips using tippyjs. 
We don't want to import tippyjs module here
along with its dependencies, so we just copied
over tippyjs defaults here. They should be
work fine for /stats page even if we decide to change
defaults for the app in tippyjs and forget to do
it here.
 2021-04-07 17:11:23 -07:00
Anders Kaseorg
38ffd47b90 js: Convert static/js/page_params.js to ES6 module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-26 10:17:56 -07:00
Anders Kaseorg
bb1b2048bd js: Convert static/js/i18n.js to ES6 module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-26 10:17:56 -07:00
Anders Kaseorg
ea9ca6b7d0 js: Use jQuery as a module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-12 10:08:25 -08:00
Anders Kaseorg
b38712d8d2 js: Convert residual require() calls to import in ES6 modules. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-02 17:06:35 -08:00
Anders Kaseorg
ba0ee6ddfa dependencies: Upgrade Source Sans Pro font to Source Sans 3. 
https://blog.adobe.com/en/2020/11/30/whats-new-in-source-sans-3.html

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-02-23 14:55:33 -08:00
Anders Kaseorg
3a110e6419 js: Convert static/js/stats/stats.js to ES6 module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-02-10 10:27:14 -08:00
Anders Kaseorg
552f4e3d22 eslint: Fix unicorn/no-array-for-each. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-01-25 14:53:19 -08:00
Anders Kaseorg
d72f7d1d69 eslint: Fix unicorn/prefer-number-properties. 
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v24.0.0/docs/rules/prefer-number-properties.md

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-12-22 16:14:28 -08:00
Anders Kaseorg
e68595a3fc eslint: Fix unicorn/no-reduce. 
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/no-reduce.md

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-07 16:00:33 -07:00
Anders Kaseorg
de791b82b6 eslint: Fix unicorn/no-for-loop. 
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/no-for-loop.md

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-07 16:00:33 -07:00
Anders Kaseorg
70a0260ac1 eslint: Fix unicorn/prefer-text-content. 
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-text-content.md

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-07 16:00:33 -07:00
Anders Kaseorg
bd05f1c9f8 eslint: Fix unicorn/prefer-query-selector. 
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-query-selector.md

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-07 16:00:33 -07:00
Abhijeet Prasad Bodas
4e6c0989db stats: Fix a string not tagged for translation. 
Part of #16094.
 2020-09-25 16:20:53 -07:00
Tim Abbott
dedb28055a stats: Fix a few strings not tagged for translation. 2020-08-10 16:26:37 -07:00
Anders Kaseorg
6ec808b8df js: Add "use strict" directive to CommonJS files. 
ES and TypeScript modules are strict by default and don’t need this
directive.  ESLint will remind us to add it to new CommonJS files and
remove it from ES and TypeScript modules.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-31 22:09:46 -07:00
Anders Kaseorg
584d6bfa41 stats: Use Plotly.js as a module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-28 10:54:35 -07:00
Anders Kaseorg
96dcc0ce6e js: Use ES6 object literal shorthand syntax. 
Generated by ESLint.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-21 12:42:22 -07:00
Anders Kaseorg
4e42137bd9 js: Replace deprecated jQuery event handler shorthand. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-21 12:01:26 -07:00
Anders Kaseorg
97feea42a1 js: Replace deprecated jQuery.fn.hover. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-21 12:01:26 -07:00
Anders Kaseorg
b65d2e063d js: Reformat with Prettier. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-17 14:31:25 -07:00
Anders Kaseorg
883e2fd325 js: Remove inner spacing from object literals. 
We’re configuring Prettier with bracketSpacing: false.  Generated by
ESLint.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-17 14:31:25 -07:00
Anders Kaseorg
f3726db89a js: Normalize strings to double quotes. 
Prettier would do this anyway, but it’s separated out for a more
reviewable diff.  Generated by ESLint.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-17 14:31:24 -07:00
Anders Kaseorg
e014ea966a eslint: Enable comma-dangle for functions. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-03 16:55:51 -07:00
Anders Kaseorg
a79322bc94 eslint: Enable prefer-arrow-callback. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-03 16:55:50 -07:00
arpit551
0c6488b284 analytics: Added frontend for messages read over time graph. 
The chart added is similar to the messages sent over time chart.

Fixes #15167
 2020-06-20 16:52:33 -07:00
Anders Kaseorg
62fcf98b6f js: Use hasOwnProperty correctly or not at all. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-05-26 23:33:40 -07:00
Anders Kaseorg
eee784312d stats: Fix Other calculation. 
In commit 2248d4d9a4 (#13883) I
incorrectly migrated a loop.  Fixes #14052.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-02 17:45:44 -08:00
Anders Kaseorg
6f32ef749f js: Convert $.extend to spread syntax. 
This is not always a behavior-preserving translation: $.extend mutates
its first argument.  However, the code does not always appear to have
been written to expect that.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-25 14:09:39 -08:00
Anders Kaseorg
2248d4d9a4 stats: Convert data from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
59d55d1e06 js: Use modern spread arguments syntax. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-11 17:43:35 -08:00
Rohitt Vashishtha
e2c563d14d minor: Replace Math.min() with Infinity for easier to read code. 2019-12-06 11:27:58 -08:00
Anders Kaseorg
28f3dfa284 js: Automatically convert var to let and const in most files. 
This commit was originally automatically generated using `tools/lint
--only=eslint --fix`.  It was then modified by tabbott to contain only
changes to a set of files that are unlikely to result in significant
merge conflicts with any open pull request, excluding about 20 files.
His plan is to merge the remaining changes with more precise care,
potentially involving merging parts of conflicting pull requests
before running the `eslint --fix` operation.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2019-11-03 12:42:39 -08:00
Anders Kaseorg
7ae84d5ce1 js: Break lines that become too long after converting var to const. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2019-10-28 15:02:43 -07:00
Anders Kaseorg
46e562f990 bootstrap: Change tooltip html default to false. 
Bootstrap v2.2.0^2~40^2~6 changes this default to false, so this is a
prerequisite to upgrading Bootstrap, and it’s also safer.

This closes an HTML injection path via user full names in the emoji
reaction tooltip.  It doesn’t appear to be exploitable for cross-site
scripting because we disallow `>` in full names, and the code happens
to be written such that the next `>` is in a different parser
invocation.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2019-09-19 20:53:10 -07:00
Vishnu Ks
150d9c9d3e stats: Fix the bug in showing all time actives by default. 
Followup commit of 0b1e36db27
 2019-02-01 11:14:03 -08:00
Vishnu Ks
5fec84221e stats: Make all time active users graph default. 
We now bill by total users, whereas we used to
bill by 15 day actives.
 2019-01-26 12:19:59 -08:00
Nikhil Kumar Mishra
478674a6d6 analytics: Refactor to support more than one tooltip on same page. 
While we don't actually need another tooltip on /stats right now, this
provides a clear approach for how to do that.  We've since added
tooltips in various other parts of the webapp, and that code is pretty
copy-pasteable, so I think it's reasonable to say this closes #4612.

Cleaned up by tabbott to remove a bunch of unnecessary changes.
 2018-11-28 16:04:35 -08:00
Shubham Dhama
80a2d5bc59 eslint: Enable conditionalAssign config of no-trailing-spaces rule. 2018-06-11 07:51:24 -04:00
Shubham Dhama
cc03f9fb8f eslint: Enable space-infix-ops rule. 
More about rule at  https://eslint.org/docs/rules/space-infix-ops
 2018-06-05 00:47:35 +05:30
Anupam Dagar
562f5387e3 analytics: Add "last 2 months" and "last 6 months" button. 
This commit removes "last 30 months" button and includes some layout changes so as to accomodate rangeslider with extra introduced buttons.
 2018-06-01 12:07:18 -07:00
Anupam Dagar
0f55b56398 analytics: Add a rangeslider to the "number of users" plot. 
This also requires some layout/spacing changes, since the rangeslider
takes up some space.

Fixes: #9557.
 2018-06-01 08:51:53 -07:00
Rishi Gupta
d28a4d1f86 stats: Remove hour from on-hover date for Number of users. 2018-05-26 12:08:05 -07:00