paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-29 11:03:54 +00:00
Code Issues Packages Projects Releases Wiki Activity
66,898 Commits 30 Branches 160 Tags
1f4267f3e0b4c604abfe55abd9cd239296b14614
Commit Graph

137 Commits

Author SHA1 Message Date
Tim Abbott
b1ad7593ba validators: Improve mypy type annotations. 
The main thing here is writing check_string_fixed_length and
check_capped_string as returning a Validator, but we also fix issues
around passing default=None.
 2018-05-03 21:27:43 -07:00
Tim Abbott
ad0cfb3512 validators: Add check_string_fixed_length. 
This will be useful in some upcoming work on zilencer.
 2018-05-03 14:30:03 -07:00
Tim Abbott
594451707d check_capped_string: Clean up corner case. 
We were rejecting strings of length equal to the max.

While we're at it, fix the unnecessary period in the error message,
which doesn't align with similar validators.
 2018-05-03 14:30:03 -07:00
Yashashvi Dave
4033f210af custom fields: Add support for custom date field type. 2018-04-30 23:04:25 +05:30
Tim Abbott
976e61d687 validators: Improve error messages for check_capped_string. 2018-04-30 10:07:06 -07:00
Umair Khan
cf2f6b38dd profile: Add choice field. 
Fixes part of #8878
 2018-04-26 00:35:51 -07:00
Umair Khan
00ffa808da check_capped_string: Return a validator. 
This allows us to create custom validators.
 2018-04-19 11:21:50 -07:00
Umair Khan
e48f8bdafd check_short_string: Use check_capped_string for impl. 2018-04-02 09:51:09 -07:00
Umair Khan
7fdf043564 profile: Set max length for long text to 500. 2018-04-02 09:51:09 -07:00
Umair Khan
1d4b74482c check_short_string: Change max_length to 50. 2018-04-02 09:51:09 -07:00
neiljp (Neil Pilgrim)
090b47ed19 mypy: Add explicit Optional for default=None parameters in various files. 2018-03-28 12:31:51 -07:00
neiljp (Neil Pilgrim)
5726d26d50 mypy: Use centralized Validator in request.pyi & validator.py. 
These changes are in one commit, since the previous typing of check_url
does not match the centralized strict definition (object/Any vs Text),
actually already used elsewhere in validator.py, and also had a different
API.

check_url is updated here to match the API of the other check_* functions,
ie. val is an object (not Text) & returns Optional[str]. It also now checks
the value is text explicitly at run-time, which was only type-checked
previously. Tests are updated accordingly.
 2018-03-16 13:30:32 -07:00
Robert Hönig
dcd62f92fb validator.py: Extend functionality of check_dict(). 
With this commit, check_dict() can be used to verify
that all keys and/or values of a dict are of a certain
type.
 2018-01-07 20:04:52 +01:00
Tim Abbott
a23378a304 check_short_string: Verify string before checking length. 
While the previous implementation was correct, this should give better
error messages.
 2017-11-10 16:37:43 -08:00
neiljp (Neil Pilgrim)
72eba6a0ce mypy: Adjust validator.py to use object rather than Any. 2017-11-10 16:37:29 -08:00
neiljp (Neil Pilgrim)
331a3c3447 mypy: Migrate validator.py typing to python3 syntax. 2017-11-10 16:32:25 -08:00
rht
035ed93111 zerver/lib: remove import six. 2017-09-27 19:10:28 -07:00
rht
f43e54d352 zerver/lib: Remove absolute_import. 2017-09-27 10:00:39 -07:00
vaibhav
42af09663d validators: Add check_url validator. 
This just uses Django's existing validator, and reformats its
interface to work with has_request_variables.
 2017-06-15 15:03:26 -07:00
umkay
ccc70445d6 mypy: Fix strict-optional errors for test files. 
Fix mypy --strict-optional errors in zerver/tests
 2017-05-24 12:43:28 -07:00
Umair Khan
cf3b6c6ca9 profile: Support custom profile data. 
Implements backend for #1760.
 2017-04-18 15:20:59 -07:00
Umair Khan
ad2114a7a8 validator.py: Create a validator for login email. 
This validator raises JsonableError exception.

Fixes: #2748
 2017-04-13 12:48:13 -07:00
Tim Abbott
118f2db22d validators: Add a test_dict_only validator that bans other arguments. 
This is primarily intended to be useful in EventsRegisterTest.
 2017-03-26 13:10:54 -07:00
Tim Abbott
d1760a1bb9 validators: Add check_float validator. 2017-03-23 21:23:41 -07:00
Tim Abbott
b81fd407e8 mypy: Fix several Optional typing errors. 2017-02-10 23:53:44 -08:00
David Adamec
9e8ea93d3d Add annotations for zerver/lib/validator. 2016-06-03 23:53:49 -07:00
Umair Khan
08fbd57245 [i18n] Make error messages translatable. 
Make all strings passing through `json_error` and `JsonableError`
translatable.

Fixes #727
 2016-05-31 07:40:42 -07:00
Tim Abbott
41336f3782 lint-all: Check for use of '== None'. 2016-05-31 07:02:04 -07:00
Tim Abbott
ee6062691a Fix missing None in check_none_or return. 2016-02-03 19:25:18 -08:00
Tim Abbott
651b011514 Apply Python 3 futurize transform libmodernize.fixes.fix_basestring. 2015-11-01 09:26:16 -08:00
Jason Michalski
c17ed8dc8c Add bots to page_params and send events on bot creation 
(imported from commit ce418b4f056576d57f82d26af621473c730c12d8)
 2014-03-05 14:16:19 -05:00
Jessica McKellar
816c0a4393 Add a validator for arguments that are of a variable type. 
We'll need this to validate subscription properties, which can be
strings or booleans.

(imported from commit 2572e334cd04ffe05151cba266e15a0ea7ae21c5)
 2014-03-03 16:08:33 -05:00
Steve Howell
3d04f5f738 Use check_list instead of json_to_list. 
(imported from commit 9ead12bc2a4744b94a747ca27054124aacde7ae4)
 2014-02-18 13:02:08 -05:00
Steve Howell
7449079191 Validate schema of events in EventsRegisterTest. 
For EventsRegisterTest that test updates to streams and
subscriptions, we now validate the events generated by
the actions under test conform to predicted schemas.

We define the schemas with help from the validators code
that is also sometimes used to validate incoming request
parameters for our views.

(imported from commit b4222b920a588e15cccee4a2349c074ca9697448)
 2014-02-04 16:25:32 -05:00
Steve Howell
be1857ceb3 Add blank line to check_list (cosmetic). 
(imported from commit 20a9eed98846e976c7fa2cfdb43e25e1c43c850d)
 2013-12-18 12:47:32 -05:00
Steve Howell
6f573feaeb Add "length" option to check_list validator. 
(imported from commit 4f8e203f964d1c936fe548b2f77a2e4aae745ae9)
 2013-12-18 12:45:29 -05:00
Steve Howell
4184b9d56f Add validators.py (with tests). 
This sets up a scheme to validate complex data structures and
give specific error messages for improperly typed parameters.

(imported from commit 33b2f070d993da4ee929119dd41503bd0128c8eb)
 2013-12-13 18:19:07 -05:00