paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-18 04:43:58 +00:00
Code Issues Packages Projects Releases Wiki Activity
56,551 Commits 30 Branches 160 Tags
29dd61c20cbef3ff99f21d5450e7c8dba10c969c
Commit Graph

8157 Commits

Author SHA1 Message Date
Nathan Florea
6bcb6c3192 Removed some unused imports. 2016-06-07 18:13:58 -07:00
Nathan Florea
f11eee8b41 Remove redundant file open. 
Calling open() with mode 'w' or 'a' will create a file if it doesn't exist,
while mode 'r' will cause an exception.  This can be easily tested with:
python -c 'open("test.tmp", "w")'
ls test.tmp
 2016-06-07 18:10:44 -07:00
Conrad Dean
fe2c352ac0 ClientDescriptor: Pass inline sets, not lists, to do_gc_event_queues. 
This allows us to more precisely type do_gc_event_queues.
 2016-06-07 13:28:45 -07:00
Conrad Dean
d77c70220c send_event: Remove useless return value and annotate. 
Detected by mypy.

[tweaked by tabbott to pass mypy check and remove annotations]
 2016-06-07 13:27:40 -07:00
Conrad Dean
a4704ba8b2 event_queue: Fix deque values type annotation. 
Event IDs in here are ints, as shown by the prune operation.
 2016-06-07 13:05:46 -07:00
Vishnu Ks
f3a8962612 Replace make_dict() with stream.to_dict(). 2016-06-06 14:46:12 -07:00
Daw-Ran Liou
70f44c00b0 check_send_message: Replace args/kwargs with explicit args. 
This lets us actually type-checks the various views that are using
check_send_message.
 2016-06-05 14:30:38 -07:00
Max
86fb6467e7 Add annotations to avatar.py, db.py, logging_util.py, unminify.py. 
Also, fixed a a small type annotation in users.py because email must
be a string because emails don't support UTF-8 at this time (according
a comment in gravatar_hash in avatar.py).
 2016-06-05 12:38:20 -07:00
Deborah Hanus
a261a6bbac Annotate zerver/views/__init__.py. 
Also fix typing errors in a few related files.

[with tweaks from tabbott]
 2016-06-05 11:34:19 -07:00
Tim Abbott
15b2dd085e Annotate zerver.lib.test_runner. 2016-06-04 23:23:31 -07:00
Tim Abbott
1ca7c3378b Annotate zerver.lib.testing_mocks. 
Also fix some annotations in bugdown to match.
 2016-06-04 22:54:49 -07:00
Conrad Dean
33dee43179 Annotate zerver/lib/socket.py. 
Currently this uses a Union type for connection_id; we need to figure
out what actually sets that and what its type is and fix that later
(see https://github.com/zulip/zulip/issues/896).
 2016-06-04 22:36:03 -07:00
medullaskyline
47c3ec1283 Annotate zerver.lib.upload. 2016-06-04 19:13:03 -07:00
Umair Khan
1bfe566c8d [i18n] Make Json error messages translatable. 2016-06-04 18:48:36 -07:00
medullaskyline
fcdcccb5df Annotate zerver.lib.digest. 2016-06-04 16:20:18 -07:00
medullaskyline
7c2c7fb31c Annotate zerver/lib/bulk_create.py. 2016-06-04 15:51:05 -07:00
Max
04e2745136 Annotate debug.py, initial_password.py, narrow.py, response.py. 
Also, fixed up the annotations for tornadoviews to better align with
how narrows was defined as `Iterable[Sequence[str]]` rather than
`List[Tuple[str, str]]`.
 2016-06-04 12:56:36 -07:00
medullaskyline
7b2db95d02 Annotate zerver/lib/ccache.py. 2016-06-04 12:19:34 -07:00
Tim Abbott
f1d58e767b Annotate zerver/tests/test_subs.py. 
This required a number of unique-related changes to test_helpers.
 2016-06-04 11:53:10 -07:00
Tim Abbott
6f69053911 Annotate most of the rest of bugdown. 2016-06-04 11:35:29 -07:00
Max
c8dc033c3c Annotate camo.py, mandrill_client.py, query.py, session_user.py 2016-06-04 11:28:42 -07:00
David Adamec
9e8ea93d3d Add annotations for zerver/lib/validator. 2016-06-03 23:53:49 -07:00
David Adamec
4f3c85a20c Add type annotations to zerver/lib/rest. 2016-06-03 23:48:46 -07:00
Conrad Dean
e7f0698884 Annotate zerver/lib/notifications.py. 2016-06-03 23:45:29 -07:00
Tim Abbott
7fd2956f29 clear_followup_emails_queue: Rename confusing local variable. 2016-06-03 23:45:29 -07:00
medullaskyline
cb84f72f2d Annotate zerver/lib/html_diff.py. 2016-06-03 23:21:26 -07:00
Tim Abbott
e89730dc8f subject_links: Remove useless RealmFilter.DoesNotExist case. 2016-06-03 23:18:39 -07:00
David Adamec
8ad20e9775 mypy type annotations for zerver/lib/utils 2016-06-03 22:58:15 -07:00
Tim Abbott
1552b9308b Fix apnsclient import to match version 0.1.8 used in production. 
Apparently, apnsclient moved Connection to a different module between
0.1.8 and 0.2.1.
 2016-06-03 19:28:36 -07:00
Max
0f4673ae3b Add type annotation to mention.py, redis_utils.py, timestamp.py, user_agent.py 
Some functions in models.py had input typed as int when they needed to be typed as datetime.datetime
 2016-06-03 19:00:16 -07:00
Tim Abbott
654bd663aa bugdown: Add annotations for a few more functions. 
This resolves the issue with Typeshed #244 by making `upload_re` start
with `ur`.
 2016-06-03 18:11:53 -07:00
Tim Abbott
f97b025a33 push_notifications: Fix incorrect Connection import. 2016-06-03 18:11:53 -07:00
medullaskyline
303bd21068 Annotate zserver.lib.push_notifications. 2016-06-03 17:45:54 -07:00
Oren Leaffer
2916fb30cb bugdown: add some type annotations. 
Had to add some "type: ignore" because the pattern used in match
doesn't affect the type returned. A fix for this issue has been pushed
to typeshed - https://github.com/python/typeshed/pull/244
 2016-06-03 17:03:52 -07:00
medullaskyline
2213a9f41f Annotate zerver/lib/cache_helpers.py 2016-06-03 16:34:30 -07:00
Conrad Dean
7f61a5e862 Add type annotations to zerver.lib.test_helpers. 2016-06-03 12:17:26 -07:00
Nathan Florea
04c71fadc6 More removal of mutable default arguments. 
I've left a few that clearly aren't being passed and aren't being mutated, but
I think I've gotten the rest of them.
 2016-06-03 09:17:04 -07:00
Nathan Florea
5fe9076631 Remove some mutable default arguments. 
These ones don't fix any bugs, because the mutable arg is never passed
outside of the callable or mutated.  But it's good practice to not use
them in case those invariants are changed in the future.
 2016-06-03 09:16:56 -07:00
Ashish Kumar
31bf6b8259 Type annotation of zerver/models.py 
[Substantially revised by tabbott]

This probably still has some bugs in it, but having mostly complete
annotations for models.py will help a lot for the annotations folks
are adding to other files.
 2016-06-02 23:28:34 -07:00
Ashish Kumar
cad342aff6 Correct annotation of generic_bulk_cached_fetch in zerver/lib/cache.py. 
Previously, object_ids was tagged as an int, but it is called from
models.py with a string, so we make it an Any.
 2016-06-01 14:00:49 -07:00
Umair Khan
08fbd57245 [i18n] Make error messages translatable. 
Make all strings passing through `json_error` and `JsonableError`
translatable.

Fixes #727
 2016-05-31 07:40:42 -07:00
Tim Abbott
960144a49e Desupport using uninstantiated REQ with has_request_variables. 
This makes life difficult for doing static type annotations, and
didn't make the code look that much better anyway.
 2016-05-31 07:31:15 -07:00
Tim Abbott
41336f3782 lint-all: Check for use of '== None'. 2016-05-31 07:02:04 -07:00
Umair Khan
c884559ec6 Show templates rendered report. 
Add two options to the `test-backend` script:

1. verbose
    If given the `test-backend` script will give detailed output.
2. no-shallow
    Default value is False. If given the `test-backend` script will
    fail if it finds a template which is shallow tested.
 2016-05-31 16:46:11 +05:00
Tomasz Kolek
8e144a1f57 Add zip and absoulte_import to pass py3k test. 2016-05-30 22:28:05 +02:00
Reid Barton
8c6afac7cd Add a stub file for request.py. 
This stub file allows us to annotate view functions using the actual
types present in the bodies of the functions, rather than everything
having the type REQ.
 2016-05-30 11:28:53 -07:00
Tim Abbott
572c69f3c2 Move REQ and friends to their own module. 2016-05-30 11:24:17 -07:00
Eklavya Sharma
48e7e1a2a1 zerver/lib/actions.py: Rename stream_name to stream. 
In function bulk_add_subscriptions, some variables were named
`stream_name` but their type is Stream, not a string.  Rename
those variables to `stream`.
 2016-05-30 09:52:59 -07:00
Eklavya Sharma
94e4b39112 Replace python2.7 by python everywhere. 2016-05-29 05:03:08 -07:00
Eklavya Sharma
149938d468 Change shebangs from python2.7 to python. 2016-05-29 05:03:08 -07:00