Steve Howell
ff09d8af03
node tests: Test empty string for input_pill.
2021-03-05 12:57:20 -05:00
Steve Howell
f6edaaab96
node tests: Test upload.feature_check directly.
2021-03-05 12:57:20 -05:00
Steve Howell
779f56d411
node tests: Add test for compose_state.
2021-03-05 12:57:20 -05:00
Steve Howell
886e419731
node tests: Directly test how we add/remove rtl class.
2021-03-05 12:57:20 -05:00
Anders Kaseorg
62532777b1
server_events: Replace deprecated $.now alias.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-03-04 18:07:47 -08:00
m-e-l-u-h-a-n
f4a111e314
compose: Add user presence circles in mention and pm typeahead.
...
This commit addresses the problem of user's status visibility to
some extent. It adds presence circles, like we have in buddy_list to the
typeahead suggestions that are given for mentioning users in messages.
Tweaked by tabbott to adjust vertical alignment of group mentions as well.
Testing for the changes is done manually in the developement server,
and also by updating frontend tests to address these changes.
Fixes : #17138
2021-03-04 17:06:02 -08:00
Riken Shah
d12257e2c1
puppeteer_test: Add missing await checking compose content.
...
assert_compose_box_content should always be called with await.
2021-03-04 09:41:49 -08:00
Riken Shah
b23cd2b7d4
puppeteer_test: Skip tests that require file upload for Firefox.
...
Right now Firefox does not support file upload with puppeteer.
2021-03-04 09:41:24 -08:00
Riken Shah
dc5095bad9
puppeteer_test: Add waitForNavigation when reloading.
...
This commit ensures that it waits until the
page is reloaded which avoids uncertain
flake.
2021-03-04 09:40:14 -08:00
Riken Shah
de96aeb822
puppeteer_test: Fix page.url() for Firefox.
...
This commit works around an issue with Puppeteer tests on Firefox
where `page.url()` does not show the URL fragment, by adding a
temporary function that solves the issue.
2021-03-04 09:40:14 -08:00
Riken Shah
a6c1f02df0
puppeteer_test: Add is_firefox option to enable/disable some tests.
...
This commit introduces the `is_firefox`
option in CommonUtils to identify if a browser
is Firefox or not.
This helps us to avoid calling some tests
that is yet not compatible with Firefox.
2021-03-03 22:04:16 -08:00
Riken Shah
6676aa2f90
puppeteer_test: Change browser default viewport to allow Firefox.
...
When we run puppeteer with Firefox,
the `--window-size` option does not work,
which makes the bottom part of
the page cut off.
This commit fixes this issue
by setting the screen default viewport
to the maximum size of the window.
2021-03-03 22:01:36 -08:00
Steve Howell
b1a871f2e0
node tests: Avoid reset_module for recent_topics.
2021-03-03 07:08:51 -05:00
Anders Kaseorg
cce3257f2c
zjsunit: Remove babel-plugin-lazy-require.
...
There are no more require() calls in tested modules.
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-03-02 17:06:35 -08:00
Anders Kaseorg
099e8fb00e
js: Convert static/js/settings_profile_fields.js to ES6 module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-03-02 17:06:35 -08:00
Anders Kaseorg
7ec8b8980f
js: Convert static/js/dropdown_list_widget.js to ES6 module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-03-02 17:06:35 -08:00
Anders Kaseorg
9e613b1487
js: Convert static/js/message_events.js to ES6 module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-03-02 17:06:35 -08:00
Anders Kaseorg
d8c793f791
js: Convert static/js/composebox_typeahead.js to ES6 module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-03-02 17:06:35 -08:00
Anders Kaseorg
5cc1f8d289
js: Convert static/js/ui.js to ES6 module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-03-02 17:06:35 -08:00
Anders Kaseorg
8dbaf2d680
js: Convert static/js/subs.js to ES6 module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-03-02 17:06:35 -08:00
Anders Kaseorg
0e90f3be6d
js: Convert static/js/compose_actions.js to ES6 module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-03-02 17:06:35 -08:00
Anders Kaseorg
e74598da17
js: Convert static/js/narrow.js to ES6 module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-03-02 17:06:35 -08:00
Anders Kaseorg
7a67c06581
js: Convert static/js/message_list.js to ES6 module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-03-02 17:06:35 -08:00
Anders Kaseorg
68872f44f6
js: Convert static/js/widgetize.js to ES6 module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-03-02 17:06:35 -08:00
Anders Kaseorg
3e8ddc229b
js: Convert static/js/stream_list.js to ES6 module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-03-02 17:06:35 -08:00
Anders Kaseorg
727208b84c
js: Convert static/js/unread.js to ES6 module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-03-02 17:06:35 -08:00
Anders Kaseorg
9997e13032
js: Convert static/js/unread_ops.js to ES6 module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-03-02 17:06:35 -08:00
Anders Kaseorg
7ec3fc38fa
js: Convert static/js/input_pill.js to ES6 module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-03-02 17:06:35 -08:00
Anders Kaseorg
ac4e293da5
settings_profile_fields: Use named export from sortablejs.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-03-02 17:06:35 -08:00
Anders Kaseorg
19e4328a7b
node_tests: Don’t use this in __esModule mock.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-03-02 17:06:35 -08:00
Anders Kaseorg
4a2f937732
narrow: Add setter for narrow_title.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-03-02 17:06:35 -08:00
Anders Kaseorg
1ec97070e8
node_tests: Move more set_global mocks before zrequire calls.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-03-02 17:06:35 -08:00
Anders Kaseorg
79ac5c25b5
zulip_test: Re-export internal functions used by Puppeteer tests.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-03-02 17:06:35 -08:00
sahil839
b53c773987
events: Remove email field from update subscription events.
...
This commit removes email field from update subscription
events, as email field is of no use in this case.
2021-03-01 14:52:06 -08:00
Anders Kaseorg
2a2373307f
node_tests: Remove unused rewiremocks.
...
Found by running the tests after
sed -i 's/\.with(/.toBeUsed().with(/g' frontend_tests/node_tests/*.js
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-02-28 14:23:00 -08:00
Anders Kaseorg
4b1b1950b2
node_tests: Fix ineffective rewiremocks installed after import.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-02-28 14:23:00 -08:00
Anders Kaseorg
d8ad63126d
js: Convert static/js/billing/helpers.js to ES6 module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-02-28 14:23:00 -08:00
Anders Kaseorg
2a49ce1b6c
js: Convert static/js/search_pill_widget.js to ES6 module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-02-28 14:23:00 -08:00
Anders Kaseorg
1a8422b152
js: Convert static/js/recent_topics.js to ES6 module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-02-28 14:23:00 -08:00
Anders Kaseorg
934d4e4e10
js: Convert static/js/panels.js to ES6 module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-02-28 14:23:00 -08:00
Anders Kaseorg
dc95f06b62
js: Convert static/js/compose_ui.js to ES6 module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-02-28 14:23:00 -08:00
Anders Kaseorg
8191915e57
js: Convert static/js/emoji_picker.js to ES6 module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-02-28 14:23:00 -08:00
Anders Kaseorg
b9e1d320e8
js: Convert static/js/typing_events.js to ES6 module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-02-28 14:23:00 -08:00
Anders Kaseorg
e382389797
js: Convert static/js/reactions.js to ES6 module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-02-28 14:23:00 -08:00
Anders Kaseorg
a0caabe6c7
js: Convert static/js/bot_data.js to ES6 module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-02-28 14:23:00 -08:00
Anders Kaseorg
5438a04b84
js: Convert static/js/message_view_header.js to ES6 module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-02-28 14:23:00 -08:00
Anders Kaseorg
d36c6f23f6
js: Convert static/js/admin.js to ES6 module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-02-28 14:23:00 -08:00
Anders Kaseorg
972a52ca99
js: Convert static/js/settings.js to ES6 module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-02-28 14:23:00 -08:00
Anders Kaseorg
65840a2001
js: Convert static/js/settings_user_groups.js to ES6 module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-02-28 14:23:00 -08:00
Anders Kaseorg
b58b1f080e
js: Convert static/js/settings_invites.js to ES6 module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-02-28 14:23:00 -08:00