This commit updates the topic URL in the message header topic menu
popover, introduced in feedb6ea2d to a
permalink having a `with` operator attached to it.
Similar to drafts, identify when a scheduled message will be sent to
the logged-in user. This allows the UI to show 'You' as the header for
self-scheduled messages, improving the user experience.
Adding "text-align: start" css to banner-label element makes
sure that the banner text is not aligned as per the alignment
of parent element, as we require left alignment of text for
all the banners. Only navbar banners have text align in center
but that is handled by adjusting the flex layout of the
banner-content, parent of banner-label, element.
We use the same "v" key for opening and closing the
lightbox overlay.
We already have code to open and close the lightbox
overlay in hotkey.ts.
Having another keydown handler for closing the overlay
resulted in a bug where the overlay was just not being
opened because the second handler was immediately called
to close the overlay was immediately called after the first.
Fixes#35868.
URL hash from old url is lost using this JS method for redirecting,
preserved by extracting the hash and appending it to the new URL.
In case user clicks on the new url link, we do this by updating that url to
include the hash, and using that URL for the automated redirect as well.
Earlier, slow-send-spinner was working correctly for message with
messagebox-includes-sender. Any subsequent messages with
slow-send-spinner would result in broken animated because of rules
not applying properly.
This commit fixes this behaviour by applying the rules for all
messagebox-content and fixing the animation.
Earlier, message notifications for same key would not get grouped
together because of the old notification_object close event listener
firing up when not supposed to.
This commit fixes this behaviour by checking the notification object
instance is the same as the currently displayed notification object
from notice memory when closing it.
Co-authored-by: prakhar1144 <prakhar@zulip.com>
I noticed that when you are in a group dm narrow
and open drafts, the overlay-message-row class
is inside different containers, and the nth last
child check does not apply for that case, which is
why the test failed.
More generally, last-child is just not a good selector for robust
testing.
Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
Links become unclickable if the following is true:
1. Composebox is open
2. You have selected some text
Currently doing this will prevent the default click behavior
which is a big bug and can get quite annoying.
We now switch to a more robust check which only prevents the
click behavior if some drag evidence is present, determined with
`mouse_drag.is_drag`
Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
As per the type definition of `NarrowTerm`,
the operand should be a string.
This bug caused exceptions each time a topic was
clicked in the left sidebar.
Previously, tooltip templates were identified using the
group's name in their `id` attributes.
This change uses the group's ID instead, which is more reliable.
Previously, tooltip templates were identified using the
stream's name in their `id` attributes.
This commit changes the tooltip IDs to use the stream's ID instead,
rather than its name, to ensure uniqueness and avoid potential conflicts.
An error was raised where we tried to live update the folder name
in folder dropdown even when there was no dropdown visible
to the non-admin user in settings page. This was because
"There are no channel folders configured in this organization."
text was shown even when a folder was recently created in the
realm as we did not live update the visibility of dropdown on
creating or archiving a folder.
This commit fixes the bug by live-updating the visibility
of folder dropdown when creating or archiving a folder.
Previously, the API key was shown using a variable-width font, making
characters harder to distinguish. This change applies a monospace font to
improve readability and visual consistency.
Fixes#35189.
Co-authored-by: rxkshit04 <rakshitatwork@gmail.com>
Co-authored-by: cpu-ram <petr.stepanenko@gmail.com>
