paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity
22,625 Commits 30 Branches 160 Tags
38e97089fc549d7f89229fc725e4205cc1bcc0e9
Commit Graph

105 Commits

Author SHA1 Message Date
Tim Abbott
a23378a304 check_short_string: Verify string before checking length. 
While the previous implementation was correct, this should give better
error messages.
 2017-11-10 16:37:43 -08:00
Steve Howell
5be13fb066 Add cachify decorator. 2017-11-07 10:36:02 -08:00
rht
c7fa1d4146 zerver/tests: Remove inheritance from object. 2017-11-06 08:53:48 -08:00
neiljp (Neil Pilgrim)
42f5eea61f mypy: Improve typing of request.pyi (REQ). 
This expands request.pyi to type-check the arguments passed into REQ.

Tweaked by tabbott to fix the report.py annotations.
 2017-11-04 20:26:03 -07:00
neiljp (Neil Pilgrim)
055dff9038 mypy: Clarify parameter types in test_decorators.py. 2017-11-04 19:47:45 -07:00
Greg Price
68b0a419ec decorator: Cut a bunch of dead imports of two view decorators. 
Saw these when grepping for these two decorators; they're actually
more numerous than the surviving use sites are.  Cut out the noise.
 2017-11-04 19:27:00 -07:00
Tim Abbott
5467296f60 decorators: Use human_users_only more aggressively. 2017-10-27 15:16:13 -07:00
Tim Abbott
1cd017288d views: Fix imports of REQ/has_request_variables from the wrong place. 
These were never in zerver/decorator.py, and so it makes sense to
import them zerver/lib/request.py, mostly for ease of finding things.
 2017-10-27 15:07:31 -07:00
Alena Volkova
0e653d198d test_decorators: Replace the json/tutorial_status endpoint in tests. 
This endpoint is about to become an API-style route and have the legacy
decorator removed from its view. The json/fetch_api_key endpoint will be
used in tests instead of it.
 2017-10-09 15:13:33 -07:00
derAnfaenger
747c283180 lint: Replace pk with id where they are equivalent. 2017-10-06 12:52:12 -07:00
Tim Abbott
7581e0e1c5 settings: Remove remaining references to REALMS_HAVE_SUBDOMAINS. 2017-10-02 16:43:54 -07:00
Tim Abbott
edc10e8f51 test_decorators: de-inline REALMS_HAVE_SUBDOMAINS with statements. 
This will significantly shrink the diff when we toggle
REALMS_HAVE_SUBDOMAINS soon.
 2017-10-02 13:49:53 -07:00
Tim Abbott
5a27a4cf1c decorator: Improve wrong-subdomain logging output. 
Often, it's helpful to see both values in errors.
 2017-10-02 13:31:20 -07:00
Tim Abbott
6327f30c76 test_decorators: Remove test_login_deactivated_realm. 
This test was a duplicate of test_login_deactivated in LoginTest.
 2017-10-02 11:42:15 -07:00
invinciblycool
5475c5cedb tests: Replace test_user_agent_parsing with a normal test. 
Previously, this was its own separate test script; now it's a normal
part of the test suite.

Tweaked by tabbott to use a proper test method.

Fixes #6327.
 2017-09-16 03:56:18 -07:00
Tim Abbott
4a22316d90 test_decorator: Add explicit subdomains in tests. 2017-08-28 22:51:57 -07:00
Tim Abbott
4229faf36e tests: Remove old six.PY2 code paths. 2017-08-25 11:05:16 -07:00
Tim Abbott
7d08ff69f0 tests: Remove most references to get_api_key. 
This test helper doesn't really have value.
 2017-08-24 23:30:46 -07:00
Tim Abbott
5206dad373 decorator: Fix is_browser_view handling of e.g. mobile apps. 
We may end up with some endpoints that could be the browser or the
mobile apps, and we want the right default to happen here.
 2017-08-24 16:26:57 -07:00
Tim Abbott
7ffc107061 decorator: Rename is_json_view to is_browser_view. 
This improves clarity, now that we're planning to start logging in the
login/registration pages, which aren't browser views.
 2017-08-24 16:25:08 -07:00
Tim Abbott
58edf75962 api: Allow incoming webhook bots to use the send_message API. 2017-08-22 10:06:34 -07:00
Tim Abbott
5a63ea0170 decorator: Extract validate_account_and_subdomain and deduplicate. 
This fixes the significant duplication of code between the
authenticate_log_and_execute_json code path and the `validate_api_key`
code path.

These's till a bit of duplication, in the form of `process_client` and
`request._email` interactions, but it is very minor at this point.
 2017-08-15 10:54:23 -07:00
Tim Abbott
3c37795675 decorator: Add localhost/Tornado hack to access_user_by_api_key. 
This should make it possible to share that code with other code paths.
 2017-08-15 10:54:23 -07:00
Tim Abbott
fc0144f6e4 test_decorators: Annotate fake Request as HttpRequest. 2017-08-05 17:53:18 -07:00
Tim Abbott
1e5aee054b settings: Migrate main settings-change code to API. 
This was one of the few major remaining endpoints that were still on
the old-style legacy API.
 2017-07-31 13:08:06 -07:00
Tim Abbott
9bf02fb913 custom_profile: Prevent bot users from accessing endpoint. 2017-07-31 13:08:06 -07:00
Tim Abbott
93261e14b7 hotspots: Prevent bot users from accessing endpoint. 2017-07-31 13:08:06 -07:00
Anna Liao
6a3c8ca2c5 push_notifications: Add human users only decorator. 
This is part of #4517.
 2017-07-31 13:08:06 -07:00
Eeshan Garg
6fe3748826 decorator: Remove redundant tests for api_key_only_webhook_view. 
We do not need to test the exception message being logged in every
test case where an exception is raised by a webhook function.
Testing it once should be enough; this makes the tests less
verbose.
 2017-07-20 10:30:03 -07:00
Eeshan Garg
a24ea56c53 decorator: Handle invalid JSON in api_key_only_webhook_view. 
Exception logging within api_key_only_webhook_view fails when
ValueError is raised if the request.body passed to ujson.loads
isn't valid JSON. In this case, we now just convert the payload
to a string and log that. This allows us to inspect JSON payloads
that aren't being decoded properly.
 2017-07-19 10:42:35 -07:00
Umair Khan
638b32542d auth: Don't show deactivation notice to mirror dummies. 2017-07-05 23:50:53 -07:00
Yago González
2f4091b38d api: Fix caps in JSON validation error message. 2017-06-27 08:33:56 -04:00
Umair Khan
4f223c19d8 sign-in: Show proper error for deactivated user. 
Show a clear error message when a user tries to sign in with
a deactivated account.

Fixes #4757
 2017-06-20 11:38:58 -04:00
vaibhav
42af09663d validators: Add check_url validator. 
This just uses Django's existing validator, and reformats its
interface to work with has_request_variables.
 2017-06-15 15:03:26 -07:00
Vishnu Ks
bb98e35aa0 Replace othello@zulip.com with example_email('othello'). 2017-05-24 19:37:36 -07:00
Vishnu Ks
c4db3b7d1c Replace cordelia@zulip.com with example_email('cordelia'). 2017-05-24 19:37:36 -07:00
Vishnu Ks
5230eaef1c Replace hamlet@zulip.com with example_email('hamlet'). 2017-05-24 19:37:36 -07:00
Tim Abbott
6aaca44e17 tests: Fix str/Text mypy issues in various tests. 2017-05-24 15:19:38 -07:00
Andrew Archer
6c3f89af1c tests: Remove get_user_profile_by_email from numerous tests. 2017-05-24 15:19:20 -07:00
Steve Howell
6bc8424c71 Use self.example_user() in more places. 
This fixes most cases where we were assigning a user to
the var email and then calling get_user_profile_by_email with
that var.

(This was fixed mostly with a script.)
 2017-05-08 11:57:38 -07:00
Aditya Bansal
7f5f4a511a pep8: Add compliance with rule E261 to test_decorators.py. 2017-05-07 23:21:50 -07:00
Eeshan Garg
e87e246fcb zerver/decorator: Set request.client in api_key_only_webhook_view. 
Previously, api_key_only_webhook_view passed 3 positional arguments
(request, user_profile, and client) into a function. However, most
of our other auth decorators only pass 2 positional arguments. For
the sake of consistency, we now make api_key_only_webhook_view set
request.client and pass only request and user_profile as positional
arguments.
 2017-05-01 23:44:07 -07:00
Maxim Averin
73a1dd63d5 analytics: Refactor legacy 'zulip_internal' decorator. 
Rename 'zulip_internal' decorator to 'require_server_admin', add
documentation for 'server_admin', explaining how to give permission
for ./activity page.

Fixes: #1463.
 2017-04-22 11:42:02 -07:00
Tim Abbott
cbc731963f decorator: Add support for Django internal_notify_view. 2017-04-18 09:59:07 -07:00
Tim Abbott
0c8575e2dc user_settings: Disable bot access to several endpoints. 
These settings have no effect on bots, so this change is mostly about
just avoiding confusion.
 2017-04-16 13:14:59 -07:00
Rishi Gupta
e14c940ecc decorator: Add human_users_only decorator. 
Applies it to presence.update_active_status_backend as an example of usage.
 2017-04-16 12:51:23 -07:00
Tim Abbott
118f2db22d validators: Add a test_dict_only validator that bans other arguments. 
This is primarily intended to be useful in EventsRegisterTest.
 2017-03-26 13:10:54 -07:00
Tim Abbott
d1760a1bb9 validators: Add check_float validator. 2017-03-23 21:23:41 -07:00
Tim Abbott
ac20872f9d request: Fix unnecessary translation tag for assertion. 2017-03-09 00:38:14 -08:00
Tim Abbott
8bdbcbc371 lint: Fix unnecessarily translated test file strings. 
Our linter for translation strings shouldn't check test files, since
then we'll end up translating non-user-facing strings.

So we fix that, and actually add the opposite lint rule.
 2017-03-09 00:37:44 -08:00