Migrate the demo organization warning that's shown on all the tabs
for organization settings to use the shared banner code.
Updates links in the current warning to be buttons in the banner,
and matches the navbar alert banner for demo organizations.
Fixes#34447.
Since we're no longer adding links to this banner, we don't need
to use "$t_html" when generating the label for the demo organization
warning banner.
Follow-up to #34518.
This follows our usual backporting scheme, occurring e.g.
in #31468. We make the migration depend on the last migration in 10.x,
and create a merge migration to avoid having multiple leafs.
It doesn't make sense that there would be no compose pill user ids
if there were compose pill emails, and there needs to be permission
to send a direct message or the message won't successfully send.
This was working before because `user_ids_string` ended up empty
in `validate_private_message`, which incorrectly returned true
for `check_dm_permissions_and_get_error_string`.
This adds a new API endpoint that enables users to report messages for
review by admins or moderators. Reports will be sent to the
`moderate_request_channel`, so it must be configured for this feature to
be enabled.
Fixes part of #20047.
Co-authored-by: Adam Sah <140002+asah@users.noreply.github.com>
In #34510 we fixed the underlying bug in the ldap integration, which
would cause users to end up with their system group memberships not
matching their .role value. However, users who may already be in that
state still need to be fixed through a migration. We implement that
here.
There are two things we fix here:
1. Group memberships. The user should have a direct group membership
for the specific system group implied by their .role.
2. We want to also add the missing RealmAuditLog entry.
Earlier, permission in edit panel of channel settings was not the
same as that of org permission, specifically for public channel
option.
This commit fixes that by updating the privacy option state.
Fixes:zulip#34526.
Currently when a deactivated user tries to access the change email link
(generated when their account still active), a JSON error message will
be shown.
This adds a new portico error page for user deactivated errors. Now,
`confirm_email_change` renders a portico error page when the user trying
to change their email is deactivated.
Fixes#20227.
Work towards #34244
This is the only call to `peer_data.is_subscriber_subset`, so after
this commit all calls to that function work with our new model for
partial subscriber data.
Omit<…, "undefined"> removes the "undefined" key from an object. The
intention was clearly Exclude<…, undefined> which removes undefined
from a union, or NonNullable<…> which removes both undefined and null.
However, it’s simpler here to provide the expected type directly.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
Changes done here are -
- Previously the pill input, "Add" button and tooltip shown
when user did not have permission were not live updated when
updating can_add_subscribers_group and can_subscribe_group
stream level settings or can_add_subscribers_group realm
level setting. This commit fixes that.
- Also, when the UI was live updated to give user permission
to subscribe others, "Add" button was enabled even when
input was empty. This is also fixed in this commit.
This commit refactors code to live update UI for a couple of
group settings by setting the live update functions for those
settings in realm_settings object.
Work towards #34244.
Note that this doesn't show the right counts when the counts appear, because
yet. We can double check functionality after that change is complete.
