Commit Graph

184 Commits

Author SHA1 Message Date
Evy Kassirer
44b87c72dc stream_edit: Fetch subscribers before showing subscriber tab.
Work towards #34244.

Now that we're supporting partial subscriber data, we might need
to fetch the full list of subscribers when opening the subscribers
tab of the edit channel modal.

This commit handles a slow load with a loading spinner while we fetch
the data, and also makes sure to ignore the data if it's received after
it stops being relevant (in case the user has another stream's data open).
2025-05-14 15:00:45 -07:00
Sahil Batra
abdad3d485 settings-ui: Align tab toggler correctly in streams and groups UI.
This commit updates the left margin for the tab toggler in
streams and groups UI to be equal to the margin for the content
below so that they align correctly.
2025-05-14 13:24:55 -07:00
Evy Kassirer
d82bd57cef two_pane_settings: Calculate body height from resize instead of fiddly CSS.
Having a set height is necessary for simplebar to work, and the height
will change depending on whether the header is one or two lines.
2025-05-13 12:06:47 -07:00
Evy Kassirer
a5c77cc017 settings: Move settings page CSS out of subscriptions.css. 2025-05-13 12:06:47 -07:00
Evy Kassirer
4f7c65d255 two_pane_settings: Clean up padding and width on creation window footer.
This changes the vertical padding to be the same top and bottom, instead
of 9px top and 15px bottom, and updates the width to properly account
for the left/right padding.

Note: This footer is currently only used for stream/usergroup creation.
2025-05-13 12:06:47 -07:00
Evy Kassirer
1778bea8fa two_pane_settings: Remove unused text-align on list-toggler-container.
This seems only relevant for the text in the `.tab-switcher .ind-tab`
which already have `text-align: center`.
2025-05-13 12:06:47 -07:00
Evy Kassirer
9ab4954fe8 two_pane_settings: Use transform with transition instead of left.
This is more performant.
2025-05-13 12:06:47 -07:00
Evy Kassirer
3edbd5983c two_pane_settings: Clean up top border for body on narrow screens.
It seems like the only impact of removing `top` here is the bottom
border of the header appears, but we can just remove that directly.

`border-top: none` doesn't seem like it was doing anything here
(the element had no border).
2025-05-13 12:06:47 -07:00
Evy Kassirer
ce78543fcd two_pane_settings: Remove redundant height for narrow screens.
This is already set on `.left` and `.right` for wide screens
and doesn't change on narrow screens.
2025-05-13 12:06:47 -07:00
Maneesh Shukla
46cd38d1b0 settings: Redesign buttons in channel and group settings.
Fixes: #34253.
2025-05-06 13:34:59 -07:00
Karl Stolley
3671a6a39c decorated_channels: Rename privacy-icon class. 2025-04-22 11:26:12 -07:00
Maneesh Shukla
94bbfaebe4 settings: Make stream and group settings thead sticky.
Co-authored-by: Karl Stolley <karl@zulip.com>
2025-04-16 09:24:37 -07:00
evykassirer
8d57bf30ac settings: Split CSS for two-pane-overlay and settings.
No changes, just shuffling things around for ease of reading
future commits.
2025-04-11 10:27:25 -07:00
evykassirer
3be4951e5e subscriptions: Move 40% width to just the left style block.
This is overwritten to ~60% in the .right style block and
shouldn't be in the shared style block.
2025-04-11 10:27:25 -07:00
evykassirer
e84c318e10 settings: Move stream_sorter_toggle CSS to subscriptions stylesheet.
It's only used for subscriptions so it makes more sense for it to
live there.
2025-04-11 10:27:25 -07:00
evykassirer
3539142479 settings: Remove margin for subheader title.
The margin doesn't scale with font size, so it looks
extra weird at small font sizes, and also the text
is already being centered with flex so we don't need
margin.
2025-04-11 10:27:25 -07:00
evykassirer
6b0dd9e063 settings: Move subheader CSS out of main CSS block.
In a future commit in (#34125) we'll add a classname for the
subheader and use that to scope these rules.

This commit has no changes in CSS rules. It only moves them around.
2025-04-11 10:27:25 -07:00
evykassirer
a09dab5eaf settings: Calculate height of create modal through javascript.
We need this height to be flexible based on if the subheader has
overflowed into two rows or not, and our method of doing this
(with existing examples in the buddy list and stream list) is to
calculate what the height should be when a window is loaded or
resized.
2025-04-10 10:01:57 -07:00
Sayam Samal
616a957842 settings: Improve subsection header styling.
This commit makes all the subsection header as flex boxes, and improves
it's CSS styling.
2025-04-07 18:22:16 -07:00
evykassirer
a16bc0e5b1 settings: Add a generic classname for two pane overlays. 2025-04-07 18:18:47 -07:00
evykassirer
8ee4554499 settings: Replace some two pane plus sign classnames with a generic one. 2025-04-07 18:18:47 -07:00
evykassirer
1abd3332a6 settings: Replace two pane header classnames with a generic one. 2025-04-07 18:18:47 -07:00
evykassirer
23b8ac0eab settings: Replace two pane container classnames with a generic one. 2025-04-07 18:18:47 -07:00
evykassirer
781c4448fd subscriptions: Combine same media queries. 2025-04-07 18:18:47 -07:00
Shubham Padia
e0dda789ee streams: Open typeahead on click on adding subscribers.
We also added `flex-grow: 1` to the add group members and add stream
subscribers input. Without that, the typeahead won't open on click,
since there was no space occupied by the input to click on.
2025-04-07 16:26:30 -07:00
Shubham Padia
c4b30dd176 user_groups: Remove Add all users button from group creation screen.
Partially fixes #33127.
2025-04-07 16:26:30 -07:00
Shubham Padia
2314f20587 user_groups: Add subtitle when adding subscribers to new group.
Also modify the placeholder text.
2025-04-07 16:26:30 -07:00
Shubham Padia
b2108404e7 channels: Remove Add all users button from channel creation screen. 2025-04-07 16:26:30 -07:00
Shubham Padia
81ba1bcb61 channels: Add subtitle when adding subscribers to new channel.
Also modify the placeholder text.
2025-04-07 16:26:30 -07:00
Karl Stolley
30752a0011 dark_theme: Set color variables for overlays, non-empty indicators. 2025-04-04 14:04:52 -07:00
Karl Stolley
46d4f32473 dark_theme: Set color variables for plus buttons. 2025-04-04 14:04:52 -07:00
Sayam Samal
91549cfba0 settings: Update remove/unsubscribe buttons to action button component.
This commit updates the remove and unsubscribe buttons in channel
settings and user group settings to use the action button component.
2025-04-04 12:26:36 -07:00
Evy Kassirer
8adb46867b stream_settings: Move muted channels help text to below header. 2025-03-27 11:55:04 -07:00
Aman Agrawal
5ad100afef channel_settings: Fix channel name incorrect hidden.
`max-width` was not working correctly here. Removing it gets
us in good state.
2025-03-25 13:26:16 -07:00
Aman Agrawal
c7364fafe5 subscriptions: Fix wrapping of channel name above 18px font size.
We limit the width of the channel title and show ellipsis for
overflowing channel name.
2025-03-24 12:24:48 -07:00
Karl Stolley
7be9ac9883 stream_settings: Better handle word breaks. 2025-03-19 11:35:11 -07:00
harshbansal8705
8402323cb5 stream_settings: Improve handling of long stream titles in UI.
This commit makes the following changes to improve the display of long
stream titles in the stream creation and user group settings UI:

- Uses `display: -webkit-box` and `line-clamp` properties to show the
title upto two lines, and end with `...` if it exceeds.
- Updates icon `font-size` to align with text size.
- Updates `margin` and `line-height` to make it visually better.
2025-03-19 11:35:11 -07:00
whilstsomebody
24ada051dd Subscriptions: Fix the left offset of the group name.
This commit fixes a bug reported on CZO where the group
name appears offset to the left by a few pixels compared
to the description and other settings.

See CZO:
<https://chat.zulip.org/#narrow/channel/9-issues/topic/name.20of.20user.20group.20is.20misaligned>
2025-03-17 14:08:12 -07:00
Sahil Batra
a1a3ce8479 settings: Fix showing tooltip when permissions panel input is disabled.
Since the input-group covered all the available space, tooltip looked
like it is separated from the checkbox label. This commit fixes the
width of input-group to be just wide enough to contain the content
when the setting is disabled so that tooltip is positioned correctly.
2025-03-17 10:24:20 -07:00
evykassirer
f3377e90a4 subscriptions: Use only one container for the two-row header styles. 2025-03-14 16:35:05 -07:00
evykassirer
02edb62d33 settings: Collapse buttons to two rows on narrow screens with one panel.
Previously we collapsed buttons when the two-panel view was narrow enough
that the buttons started wrapping, but this case for one-panel view with
wrapping buttons was missed.
2025-03-14 16:35:05 -07:00
evykassirer
6f9ad9e74b settings: Wrap save/discard buttons as a unit on narrow screens. 2025-03-14 16:35:05 -07:00
evykassirer
dfe3769d97 settings: Increase size of right pane of subscriptions/usergroups modal.
This simplifies some @container queries and also ensures there's enough
space at larger font-sizes for the save/discard buttons to appear
beside setting section headings without overflowing onto the next line.

Now the left pane is always 40% and the right pane is always 60%.

One effect of this is that the top left buttons in the stream settings
overlay are now always in two rows at 16px (like they already always
were at 20px).
2025-03-14 16:35:05 -07:00
evykassirer
88a5630960 subscriptions: Scale tab width with font size. 2025-03-14 16:35:05 -07:00
Aman Agrawal
f53fc1b507 user_group_settings: Use icon with 2 users for editing group info. 2025-03-14 11:07:33 -07:00
apoorvapendse
be6cc5e56e user_groups: Show group name for smaller widths.
https://chat.zulip.org/#narrow/channel/9-issues/topic/.F0.9F.8E.AFdeactivated.20group.20indicator.20disappears/near/2113197
2025-03-10 12:45:49 -07:00
apoorvapendse
27ac91a8c8 user_groups: Add deactivated icon on top title.
https://chat.zulip.org/#narrow/channel/9-issues/topic/.F0.9F.8E.AFdeactivated.20group.20indicator.20disappears/near/2112723
2025-03-10 12:45:49 -07:00
Harsh
eb013580a5 user_groups: Add banner for settings for a deactivated group.
This commit adds a banner at the top of the group settings panel, to
make it super clear when a group is deactivated.

Fixes: #33803.
2025-03-10 12:42:44 -07:00
evykassirer
0fe2afe8b3 settings: Standardize right panel button height for streams/usergroups. 2025-03-10 09:26:50 -07:00
sanchi-t
1aef79078c stream_settings: Display archived channels.
By default, archived channels will be hidden.
2025-03-07 18:08:41 -08:00