Due to the atomic(savepoint=False) here, an LDAP sync exception while
syncing a single user breaks the whole sync_ldap_user_data transaction,
preventing it from successfully syncing other users.
Fixes a regression introduced in
1eecbad381Closes#35291.
The regex we were using for file includes was searching for the syntax
at the start of a line but the file includes can be followed by a `- `
as part of a list item, due to which 15 occurences of includes were not
being converted. This commit fixes that.
Closes#35280.
When importing from other apps, we want to generate initial channel
messages. We don't have the usual Zulip-style range of channels, so we
just settle on sending all these messages to a single channel, chosen
following the same criteria as already implemented in #35339.
It's messy to sometimes do `realm.ZULIP_..._CHANNEL_NAME` and sometimes
`Realm.ZULIP_..._CHANNEL_NAME`. Let's be consistent and access those as
a class attr `Realm.ZULIP_..._CHANNEL_NAME`.
To maintain API compatibility during and after the migration to direct
message groups for 1:1 and self messages, update the analytics count
query to treat DM groups of size 2 or less as private messages.
Previously, pressing Esc while the "Filter topics" input was empty would
de-focus the input. Pressing Esc again would trigger the
"BACK TO CHANNEL" action, hiding the zoomed topic. However, this
behavior was broken as the input was not triggering any blur event,
making Esc a noop.
This commit restores the expected behavior by ensuring the blur event is
properly triggered, allowing Esc to function as intended.
The original sentence is a bit unclear it's talking about mapping to the
same user account *across time* - rather than a situation where a value
might map to multiple accounts at the same time (which should be
impossible for DNs).
Fixes#35150
Fixed by adding more fallback options.
Reproduced by clicking on left sidebar or inbox channel popover
triggers at the bottom right corner.
The result message shown when adding members to a stream
previously listed the name of every member being added,
which could be noisy for large groups.
This commit updates stream_subscription_request_result.hbs to
conditionally display clearer, more concise messages based
on the number of subscribed and already subscribed users.
This improves readability and user experience when handling
large subscription actions.
Fixes part of #34347
Co-authored-by: Rajeev Tapadia <108951750+rajeevtapadia@users.noreply.github.com>
Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
Adds a loading spinner for both `Unsubscribe` and `Remove`
buttons in channel and group settings.
Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
The data conversion logic for exports from other apps will try to set
these announcement channels based on presence of channels with an
appropriate default name - however those sometimes do not exist.
Then it falls on the import process to choose a good default value. That
default should be the channel with the most subscribers.
This requires a tweak to the send_zulip_update_announcements_to_realm
code to respect the "Starting tomorrow, users in your organization will
receive updated" behavior promised to admins in the initial DMs.
Closes#34984.
For Slack, Mattermost and RocketChat, set the default announcement
channels if the sane default channel is available in the import.
The next commit will add a mechanism to choose an alternative default if
the expected channel name is not present.
Addresses the major part of #34984.
Some installations will change `dn` when a user marries, and also for
Active Directory and various other LDAP providers I've checked,
there's often a better value to use.
Previously, due to a logic issue, the clear status icon did not
appear when there is only selected emoji in the status—it appeared
only when status text was present.
This commit fixes the bug and now the clear status icon disappears
only when neither status text nor a selected emoji is present.
Fixes: #35176
This commit adds maxlength attribute with value set to 100 to
name inputs in both "Manage user" and "Manage bot" modals since
we allow maximum 100 characters for both user and bot names.
The "maxlength" attribute for "Full name" input in "Profile"
settings panel was incorrectly set to 60, when we allow
maximum 100 characters. This commit fixes that.
