paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 15:03:34 +00:00
Code Issues Packages Projects Releases Wiki Activity
1,409 Commits 30 Branches 160 Tags
51a39fdb0aa667993f97aba53a25f46e92b3f43e
Commit Graph

510 Commits

Author SHA1 Message Date
Zev Benjamin
51a39fdb0a Remove unused variable 
(imported from commit 5a2a100aa3d9a577cde2517be3d9bacc2147fa7e)
 2012-10-25 18:11:23 -04:00
Zev Benjamin
1c904e8607 Only start get_updates call after we've gotten all old messages 
(imported from commit 8af46008a3abcdacb59e6223f38742a94a87b125)
 2012-10-25 18:11:23 -04:00
Zev Benjamin
a9583f6889 Fix get_updates missing messages between calls 
(imported from commit 2b84df2a35a9a006b8548904ebf145a351a2e92b)
 2012-10-25 18:11:23 -04:00
Waseem Daher
98d7116ee8 Delete some dead code in signup workflow. 
(imported from commit d07fffd4c0efdaaf4a233c1dbc9d09bc5ec03ad3)
 2012-10-25 16:59:37 -04:00
Zev Benjamin
a798e14d86 Remove more unused code related to get_updates not returning old messages 
(imported from commit d2cc795634c46d8a595ed15c093cfbfc113e6d10)
 2012-10-25 15:48:35 -04:00
Zev Benjamin
47eeae0d36 Restore the "load more messages" button disappearing when there are no more 
(imported from commit 4f46d49c88d9d0dadefe3e770868b6844dc80d64)
 2012-10-25 15:45:14 -04:00
Zev Benjamin
451a041919 Remove the ability to fetch old messages via get_updates 
Clients should use get_old_messages, instead.

(imported from commit 67847ef67d8ad4bf4af3f6082f85f0c76a41944c)
 2012-10-25 15:31:27 -04:00
Keegan McAllister
f8540dcdae Wrap some other extremely long lines 
(imported from commit e7d55f318c8865ca953bf4520d1b07f7e84a4aeb)
 2012-10-25 15:22:18 -04:00
Zev Benjamin
c047502840 Use get_old_messages in client instead of get_updates for loading initial messages 
(imported from commit 169b3720c1fa10606f2351039cac9655bb5165b4)
 2012-10-25 12:10:44 -04:00
Waseem Daher
22a32c09c4 Add a shortcut to pull up the shortcuts dialog. 
(imported from commit 0d6d3ba78a06f0eb1ecba8e6a571b79709980cef)
 2012-10-24 18:31:44 -04:00
Keegan McAllister
f3f9fb545d Narrow by recipient when the user presses 'S' on a huddle 
(imported from commit 7e7c3d27b0824a60f7e8379c282ec05704d842f6)
 2012-10-23 23:04:42 -04:00
Keegan McAllister
899e6d1042 Resize the compose box on show 
It doesn't work to do this immediately after we clear the contents, for some
reason.

(imported from commit b24e2464afc7a4703d4a679ab0b51ac150f1ce89)
 2012-10-23 22:08:47 -04:00
Keegan McAllister
af065005fc Automatically resize the compose box 
(imported from commit 7e9cb632bdca47fee6ad0897a55d1d3c004c34b3)
 2012-10-23 22:08:44 -04:00
Keegan McAllister
eaecaab7f4 Rename narrow.all_personals -> all_huddles 
(imported from commit 6258ddd1548b6ee8cf20c28c9b18e229ebf4e720)
 2012-10-23 20:43:23 -04:00
Keegan McAllister
f0bebe1cc0 Change 'p' hotkey to 'h', for 'huddles' 
(imported from commit 3415f1d3f679be41cb5b92827036b09829a99734)
 2012-10-23 20:41:54 -04:00
Waseem Daher
8ce8a083bb Slightly hackish way of stripping out   in narrowbar tooltips. 
(imported from commit 414738408cd1e4e53f0268b0851c903c6a1a9eda)
 2012-10-23 20:30:58 -04:00
Waseem Daher
feff1d811d Allow icons in narrowbar without putting their HTML in the title text. 
Before this commit, a hover read "<i class='icon-whatever'></i> All huddles with..."

(imported from commit e5a20678b87355d6709ec3b8776469114c92b2f6)
 2012-10-23 20:21:51 -04:00
Keegan McAllister
718018bbf6 select_message_by_id: Fix return value when already selected 
(imported from commit c86509f6cf040d6acb771764d7fe2b40afa72fe3)
 2012-10-23 19:34:54 -04:00
Tim Abbott
bcfe06c69c Don't show floating recipient bar when narrowed to huddle/subject. 
(imported from commit b7cbd83035292ed447a3da666df9326d75aac35e)
 2012-10-23 18:29:54 -04:00
Keegan McAllister
afdd3af1b6 Handle having no selected message more gracefully 
(imported from commit ba00c012061b35dfe490bf1312b3fa78a4f6582f)
 2012-10-23 17:03:31 -04:00
Keegan McAllister
0744332658 select_message: Reliably return success or failure 
(imported from commit 5e6b4066bd53a9b958ec0e752550feb423e52de5)
 2012-10-23 17:03:31 -04:00
Zev Benjamin
d4c2fd6cb6 Don't update the pointer on the server when the client receives messages 
(imported from commit 54a0d10e94d2f4d39a29d4c8596bf4712c1eb45b)
 2012-10-23 16:39:05 -04:00
Zev Benjamin
6c4b56517f Revert "Temporarily disable pointer sync" 
This reverts commit 7d8f673559ca6359923aa0bdd48edebe0955e921.

(imported from commit 32f7ad925cc4df72220a191602487620a9970f43)
 2012-10-23 16:39:04 -04:00
Keegan McAllister
e7746e97e8 select_message: Fall back to the last, not first, message 
This seems more likely to be what people want when e.g. viewing all huddles.
Later we can get more clever and select the nearest huddle, or something.

(imported from commit 8ec1aa02c050dd25eb868b1e317d114743525c7b)
 2012-10-23 16:31:05 -04:00
Keegan McAllister
37ac9d2a91 select_message: Misc cleanup 
We can safely call .is(':hidden') on an empty jQuery result and get false.

(imported from commit a73932f63b8fec7c43d8603fca95adcd4f164317)
 2012-10-23 16:28:40 -04:00
Keegan McAllister
d34bebc584 select_message: Properly fall back to the first visible message 
Our old selector here was picking up the floating recipient label, or
something.  This was breaking narrow-to-all-huddles when on a stream message --
you get no selection and the code is sad.

(imported from commit d25fab03bd6d745df6d787c0b1b6452c8c539e32)
 2012-10-23 16:28:40 -04:00
Keegan McAllister
b049749cb2 New hotkeys for narrowing 
- s for stream or huddle
  - S for subject
  - p for all personals (still buggy)

We've eliminated the 'g' prefix entirely.  And the old 'g-a' un-narrow sequence
has no new equivalent, but you can still use Esc.

(imported from commit 6bdaacce9639e3f749418e06622a317937e7d014)
 2012-10-23 15:28:07 -04:00
Zev Benjamin
ce3ea9f019 Temporarily disable pointer sync 
(imported from commit 74e6bb347e0b8c01b6450914a50448b78b9749c9)
 2012-10-23 15:24:00 -04:00
Keegan McAllister
86159813df Hide the "Load older messages" button in narrowed view 
Ideally this would be part of hiding zhome, but right now zhome/zfilt are
assumed to the tables themselves, and changing that seems unfortunately
invasive.  And it's not crazy to think of the "loading controls" as a logically
separate thing that we might show/hide independently.

Longer term, we may want an indication in narrowed view that there could be
more messages on the server.

(imported from commit eb72d720da7c03f6f1378ae18ab6e973bf98247f)
 2012-10-23 13:28:08 -04:00
Zev Benjamin
fca4cade34 Ignore long-poll successes with no data 
The server will occationally return successfully with no data during
a restart.  Previously, when we would get such responses, the page
would stop working because of JS errors.

(imported from commit 39b89907dc5ae9a9eb54ebf60d0069281e401786)
 2012-10-23 12:03:56 -04:00
Tim Abbott
9779ca9e5c Shorten get_updates timeout to under a minute. 
(imported from commit fcc87011051c25051861e3c36e442398cd3ca3c0)
 2012-10-23 11:31:32 -04:00
Zev Benjamin
ed05e28e55 Update server when selected message changes via scrolling 
(imported from commit a763baf064e73d358632f3754aba940d188f733d)
 2012-10-23 10:30:59 -04:00
Zev Benjamin
899d5c776f Check reason_empty on client when there are no new messages 
This fixes a problem where the client would never stop asking for old
messages (bug introduced during rebase)

(imported from commit eef9f19e1e9982b1e0a954eb36a81e1b7ee5b564)
 2012-10-22 18:19:14 -04:00
Zev Benjamin
0f474285bf Up idle timeout for reload 
(imported from commit 7d9c7dbd77f49865d7e1922ddcee08cd963f4abf)
 2012-10-22 17:30:26 -04:00
Zev Benjamin
732ca19729 Synchronize the pointer across sessions 
The client may now optionally send its current pointer during
get_updates and the server will return the latest pointer if it
differs and was updated more recently by a different session.

(imported from commit e43b377d7dfb52f83cefb0b1003863d5407caf80)
 2012-10-22 16:44:57 -04:00
Zev Benjamin
7e4b7fb881 Add message selection option to not update the server 
(imported from commit a5ef9506be24fee7652cd5479cb74789aa365216)
 2012-10-22 16:06:38 -04:00
Zev Benjamin
bb64eb717f Make select_message and friends take an options argument 
The select_and_show_by_id function is now subsumed by select_message_by_id.

(imported from commit 3dbe9cf9d253b64733f269b6dc78c144100927ca)
 2012-10-22 16:06:38 -04:00
Zev Benjamin
35bb3613cd Rate limit pointer updates to avoid hammering the server 
(imported from commit e1add1b64779f3d0caf5426eb99233e78de278ae)
 2012-10-22 16:06:38 -04:00
Tim Abbott
bf007776ce Fix selecting huddles using the mouse type-tabs. 
(imported from commit 6b9981cf6d5a5aaf9d644a18cc04397f3cf0dead)
 2012-10-20 10:35:39 -04:00
Zev Benjamin
33c40bd9ba Don't reload the app after sending messages 
(imported from commit 0985a3e7d13b1be00ae0b190914aeb3647ba196a)
 2012-10-19 18:25:57 -04:00
Keegan McAllister
5b13f9192f Load more messages when the user presses the "Load more messages" button 
(imported from commit 060e6f67b13fd67b56f80f913eb6b835860a8115)
 2012-10-19 17:13:14 -04:00
Keegan McAllister
3dfed7b6a1 Add a "Load more messages" button 
...which currently does nothing.

(imported from commit 185b35c2bf651779bfcdba44524d1bcb8af74f27)
 2012-10-19 17:13:13 -04:00
Keegan McAllister
fa011c108c Factor out restart_get_updates 
(imported from commit 03755dccbbe296e8c5208c460d80645c0fa17e14)
 2012-10-19 17:13:12 -04:00
Keegan McAllister
c67e7035aa Limit the number of old messages the client requests 
(imported from commit 6bff6aa0b48d46b98aa68c6e29eb569cf41f4989)
 2012-10-19 17:13:08 -04:00
Zev Benjamin
a80e08fbf3 Fix typo 
It was preventing the right text area being focused on huddles

(imported from commit 8ebe457b4e5bce723e3afd9f396f97eeb0e97c46)
 2012-10-19 17:04:28 -04:00
Zev Benjamin
9c2da407e6 Update the current composition type on toggle 
This was preventing huddles from sending because clients thought they
were still sending a stream message.

(imported from commit 694b06cbc43adc9563327ebffccb7fa37aa36bac)
 2012-10-19 17:00:27 -04:00
Zev Benjamin
337836ef54 Fix initial focus on new messages 
(imported from commit 4553f6209362f684110b34e92fdba2046cfbb08e)
 2012-10-19 16:17:29 -04:00
Zev Benjamin
9de73b5a91 Be intelligent about which input box is highlighted in compose.start() 
(imported from commit 37268601d569fdb510415ebfae594804817c0e3a)
 2012-10-19 16:09:13 -04:00
Zev Benjamin
2a98045406 Fix responding to messages (broken by rebase error) 
(imported from commit 1fac8d8757ee7f9b79c35e884edaa37e5cca0120)
 2012-10-19 15:59:03 -04:00
Zev Benjamin
88e09c6166 Only reload the page when the user is idle 
Also, clean up reload-related function names a bit

(imported from commit 4c2e17c06d7567e71b92f6e1b04a44aeff419bff)
 2012-10-19 15:53:05 -04:00