Elliott Jin
6a61a8a431
outgoing webhooks: Consolidate interfaces into lib/outgoing_webhook.py
2017-07-24 14:10:14 -07:00
Elliott Jin
e9e1842113
outgoing webhooks: Remove unused __init__ methods.
2017-07-24 14:10:14 -07:00
vaibhav
4c50c4fc76
Add outgoing webhook interface for Slack.
2017-07-24 14:10:14 -07:00
vaibhav
e5be29bc3c
Add tests for Generic Interface.
2017-07-24 14:10:14 -07:00
vaibhav
d0ad91093f
Add support to omit the response message in generic interface.
2017-07-24 14:10:14 -07:00
vaibhav
d82373b76b
Fix Service model and related helper function.
2017-07-24 14:10:14 -07:00
vaibhav
87dcd5442a
outgoing webhook system: Minor fixes.
...
This fixes some error message strings and skips converting request_data
into json. From now, conversion would be the responsibility of interface.
Also, base_url is now not passed into event structure.
2017-07-24 14:10:14 -07:00
vaibhav
ff63f0b1d3
Return response string instead of dict() from process_success, process_failure.
2017-07-24 14:10:14 -07:00
Tim Abbott
40c25e41f1
version: Update PROVISION_VERSION for jQuery upgrade.
2017-07-24 11:31:28 -07:00
Cory Lynch
a01eb190d6
Update to jQuery version 3.
...
Fixes #5483 .
2017-07-24 10:54:47 -07:00
Cory Lynch
d32e89aae4
jQuery: Remove broken use of "removeAttr".
...
This function no longer sets properties to false, so the supported
way of doing this is to instead use prop(foo, false). Some tests
had to be fixed to accommodate this.
2017-07-24 10:54:47 -07:00
Cory Lynch
02c6672499
drafts: Fix casper timing bug in jQuery 3.
2017-07-24 10:54:47 -07:00
Cory Lynch
9f91d4c265
Remove deprecated jQuery "delegate" function.
...
Replaced by "on".
2017-07-24 10:47:16 -07:00
Cory Lynch
274cabff98
Remove instances of deprecated jQuery "bind".
...
They have been replaced with "on".
2017-07-24 10:47:16 -07:00
Shubham Gupta
caee548074
overlays: Fix compose box closing when clicking on overlays.
...
This was a bug introduced by a recent refactoring to rename .modal to
.overlay for consistency.
Fixes #5886 .
2017-07-22 12:06:00 -07:00
Rishi Gupta
161f3c4e68
docs: Fix link to open accessibility issues.
2017-07-22 11:51:33 -07:00
Tim Abbott
b7211733e2
node_cache: Rename npm_cache to target_path.
...
This is cleaner and part of renaming these variables to refer to the
node_modules_cache.
2017-07-21 17:28:20 -07:00
Tim Abbott
e1e5e15797
node_cache: Move npm_args inside the interface.
2017-07-21 17:28:20 -07:00
Tim Abbott
b1944b5e1f
node_cache: Fix buggy type annotations for copy_modules.
2017-07-21 17:28:20 -07:00
Tim Abbott
8523c24a17
node_modules: Move success stamp to root of cache dir.
...
This location makes more sense, since it's the entire directory we're
certifying, not just the `node_modules` subdirectory.
2017-07-21 17:28:20 -07:00
Tim Abbott
4c37f93238
clean-npm-cache: Rename npm_cache to current_cache_dir_base.
2017-07-21 17:28:20 -07:00
Tim Abbott
a3fd3fe1eb
clean-npm-cache: Rename cached_node_modules to current_.
2017-07-21 17:28:20 -07:00
Tim Abbott
6bbd08eca3
clean-npm-cache: Rename success_stamp to current_success_stamp.
2017-07-21 17:28:20 -07:00
Tim Abbott
9f57532c3d
clean-npm-cache: Rename npm_cache_dir to node_modules_cache_dir.
2017-07-21 17:28:20 -07:00
Tim Abbott
fe6925b341
clean-npm-cache: Swap the order of the cleaning logic.
2017-07-21 17:28:20 -07:00
Tim Abbott
169fdd6e69
tools: Remove remaining deprecated tools.
...
It seems unlikely that we're going to get more future value out of the
old stress test than the cost of trying to keep it.
2017-07-21 17:28:20 -07:00
Tim Abbott
35a041c3bd
clean-npm-cache: Move up NODE_MODULES_CACHE_PATH for Travis.
...
This makes the code more readable and also will help simplify the
patch when we switch to yarn.
2017-07-21 17:28:20 -07:00
Pweaver (Paul Weaver)
1b7aee7cd6
scripts: Add cd_exec library helper.
2017-07-21 17:28:20 -07:00
Tim Abbott
59abefa616
node_cache: Extract cached_node_modules variable.
2017-07-21 17:28:20 -07:00
Tim Abbott
5d05cc7294
scripts: Rename NPM_CACHE_PATH to NODE_MODULES_CACHE_PATH.
2017-07-21 17:28:20 -07:00
Pweaver (Paul Weaver)
7d5484cabf
yarn: Add /yarn-error.log to .gitignore.
2017-07-21 17:28:20 -07:00
Tim Abbott
1e2cc2e8ad
third: Add yarn installer to Zulip repo.
2017-07-21 17:28:20 -07:00
James Rowan
bba90c5096
emails: Make missed message email come from 'Zulip Missed Messages.'
2017-07-21 14:24:03 -07:00
Brock Whittaker
04ece5e5c5
portico: Redesign /why-zulip and /for/ open-source to be more readable.
...
This redesigns these pages to be more readable and more in line with
the rest of the portico page styling.
2017-07-21 14:17:20 -07:00
Harshit Bansal
c1dc48f41b
emoji: Merge the two semantically same tips on the Custom emoji page.
...
In case the user was not allowed to upload an emoji, we were displaying
two different but sematically same tips. This commit merges them and
also updates `update_custom_emoji_ui()` function in settings_emoji.js
to live update tooltip.
2017-07-21 13:29:27 -07:00
Jack Zhang
04e80093cf
register.html: Stop height offset from client-side error messaging.
2017-07-21 13:09:06 -07:00
Jack Zhang
7d1824f26e
register.html: Indent under new org / user sections.
2017-07-21 13:09:06 -07:00
Jack Zhang
1c9426fdce
registration: Divide form into user and org sections.
2017-07-21 13:09:06 -07:00
Jack Zhang
948d9c8d29
registration: Add domain text next to subdomain input field.
2017-07-21 13:09:06 -07:00
Jack Zhang
149572e14a
registration: Style register form into a centered layout.
2017-07-21 13:09:06 -07:00
Jack Zhang
8469908c33
registration: Rename 'Short name' to 'Organization handle'.
2017-07-21 13:09:06 -07:00
Jack Zhang
47b4056948
register.html: Fix indentiation via check-templates.
2017-07-21 13:09:06 -07:00
Jack Zhang
0995780f82
portico: Auto-correct and error-handle short name input.
2017-07-21 13:09:06 -07:00
Jack Zhang
8e2ec1cddc
portico: Update registration form placeholders.
2017-07-21 13:09:06 -07:00
Jack Zhang
e3ef056991
portico: Update registration form help messages.
2017-07-21 13:09:06 -07:00
Jack Zhang
e915321f89
registration: Remove organization type selection in realm creation.
2017-07-21 13:09:06 -07:00
Jack Zhang
7f96b3ef2f
portico: Fix /accounts/register autofocus.
2017-07-21 13:09:06 -07:00
Jack Zhang
c938c3be2d
portico: Remove green checkboxes from forms.
...
More than half of these are buggy. Adding them back will be
separate project for the future.
2017-07-21 13:09:06 -07:00
Cynthia Lin
4a545728a5
node tests: Add tests covering new subsetting functionality.
2017-07-21 12:13:43 -07:00
Cynthia Lin
e21c3e1cb7
settings: Nest PM content setting in Desktop notification setting.
...
Fixes #5879
2017-07-21 12:13:43 -07:00
