This commit adds code to disable checkbox in permissions panel
if unchecking the checkbox will set the setting to nobody group
and that setting can't be set to nobody group,
Fixes part of #33730.
This commit refactors code to live update UI when group
permission settings are changed. This change makes the code
cleaner and also makes sure we do not update the UI multiple
times when multiple settings are changed in a single request.
By moving the header background to <thead>, we achieve two things:
1. We avoid a bug in Chrome where the table background bled through
between header cells.
2. We no longer need `!important` on the data-sort hover, because
there is no longer a color set there.
In the move topic modal, the `new_topic_name` input is disabled if
the user doesn't have permission to move messages between topics.
This commit fixes a bug where `new_topic_name` is undefined since its
input is disabled. This causes `show_topic_already_exists_warning()`
to throw an AssertionError. Hence, the warning is not shown.
Specifically, this bug occurs when a user moves a topic to an
already existing topic in a different channel when he has permission
to move messages between channels but not between topics.
In the move topic modal, the stream ID from the dropdown widget
should be passed to `update_submit_button_disabled_state()`
function instead of `current_stream_id`. This fixes a bug where
the submit button was incorrectly disabled after editing the
move topic input.
Specifically, when selecting a different channel and an existing
topic, the submit button remains enabled initially. However, if a
character is removed and then retyped in the move topic input,
the submit button becomes disabled incorrectly.
This commit fixes a bug where the Rename topic modal did not resize
when the "topic already exists" warning was shown or hidden. This
caused the topic edit typeahead for topics in a channel
with similar prefixes to be misaligned.
Without hovering on the name or profile picture user-card-tooltip
was visible but on_click user card does not open.
To fix it message-avatar class is added in the
register_click_handlers function.
This commit removes the `/try-zulip` landing page.
The URLs are replaced with `chat.zulip.org/?show_try_zulip_modal`,
which leads to display a modal for spectators.
Fixes#34181.
This commit adds a modal which will be displayed when
a spectator visits `/?show_try_zulip_modal`.
When a user visits `/?show_try_zulip_modal` and is a spectator,
we set a new `show_try_zulip_modal` field in `page_params` to
`true` (in all other cases, it's `false`).
Based on the `show_try_zulip_modal` page param, the web client
shows the modal.
Fixes part of #34181.
While uploading a file, if you close the compose box, and reopen
it, compose send button remains disabled due to upload in progress
being true.
To fix it, we update upload status for compose when upload is
cancelled.
This reverts commit 7d08f32ebb.
The commit message is factually incorrect, and the change broke our
fade-out transitions. visibility can be transitioned, and there is a
specific rule for what that means. This is critical for transitioning
opacity in the fade-out direction: if you fail to also transition
visibility, then the element disappears immediately regardless of
opacity.
https://developer.mozilla.org/en-US/docs/Web/CSS/visibility#interpolation
Signed-off-by: Anders Kaseorg <anders@zulip.com>
`visibility` cannot be animated since it is a boolean.
This fixes composition failure error in Chrome dev tools when
these animations are triggered that the animation has
no visible change.
When hovering over the user avatar, the tooltip
"View user card" appears. If this tooltip appears
over the currently selected message, then pressing
`u` once doesn't show the user card popover, rather
it only hides the tooltip. It is on the second press of `u`
that the user card appears.
This commit fixes that.
We also add some comments to help clarify this code path.
Fixes#32970
When navigating from a short message to a tall message via up
keypress, we used to jump to the top of the message. This
doesn't align with user's expectation that up / down keypress
will let them see the entire message feed.
To fix it, we can `page_up` which scrolls up the correct amount
and then our message selection logic kicks in to select the
correct message on screen.
When adding new messages, we were updating buddy list which
resulted in insertion errors.
Fixed by not updating the right sidebar in case of spectators.
This reduces confusion amount users when they download the
intel version and it works super slow. Downloading the arm64
version on an intel mac would just not work.
Users who use intel macs have a habit now (atleast me) to look
for `Intel` version of software when downloading an app. So, made
`Intel` bold to help that process.
Changes banner text to "This conversation also has older unread
messages. Jump to first unread message?"
Updates button label from "Jump to first unread" to "Jump".
- Rename the variable "pills" to "email_pill_widget". To conform better
with other pill widgets.
- Re-use the email pill creation function.
- Directly access `item.email`, skipping function call.
