paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-05 06:23:38 +00:00
Code Issues Packages Projects Releases Wiki Activity
51,160 Commits 30 Branches 160 Tags
7bf0793c945d25a2f5d45c18302ae63f65e7cf9f
Commit Graph

277 Commits

Author SHA1 Message Date
Greg Price
3bceeec89f push notifs: Add logging on creating device tokens. 
We'd been getting errors from APNs that appeared to say that the
device tokens we were trying to send to were invalid.  It turned out
that the device tokens didn't match the "topic" (i.e. app ID) we were
sending, which was because the topic was wrong, which was because we
were using the wrong SSL cert.  But for a while we thought it might be
that we were somehow messing up the device tokens we put into the
database.  This logging helped us work out that wasn't the issue, and
would have helped our debugging sooner.
 2017-08-26 14:16:05 -07:00
Umair Khan
a5c05f9812 push_notification: Retry event in case of error. 
Fixes #5301
 2017-08-22 11:16:48 -07:00
Tim Abbott
d6e0960ca2 push_notifications: Fix mypy annotation logic around push tokens. 
I'm not 100% confident this is long-term correct, but at least it's
consistent.
 2017-07-07 10:54:37 -07:00
kunall17
d8310724b6 Use absolute URLs in GCM push notifications. 
This will eventually allow us to simplify the logic required for the
mobile apps processing GCM notifications.
 2017-06-15 03:56:59 -07:00
Steve Howell
e3c6c22269 Optimize push_notifications.response_listener(). 
We were needlessly getting a UserProfile object out of cache,
when we only needed the user_id.
 2017-06-10 10:43:57 -07:00
Aditya Bansal
8680c87f56 pep8: Add compliance with rule E261 zerver/lib/push_notifications.py. 2017-05-31 17:07:15 -07:00
Umair Khan
bc15085098 gcm: Increase retries to 10 while pushing. 2017-05-17 12:14:32 -07:00
Umair Khan
38ecc35cd9 push_notifications: Catch IOError while pushing to GCM. 2017-05-17 12:14:32 -07:00
Umair Khan
7e8f4ca4e8 push_notifications: Include GCM in end-to-end test. 2017-05-17 08:09:19 -07:00
Tim Abbott
0b2388bda9 push_notifications: Remove DeviceTokenType logic. 
The syntax wasn't valid on Python 3.5, and the new code is somewhat
more readable anyway.
 2017-05-16 12:26:55 -07:00
Tim Abbott
9d63a5ab3a push_notification: Delete obsolete DBX_IOS_APP_ID code. 
I'm not sure that this was ever actually used, but it's definitely
just clutter for Zulip today.
 2017-05-16 12:26:55 -07:00
Umair Khan
286f9a40e7 push_notifications: Bring file to 100% coverage. 2017-05-16 12:26:55 -07:00
Umair Khan
fc0b9358e7 handle_push_notification: Remove the if condition. 
'if apple_devices or android_devices' doesn't servce any purpose.
 2017-05-16 12:26:55 -07:00
Umair Khan
ab411ab7b3 push_notifications: Delete remote server tokens in APNs response. 2017-05-16 12:26:55 -07:00
Umair Khan
33332539df send_android_push_notification: Delete correct tokens. 
Now this function will delete tokens from RemotePushDeviceToken if it
is running on notification bouncer or PushDeviceToken if it is running
on a server which doesn't use notification bouncer.
 2017-05-16 12:26:55 -07:00
Umair Khan
4a864c7515 push_notification: Send data to notification bouncer. 2017-05-16 12:26:55 -07:00
Umair Khan
329b377e6a push_notification: Add uses_notification_bouncer(). 
This function abstracts the logic to ascertain if we are using
notification bouncer service or not. Makes our code more
maintainable.
 2017-05-11 12:04:16 -07:00
Umair Khan
112a67097b push_notifications: Don't get alert message. 
Now we set the alert message in the payload functions for both GCM and APNs so
no need to get it here.
 2017-05-11 12:04:16 -07:00
Umair Khan
3c32bc6d8a push_notification: Create get_gcm_payload. 2017-05-11 12:04:16 -07:00
Umair Khan
d90774b9db push_notifications: Create get_apns_payload. 
This function creates the payload that we will send to APNs.
 2017-05-11 12:04:16 -07:00
Umair Khan
5ff7fdf83a push_notification: Create get_alert_from_message. 
This function returns the alert shown by iOS or Android device.
 2017-05-11 12:04:16 -07:00
Aditya Bansal
69cf11d786 pep8: Add compliance with rule E261 to push_notifications.py. 2017-05-07 23:21:50 -07:00
Tim Abbott
c0d7e83333 logging: Change missing push notification keys from error to warning. 
This is a configuration problem, but it just means a feature is not
enabled, not that attention is required, so it should be a warning,
not an error.
 2017-04-25 13:52:36 -07:00
Tim Abbott
cddee49e75 Add support infrastructure for push notification bouncer service. 
This is an incomplete cleaned-up continuation of Lisa Neigut's push
notification bouncer work.  It supports registration and
deregistration of individual push tokens with a central push
notification bouncer server.

It still is missing a few things before we can complete this effort:
* A registration form for server admins to configure their server for
  this service, with tests.
* Code (and tests) for actually bouncing the notifications.
 2017-04-18 23:03:06 -07:00
hackerkid
b2504084ab Replace timezone.now with timezone_now. 2017-04-16 12:28:56 -07:00
Tim Abbott
89eb7636ba remove_push_device_token: Remove unused request argument. 2017-03-05 22:01:28 -08:00
Tim Abbott
657dfcbddc push: Move remove_push_device_token to library. 2017-03-05 19:15:17 -08:00
Tim Abbott
c0ad9c02fd push: Extract validate_token helper function. 2017-03-05 19:15:17 -08:00
Tim Abbott
271bd5a282 push: Move add_push_device_token to library. 2017-03-05 19:15:16 -08:00
Tim Abbott
410c0626a6 push: Pass apple alert via the zulip dict. 
This completes the process of simplifying the interface of the
send_*_push_notification functions, so that they can effectively
support a push notification forwarding workflow.
 2017-03-05 18:37:00 -08:00
Tim Abbott
fc192d6b3b push: Don't pass a UserProfile into send_apple_push_notification.. 2017-03-05 18:37:00 -08:00
Tim Abbott
393c4d2eaa push: Don't pass a UserProfile into _do_push_to_apns_service. 2017-03-05 18:37:00 -08:00
Tim Abbott
53c9e3b4ca push: Don't pass a full UserProfile into APNsMessage. 2017-03-05 18:37:00 -08:00
Tim Abbott
c8bfd568bc push: Pass devices list into send_apple_push_notification. 2017-03-05 18:36:58 -08:00
Tim Abbott
0ddaf5c610 push: Pass reg_ids list into send_android_push_notification. 
This refactoring is preparation for being able to forward push
notifications to users on behalf of another Zulip server.

The goal is to remove access to the current server's database from the
send_*_push_notification code paths.
 2017-03-05 18:36:07 -08:00
Tim Abbott
b1b2d8d2c7 push: Move handle_push_notifications to push_notifications.py. 2017-03-05 18:32:09 -08:00
Raghav Jajodia
a3a03bd6a5 mypy: Added Dict, List and Set imports. 
Fixed mypy errors associated with the upgrade.
 2017-03-04 14:33:44 -08:00
Tim Abbott
4e171ce787 lint: Clean up E126 PEP-8 rule. 2017-01-23 22:06:13 -08:00
Tim Abbott
de99f48ce7 lint: Clean up E401 PEP-8 rule. 2017-01-23 21:36:39 -08:00
Robert Hönig
0917493588 mypy: Convert zerver/lib to use typing.Text. 2016-12-25 10:33:45 -08:00
Umair Khan
c24fbd28b2 Shift to python-gcm for Android push notifications. 
Fixes #2650
 2016-12-15 12:17:07 -08:00
nikolay
abc2ff4a06 pep8: Fix many rule E128 violations. 
[Tweaked by tabbott to adjust some approaches used in wrapping]
 2016-12-03 13:33:31 -08:00
Umair Khan
acd76eb604 Annotate push_notifications.py. 2016-08-08 15:17:02 -07:00
Umair Khan
0dd7d0dda1 push_notifications: Change name to 'identifier'. 2016-08-08 15:15:29 -07:00
Umair Khan
d33fc0046f Add APNS feedback server tests. 2016-08-05 10:36:57 -07:00
Umair Khan
40054ce26c Add APNS response listener test case. 2016-08-05 10:36:57 -07:00
Umair Khan
882bb5558b Push to APNS in a loop. 2016-08-05 10:36:57 -07:00
Umair Khan
4e8ca0a326 Make sure apns response code is an integer. 2016-08-05 10:36:57 -07:00
Umair Khan
5c41eae7ec Don't send connection to apns response listener. 2016-08-05 10:36:57 -07:00
Umair Khan
ffaf7cb2ba Create get_connection function for APNS. 2016-08-05 10:36:57 -07:00