Before 567e8f369e, the background-color
for .grey-box was --color-background-modal-bar, but the dark part out of
the light-dark() for that color was being overriden by
hsl(0deg 0% 0% / 20%) in dark_theme.css. Since that was a refactor PR,
we added a new color called --color-background-grey-box to keep the
behaviour same as before.
But discussion in
https://chat.zulip.org/#narrow/channel/101-design/topic/grey-box.20dark.20theme.20color.2E
confirmed that we want to have `--color-background-modal-bar` as the
background color for that class.
The dark component out of the light-dark() of
--color-message-list-border is hsl(0deg 0% 0% / 40%), which is the same
as the color we specify in dark_theme.css.
- .recipient_row already uses the above variable, so it's entry is not
needed in dark_theme.css
- .message_row uses the same variable as well.
- .overlay-message-row does not have a direct border. Although
.message_row nested inside it does. It already uses the above
variable, so we can remove this entry as well.
Fixes part of #35881.
We extract out relevant colors from dark_theme.css for .stream-row and
.group-row and place them in light-dark(). We also transform all these
colors for .group-row and .stream-row into variables.
We use the alpha value for hsl() colors as a stand-in for the opacity we
were defining in dark_theme.css.
Fixes part of #35881.
Instead of having all the rules in the dark_theme.css, we use the
existing variable which uses `light-dark()`.
We also create a new variable color-border-settings-radio-input-parent,
since the existing variable was not created for that radio input and
they should be allowed to change independently.
Earlier, transient errors while marking an onboarding step as read
resulted in blueslip reporting - which is not required.
This commit updates the logic to retry with backoff in case of error.
Signed-off-by: Prakhar Pratyush <prakhar@zulip.com>
There is no longer any opacity in the
--color-background-hover-narrow-filter, so the opaque
variant just adds noise and the potential for drift
from the original color.
Followup to #36048. Since the trimming done by the compose_state
function is designed to not impact the actual Markdown rendering of a
message, it's safe to simplify the code path in this way.
This commit adds option to pass separate helper config to use when
rendering markdown. It uses the passed helper config if available or
fallbacks to web_app_helper config.
