Drafts, scheduled messages and message edit history had different
box-shadow done in #25771. The main reason for the different color was
for these overlays with the new background colors to play nice with the
then message/sidebar sections using the old background colors. Since
there is no such difference anymore, we can have one box-shadow for all
overlays.
Removes the instances of the "margin" class from register.html and
the portico CSS rule. Doing so does not result in any visible
changes in the only place it was being applied the terms of service
checkbox on the page.
Before 567e8f369e, the background-color
for .grey-box was --color-background-modal-bar, but the dark part out of
the light-dark() for that color was being overriden by
hsl(0deg 0% 0% / 20%) in dark_theme.css. Since that was a refactor PR,
we added a new color called --color-background-grey-box to keep the
behaviour same as before.
But discussion in
https://chat.zulip.org/#narrow/channel/101-design/topic/grey-box.20dark.20theme.20color.2E
confirmed that we want to have `--color-background-modal-bar` as the
background color for that class.
The dark component out of the light-dark() of
--color-message-list-border is hsl(0deg 0% 0% / 40%), which is the same
as the color we specify in dark_theme.css.
- .recipient_row already uses the above variable, so it's entry is not
needed in dark_theme.css
- .message_row uses the same variable as well.
- .overlay-message-row does not have a direct border. Although
.message_row nested inside it does. It already uses the above
variable, so we can remove this entry as well.
Fixes part of #35881.
We extract out relevant colors from dark_theme.css for .stream-row and
.group-row and place them in light-dark(). We also transform all these
colors for .group-row and .stream-row into variables.
We use the alpha value for hsl() colors as a stand-in for the opacity we
were defining in dark_theme.css.
Fixes part of #35881.
Instead of having all the rules in the dark_theme.css, we use the
existing variable which uses `light-dark()`.
We also create a new variable color-border-settings-radio-input-parent,
since the existing variable was not created for that radio input and
they should be allowed to change independently.
There is no longer any opacity in the
--color-background-hover-narrow-filter, so the opaque
variant just adds noise and the potential for drift
from the original color.
This commit handles the empty channel placeholder for drafts saved
without a channel selected. When these drafts also do not have a topic,
we display "No topic selected" in tandem with "No channel selected",
since we are unable to access the channel configuration to determine
if we should display realm_empty_topic_display_name.
Name input for stream and group edit modal was too wide in narrow
width screens and overflowed the modal. This commit adds CSS to
make sure that maximum width of input field is set to fit inside
the modal respecting the modal container paddings on narrow width
screens.
Fixes#35301.
"Upload profile picture" and similar text shown when hovering
over the image shows a blue outline while clicking on it
and same blue outline is shown when clicking on the delete
button ("x") as well. This commit updates the CSS to remove
that outline.
If all channels in a folder are muted, then this margin is present
in "Standard view", without there being any folder present.
Fixed by only applying margin if the folder has any header or rows
that are not hidden by filters.
This is an alternative fix to #35962 which was reverted in #36123.
We are not processing this input at the POST endpoint, this
commit just disables the selection from changing.
It is not easy to process changing "import from" at this stage,
but we can possible allow that in a future refactor.
Fixes#35899.
We don't make any visual changes to how the svgs/icons look, we just
move them to use the zulip-icon system.
We also replace use of the raw images of each in the help center and add
appropriate color for both in the help center.
This helps to prevent an edge case where clicking the
new-topic button, `[+]`, in the left sidebar when the
topic box was already empty caused an unexpected flash
of the *general chat* topic.
The transitions here do not work correctly across all
states, and directly interfere or look goofy with the
transitions in the recipient-row area.
Particularly with the removal from #message-content-container,
that had the annoying effect of just delaying the
appearance of the focus border, regardless of whether
focus was established via keyboard or mouse.
Previously, if the mouse cursor were in the vicinity of
the compose box, we'd see transitions even on keyboard
interactions, which should not have been happening.
This also allows instantaneous highlighting for keyboard
users, as well as avoiding any transitions when a
mouse user clicks into a recipient-row element (at
which point the hover transitions will have already
run).
The "light-border" theme was set as the default theme for all the
popovers, but was no longer in use, since all of our current popovers
either use the "popover-menu" theme or the "dropdown-widget" theme.
In response to the above reasoning, this commit removes the redundant
"light-border" Tippyjs theme usage from the codebase.
In the light theme, the user profile modal tables were using two
different border colors, both very similar to one another. This commit
consolidates them into a single border color for consistency.
The feedback container doesn't have a border so it doesn't make sense
to have a border color defined for the dark theme, and the hover color
change on the `a` tag was an unintended side effect of
commit d73a5d06c0, which while correcting
the hover effect on the typeaheads, also affected the link hover styles
in the feedback container.
This commit, due the reasons mentioned above, removes the entire CSS
block related to the feedback container from web/styles/dark_theme.css.
Fixes part of #35880.
