paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-12 01:47:41 +00:00
Code Issues Packages Projects Releases Wiki Activity
34,653 Commits 30 Branches 160 Tags
906160f1a3f0c3754c9cd30bbab337f9a888d8c7
Commit Graph

6082 Commits

Author SHA1 Message Date
Tim Abbott
906160f1a3 presence: Re-introduce data filtering when offline. 
This should return us to a situation where we won't get blueslip
browser error reporting for users created while a device was offline
just before it reloads.
 2020-02-13 15:45:39 -08:00
Tim Abbott
3f76124c6c activity: Ignore presence responses when trying to reload. 
This avoids risk of logging blueslip errors for user IDs seen in the
presence response that we haven't heard about from the server_events
system because we're offline and in the process of reloading.

The issue only affected large realms; see
02bc630881 and `git log
-Ssuspect_offline` for details.
 2020-02-13 11:47:51 -08:00
Anders Kaseorg
a889a830dc lightbox: Convert asset_map from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
b15e72e56a list_render: Remove unused listRenders object. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
c4e08a99d7 list_render: Convert generic_sorting_functions from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
4f39199f6d list_render: Convert sorting_functions from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
e5c577aad4 list_render: Convert instances from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
146f5cd600 util: Convert selected_hash from object to Set. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
9d27407731 tictactoe_widget: Convert square_values from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
5383f019be subs: Convert hidden_ids from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
055bcfd6e6 subs: Convert widgets from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
fd89f3a695 stream_data: Convert is_included from object to Set. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
2248d4d9a4 stats: Convert data from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
0e3acb5ce6 settings_account: Convert all_field_template_types from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
7844be6d3a sent_messages: Convert messages from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
bf0a3d9d14 search_suggestion: Convert prev from object to Set. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
e848bc2a21 search_suggestion: Convert huddle_dict from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
7c6ec51e5d search_suggestions: Convert lookup_table from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
d4434a54e0 integrations_dev_panel: Convert loaded_fixtures from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
9b1f55c020 integrations: Convert CATEGORIES from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
230b701acc integrations: Convert INTEGRATIONS from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
50b54563fe help: Convert html_map from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
0ce06d45a1 message_list_view: Convert message_containers from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
86dd98d481 message_list_view: Convert _rows from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
a6a19c6ace message_list_data: Convert id_set from object to Set. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
9fa9f37521 message_list_data: Convert msg_ids_to_remove from object to Set. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
dde035faf3 message_list_data: Convert _local_only from object to Set. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
2d18424da0 message_list_data: Convert _hash from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
bf32dfcb9f markdown: Convert realm_filter_map from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
0d6d36ae16 local_message: Convert already_used from object to Set. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
ec1ebc936b gear_menu: Convert scroll_positions from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
02fb1d4dd1 emoji_picker: Convert intermediate complete_emoji_catalog to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
0936381cfd echo: Convert waiting_for_ack from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
c42aca3cfb echo: Convert waiting_for_id from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
278420f908 debug: Convert sections from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
99bcd78273 debug: Convert ids from object to Set. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
265cca4756 blueslip: Convert reported_errors, last_report_attempt from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
2ddd3d046a echo: Further reduce local_id string vs. number confusion. 
New rule: local_id is always a string, local_id_float is always a
number.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
2834b051d2 js: Read zid with rows.id. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:39:01 -08:00
Anders Kaseorg
d7d8632525 pygments_data: Replace JS module with JSON module. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:09:12 -08:00
Anders Kaseorg
e257253e64 emoji_codes: Replace JS module with JSON module. 
webpack optimizes JSON modules using JSON.parse("{…}"), which is
faster than the normal JavaScript parser.

Update the backend to use emoji_codes.json too instead of the three
separate JSON files.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 10:09:12 -08:00
Anders Kaseorg
72dddb7af6 zjsunit: Use assert in strict mode. 
This makes assert.equal and assert.deepEqual compare using === rather
than ==, to catch more bugs.

https://nodejs.org/api/assert.html#assert_strict_mode

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-12 08:16:26 -05:00
Steve Howell
483f1d153d minor: Remove "spread operator" todo comment. 
This comment was addressed in
59d55d1e06
 2020-02-12 06:10:32 -05:00
Anders Kaseorg
59d55d1e06 js: Use modern spread arguments syntax. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-11 17:43:35 -08:00
Hashir Sarwar
6e14c39468 top_left_corner: Don't export should_expand_pm_list(). 
We don't need to export `should_expand_pm_list` function
since we are not using it anywhere else.
 2020-02-11 14:14:59 -08:00
Anders Kaseorg
e66c4ea474 settings_invites: Convert invited_as_values from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-10 15:57:20 -08:00
Anders Kaseorg
ed032817c7 hotspots: Convert HOTSPOT_LOCATIONS from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-10 15:57:20 -08:00
Anders Kaseorg
ee68ef516d js: Convert _.isString to typeof. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-10 15:57:20 -08:00
Anders Kaseorg
a3e5fef663 js: Convert _.isObject to typeof. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-10 15:57:20 -08:00
Anders Kaseorg
9f07cf6b0e js: Convert _.values to Object.values. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-10 15:57:20 -08:00