I noticed that when you are in a group dm narrow
and open drafts, the overlay-message-row class
is inside different containers, and the nth last
child check does not apply for that case, which is
why the test failed.
More generally, last-child is just not a good selector for robust
testing.
Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
Links become unclickable if the following is true:
1. Composebox is open
2. You have selected some text
Currently doing this will prevent the default click behavior
which is a big bug and can get quite annoying.
We now switch to a more robust check which only prevents the
click behavior if some drag evidence is present, determined with
`mouse_drag.is_drag`
Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
As per the type definition of `NarrowTerm`,
the operand should be a string.
This bug caused exceptions each time a topic was
clicked in the left sidebar.
Previously, tooltip templates were identified using the
group's name in their `id` attributes.
This change uses the group's ID instead, which is more reliable.
Previously, tooltip templates were identified using the
stream's name in their `id` attributes.
This commit changes the tooltip IDs to use the stream's ID instead,
rather than its name, to ensure uniqueness and avoid potential conflicts.
An error was raised where we tried to live update the folder name
in folder dropdown even when there was no dropdown visible
to the non-admin user in settings page. This was because
"There are no channel folders configured in this organization."
text was shown even when a folder was recently created in the
realm as we did not live update the visibility of dropdown on
creating or archiving a folder.
This commit fixes the bug by live-updating the visibility
of folder dropdown when creating or archiving a folder.
Previously, the API key was shown using a variable-width font, making
characters harder to distinguish. This change applies a monospace font to
improve readability and visual consistency.
Fixes#35189.
Co-authored-by: rxkshit04 <rakshitatwork@gmail.com>
Co-authored-by: cpu-ram <petr.stepanenko@gmail.com>
Reproducer:
Mark a message where current user is mention as unread and then
read the message before animation ends. This prevents the
`animationend` from being triggered.
Fixed by also listening for `animationcancel` which fixes the bug.
This happens since the don't exclude the row which toggles
muted / inactive channels from all_rows, while user is searching
and hence selections box ends up there while navigating to the
muted / inactive channel row.
Previously, the action buttons container was only hidden via
conditional rendering in the template. This commit adds a CSS-based
approach to also hide the container when it becomes empty, using the
:empty pseudo-class. This ensures correct behavior if we later have a
class of banners where the buttons area is dynamically updated, and
buttons are removed dynamically.
Now that the left-sidebar filter sits atop the area,
it's no longer necessary to set a z-index here.
This also fixes a bug where a hovered unread in the
collapsed views would be clipped by the filter box
above.
The zoomed in topic list search doesn't work if user searches
something and presses `enter` on `Show all topics` after
navigating via keyboard.
Fixed by not triggering `input` event on left sidebar search input
which seems to confuse the zoomed in topic search.
There isn't a way to check the complete name for long truncated channel
folders name in the left sidebar.
This commit adds a tooltip for channel folder only when the folder names
are truncated in the left sidebar.
Fixes: zulip#35582.
Prep commit to address #34977.
Links are blurred when one selects links in order to
focus the compose box, this commit prevents that from
happening which helps us avoid `e.stopPropogation()`
calls on individual handlers as the event bubbles up
to the main event handler.
Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
Having the textarea not be super small greatly reduces the temptation
to immediately resize it when working with it.
This helps reduce the impact of #35663.
Previously, closing the settings overlay without saving the
Welcome Bot custom message would discard the changes, causing
users to lose their work.
The unsaved message is now stored in a variable and restored
with the save/discard widget when the settings overlay is reopened.
Fixes#35664.
Removing the dependency on message_store fixes a race issue where the
new Message object might not have reached us at the time that this
handler was run, if the HTTP request to trigger the welcome bot
message wins the race with the events system.
Earlier, we would show operator suggestion even if it is incompatible
with current search terms. Selecting this wouldn't show further
suggestions for the operator since we don't allow narrow to incompatible
search terms.
This commit fixes this by hiding new suggestions if it is not
compatible with current search terms in the search box.
Earlier, each functions handling any suggestions would define their
own incompatible_patterns inside it to use for checking validity.
This commit refactors all incompatible_patterns to a global map
with operators or search_string as its key.
