paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity
51,956 Commits 30 Branches 160 Tags
99b37de89fa39287ffa3181fbf3ef02eed5063d1
Commit Graph

133 Commits

Author SHA1 Message Date
Anders Kaseorg
3a27b12a7d dependencies: Switch to pnpm. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-03-20 15:48:29 -07:00
Anders Kaseorg
b3f9fdf99a dependencies: Upgrade JavaScript dependencies. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-03-20 15:48:29 -07:00
Anders Kaseorg
9a8a2bd345 ruff: Enable import sorting, replacing isort. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-11-16 09:29:11 -08:00
Anders Kaseorg
adffad384c lint: Replace pycodestyle and pyflakes with ruff. 
https://github.com/charliermarsh/ruff

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-11-03 12:10:15 -07:00
Anders Kaseorg
ccfb516a79 lint: Enable caching for Prettier. 
Caching is new in Prettier 2.7.0, but broken before 3.0.0-alpha.4.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-11-02 16:50:37 -07:00
Anders Kaseorg
683a6b0411 dependencies: Upgrade Prettier to 3.0.0-alpha.4. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-11-02 16:50:37 -07:00
Zixuan James Li
bf9f9c8b5d tools: Support running mypy daemon for better performance. 
mypy daemon performs significantly better than running the regular
mypy cli tool when we type check the entire codebase multiple
times locally.

This adds running mypy daemon as an option for both
`tools/run-mypy` and `tools/lint`.

To ensure daemon messages like "Daemon started", "Daemon stopped"
won't get printed we filter any output that starts with "Daemon".

Signed-off-by: Zixuan James Li <p359101898@gmail.com>
 2022-07-06 17:33:13 -07:00
Anders Kaseorg
fe8f2fbf94 lint: Remove deprecated semgrep flag. 
The semgrep --dangerously-allow-arbitrary-code-execution-from-rules
flag is deprecated and no longer used.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-09-17 17:05:18 -07:00
Anders Kaseorg
a08c138c03 check-openapi: Add option to automatically fix errors. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-09-10 10:39:25 -07:00
Anders Kaseorg
c3448370a4 lint: Add Markdown files to Prettier linter. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-09-08 12:06:24 -07:00
Anders Kaseorg
9fec1fb16d lint: Check *.pyi stubs. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-07-11 09:20:19 -07:00
Anders Kaseorg
0ae94c6051 mypy: Move configuration to pyproject.toml. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-07-05 17:01:32 -07:00
Anders Kaseorg
684dad8145 tools: Use root-based absolute import for tools.lib, etc. 
Mypy can’t follow absolute imports based on directories other than the
root.  This was hiding some type errors due to ignore_missing_imports.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-07-05 12:21:52 -07:00
Anders Kaseorg
d428c0e0dd lint: Add .bash extension for tools/lib/git-tools.bash. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-06-25 09:01:13 -07:00
Anders Kaseorg
544bbd5398 docs: Fix capitalization mistakes. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-05-10 09:57:26 -07:00
Anders Kaseorg
16a4a46934 lint: Suppress Ruby warnings from puppet on Ubuntu 20.04. 
puppet    | /usr/lib/ruby/vendor_ruby/puppet/util.rb:461: warning: URI.escape is obsolete
puppet    | /usr/lib/ruby/vendor_ruby/puppet/util.rb:461: warning: URI.escape is obsolete
puppet    | /usr/lib/ruby/vendor_ruby/puppet/util.rb:461: warning: URI.escape is obsolete
puppet    | /usr/lib/ruby/vendor_ruby/puppet/util.rb:461: warning: URI.escape is obsolete

https://bugs.launchpad.net/ubuntu/+source/puppet/+bug/1875848
https://tickets.puppetlabs.com/browse/PUP-10247

See also commit 3971824d04 (#14571).

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-29 12:41:34 -07:00
m-e-l-u-h-a-n
911c5f19f1 tools: Rename force argument to skip-provision-check 
This commit renames --force argument used with various tests to
--skip-provision-check. As a consequence of this name change all other
files that set --force option for the test commands have been updated.

This change is done in order to provide more clarity for using this
option for runnning tests.

This commit addresses issue #17455.
 2021-03-03 09:17:49 -08:00
m-e-l-u-h-a-n
ca515e5583 tools: Move registration of --force to test-scripts.py. 
This commit moves --force option used with various tests to
test-scripts.py to have it alongside the logic that does provisioning
status assertion.
This is a step towards providing more clarity over use of this
argument with tests as asked in issue #17455.
 2021-03-03 09:17:49 -08:00
Anders Kaseorg
57f2b8760a shared: Format our one Flow file with Prettier. 
Why not.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-02-14 07:03:32 -05:00
Anders Kaseorg
f21fbea7c7 lint: Replace (most of) pycodestyle with Black. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-02-12 13:11:19 -08:00
Anders Kaseorg
6e4c3e41dc python: Normalize quotes with Black. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-02-12 13:11:19 -08:00
Anders Kaseorg
11741543da python: Reformat with Black, except quotes. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-02-12 13:11:19 -08:00
Anders Kaseorg
5028c081cb python: Merge concatenated string literals that Black would uglify. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-02-12 13:11:19 -08:00
Anders Kaseorg
c7a6902fe3 eslint: Remove and prohibit unused eslint-disable directives. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-12-10 18:08:45 -08:00
Anders Kaseorg
6099612a15 lint: Add shfmt as a linter. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-15 15:16:00 -07:00
Alex Vandiver
3e6cc49ab5 lint: Add missing spaces at line wraps, remove periods. 2020-10-04 17:57:55 -07:00
Anders Kaseorg
a3d26d701e styles: Rename .scss files back to .css. 
css-loader@4 broke @import statements referencing files with
extensions other than .css, unless those @import statements are
compiled away by another loader.  Upstream is more interested in
arguing that such @import statements are semantically incorrect than
applying the one line fix.

https://github.com/webpack-contrib/css-loader/issues/1164

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-09-15 16:33:28 -07:00
Anders Kaseorg
2acc3fbe14 lint: Use prettier --loglevel=warn for quiet output. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-09-14 18:52:43 -07:00
Anders Kaseorg
b4597a8ca8 python: Elide default for store_{true,false} argparse arguments. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-09-03 16:17:14 -07:00
Anders Kaseorg
1ded51aa9d python: Replace list literal concatenation with * unpacking. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-09-02 11:15:41 -07:00
Anders Kaseorg
c6ed5c81de styles: Format CSS with Prettier. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-08-04 16:34:19 -07:00
Anders Kaseorg
6c0afbb68d stylelint: Move .stylelintrc to stylelint.config.js. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-08-04 16:32:04 -07:00
Anders Kaseorg
9d768b79c5 semgrep: Use upstream options for silencing extra messages. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-30 15:12:22 -07:00
Anders Kaseorg
2e029eb58b lint: Use Prettier for JSON files. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-24 09:42:56 -07:00
Anders Kaseorg
308883302d lint: Make prettier quieter when fixing. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-21 16:31:18 -07:00
Anders Kaseorg
ed183fb95f lint: Use Prettier for JavaScript files. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-17 14:31:25 -07:00
Anders Kaseorg
56e8cca025 lint: Add Prettier as a linter for YAML files. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-14 16:25:31 -07:00
Anders Kaseorg
f364414cb9 install-semgrep: Upgrade semgrep to 0.14.0. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-14 00:42:07 -07:00
Anders Kaseorg
ab647abad3 lint: Use standard setup.cfg configuration for pycodestyle. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-14 00:41:20 -07:00
Anders Kaseorg
8a54dc43ce lint: Upgrade zulint and remove run-isort wrapper. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-01 12:53:21 -07:00
Anders Kaseorg
48e55875fe lint: Run isort as a linter. 
With a change to increase the line length to 100 characters by
tabbott.

Fixes #2665.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-06-11 16:47:07 -07:00
Anders Kaseorg
365fe0b3d5 python: Sort imports with isort. 
Fixes #2665.

Regenerated by tabbott with `lint --fix` after a rebase and change in
parameters.

Note from tabbott: In a few cases, this converts technical debt in the
form of unsorted imports into different technical debt in the form of
our largest files having very long, ugly import sequences at the
start.  I expect this change will increase pressure for us to split
those files, which isn't a bad thing.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-06-11 16:45:32 -07:00
Aman Agrawal
0504c61bfd semgrep: Use pattern-where-python operator to filter patterns. 
See https://github.com/returntocorp/semgrep/blob/experimental/docs/config/advanced.md#pattern-where-python for usage.

This helps us minimize duplication of similar patterns.
 2020-05-20 09:37:26 -07:00
Anders Kaseorg
baab041acd lint: Upgrade semgrep from 0.5.0-dev.2 to 0.5.0-dev.4. 
The major PROVISION_VERSION bump would not be needed, but it was
missing in commit 5ab62a3514 (#14834),
so I’m doing it here.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-05-02 10:19:40 -07:00
Anders Kaseorg
82f629091a lint: Check docs/THIRDPARTY for format errors. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-05-02 10:10:22 -07:00
Aman Agrawal
5ab62a3514 sgrep/semgrep: Updgrade and rename sgrep to semgrep. 
With its new upgrade, sgrep has been renamed to semgrep.

Rename sgrep.yml to semgrep.yml
 2020-05-01 11:01:14 -07:00
Anders Kaseorg
5901e7ba7e python: Convert function type annotations to Python 3 style. 
Generated by com2ann (slightly patched to avoid also converting
assignment type annotations, which require Python 3.6), followed by
some manual whitespace adjustment, and six fixes for runtime issues:

-    def __init__(self, token: Token, parent: Optional[Node]) -> None:
+    def __init__(self, token: Token, parent: "Optional[Node]") -> None:

-def main(options: argparse.Namespace) -> NoReturn:
+def main(options: argparse.Namespace) -> "NoReturn":

-def fetch_request(url: str, callback: Any, **kwargs: Any) -> Generator[Callable[..., Any], Any, None]:
+def fetch_request(url: str, callback: Any, **kwargs: Any) -> "Generator[Callable[..., Any], Any, None]":

-def assert_server_running(server: subprocess.Popen[bytes], log_file: Optional[str]) -> None:
+def assert_server_running(server: "subprocess.Popen[bytes]", log_file: Optional[str]) -> None:

-def server_is_up(server: subprocess.Popen[bytes], log_file: Optional[str]) -> bool:
+def server_is_up(server: "subprocess.Popen[bytes]", log_file: Optional[str]) -> bool:

-    method_kwarg_pairs: List[FuncKwargPair],
+    method_kwarg_pairs: "List[FuncKwargPair]",

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-18 20:42:48 -07:00
Anders Kaseorg
c734bbd95d python: Modernize legacy Python 2 syntax with pyupgrade. 
Generated by `pyupgrade --py3-plus --keep-percent-format` on all our
Python code except `zthumbor` and `zulip-ec2-configure-interfaces`,
followed by manual indentation fixes.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-09 16:43:22 -07:00
brendon
f65e6d0d94 sgrep: Install syntactic code search tool as an external linter. 
Add sgrep (sgrep.dev) to tooling and include simple rule as
proof of concept. Included rule detects use of old django render
function.

Also added a rule that looks for if-else statements where both
code paths are identical.
 2020-04-01 15:08:34 -07:00
arpit551
0c821424cd lint: Run whitespace linter against .yml files. 
Lint now checks for .yml files with whitespace_rules.
 2020-03-24 15:31:59 -07:00