Commit Graph

66708 Commits

Author SHA1 Message Date
Karl Stolley
41e8d79e00 api_docs: Update get-file-temporary-url endpoint and add to sidebar.
Co-authored-by: Lauryn Menard <lauryn@zulip.com>
2025-08-29 10:21:42 -07:00
Sahil Batra
6e17b05156 openapi: Mark server_supported_permission_settings field as stable.
We have mostly decided on the structure of the group permission
setting object in server_supported_permission_settings field of
register response, so this commit removes the comment mentioning
it as unstable and adds the corresponding "Changes" entry.
2025-08-29 10:20:28 -07:00
Sahil Batra
aae639a8a0 api-docs: Fix incorrect field names for group-setting value objects.
Documentation for group setting values at /api/group-setting-values
incorrectly mentioned obejct fields as 'direct_member_ids' and
'direct_subgroup_ids' when they actually are 'direct_members' and
'direct_subgroups' from the start.
2025-08-29 10:20:28 -07:00
Alya Abbott
b4edfb4a19 help: Clean up intro wording and add a note about subdomain reuse. 2025-08-29 10:19:50 -07:00
Lauryn Menard
f5587e9ffe api-docs: Revise update_message changes notes for feature level 114. 2025-08-29 10:00:44 -07:00
Lauryn Menard
87f0bea0fc api-changelog: Use backticks for null consistently in changelog. 2025-08-29 10:00:44 -07:00
Alex Vandiver
662c946635 puppet: Stop using an unnecessary concat.
This was added in 6975417acf, to support `zmirror` deployments,
which are no longer necessary.
2025-08-29 09:45:28 -07:00
apoorvapendse
3188d9db31 tools: Enforce '_html' suffix for unescaped hbs vars.
This adds a check to enforce the new convention of
raw HTML variables having a `_html` suffix for
better clarity.

Discussion: https://chat.zulip.org/#narrow/channel/92-learning/topic/Marking.20commits.20to.20be.20squashed.20in.20PRs
Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
2025-08-28 17:33:20 -07:00
apoorvapendse
a935866601 tools: Fix out-of-bounds error for get_handlebars_tag.
This might lead to errors in case we don't always have
a newline as the last character of a template.

Discussion: https://chat.zulip.org/#narrow/channel/6-frontend/topic/Add.20linter.20rule.20to.20denote.20HTML.20string.20in.20template/near/2240213
Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
2025-08-28 17:33:20 -07:00
Pratik Chanda
85e7d2f5f7 search_suggestion: Remove subset suggestions from search suggestion.
Earlier, we would show subset suggestions for current search pills
in the suggestion list. Like if `is:dm`, `is:mentioned` and `has:link`
are already selected in the searchbox, we would show
`is:dm, is:mentioned` and `is:dm` again in the suggestion.

This commit removes subset suggestions for current search pills
from the suggestion line.
2025-08-28 17:28:39 -07:00
Prakhar Pratyush
e8c9f4a811 api_docs: Deprecate the non-E2EE register push device endpoints.
Endpoints marked deprecated:
* /users/me/apns_device_token
* /users/me/android_gcm_reg_id

The older endpoints were for non-E2EE push notification case.

Fixes part of #35213.
2025-08-28 16:45:51 -07:00
Prakhar Pratyush
b157b14d76 api_docs: Mark /mobile_push/test_notification as deprecated.
The older endpoint was for non-E2EE push notification case.

Fixes part of #35213.
2025-08-28 16:45:51 -07:00
Saubhagya Patel
d0e45b99ef tippy: Remove redundant tippy instance destruction.
When `onShow()` returns `false`, the tippy instance is
automatically destroyed. This commit removes manual
destruction calls in such cases.
2025-08-28 16:40:36 -07:00
apoorvapendse
7a52313f85 composebox: Fix composebox closing on clicking links.
Previously, clicking on links with the composebox open
didn't close it.

7391a2983f introduced a bug
where the composebox focus logic wasn't triggered at all
if drag evidence wasn't present on the target.

We now do a `e.target.closest("a").length > 0` check
like before and only prevent the default click behavior if
dragging on the target link is detected.
This allows normal link clicks to trigger the
previous composebox focus trigger logic.

Fixes: https://chat.zulip.org/#narrow/channel/9-issues/topic/composebox.20closes.20when.20going.20to.20recent.20conversations
Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
2025-08-28 16:35:04 -07:00
Evy Kassirer
c52174a0a2 channel_folders: Don't label section OTHER if there are no folders above it.
Fixes #35878.
2025-08-28 15:33:12 -07:00
Karl Stolley
71fcee5093 me_messages: Don't apply an ellipsis to me messages. 2025-08-28 15:20:11 -07:00
Karl Stolley
165c47cb14 compose: Ensure textarea is hidden in compose preview.
This corrects a subtle bug where being zoomed in in
a narrow window causes textarea bleedthrough behind
elements like the audio player.
2025-08-28 15:20:11 -07:00
Karl Stolley
8a40b0699a audio: Present download button with tooltip.
Fixes #35636.
2025-08-28 15:20:11 -07:00
Karl Stolley
548c690f83 audio: Register player as clickable message element.
This matters most for Safari of at least v. 18.6, which
allows clicks on the player to bubble up the DOM.
2025-08-28 15:20:11 -07:00
Karl Stolley
cacd73fd8b audio: Present audio player in wrapped element. 2025-08-28 15:20:11 -07:00
Karl Stolley
3787fb3b02 message_list: Process me-messages as having message content. 2025-08-28 15:20:11 -07:00
Karl Stolley
1bcc52c860 cleanup: Remove comments from abandoned approach. 2025-08-28 15:20:11 -07:00
Sayam Samal
a0441b5bcb topic_popover: Update topic URL to permalink for message header popover.
This commit updates the topic URL in the message header topic menu
popover, introduced in feedb6ea2d to a
permalink having a `with` operator attached to it.
2025-08-28 15:08:47 -07:00
Alya Abbott
1e49b01d80 help: Document that current defaults are used when invite is accepted. 2025-08-28 15:07:28 -07:00
Prakhar Pratyush
f52533795b api_docs: Document /remotes/push/e2ee/register endpoint.
This commit documents the `/remotes/push/e2ee/register` endpoint.

We use auth_email="ZULIP_ORG_ID" and auth_api_key="ZULIP_ORG_KEY"
instead of "BOT_EMAIL_ADDRESS" and "BOT_API_KEY".
2025-08-28 11:46:09 -07:00
Prakhar Pratyush
062a736097 api_docs: Prep work to document zilencer endpoints.
Until now we were not documenting bouncer's REST API endpoints.

We plan to document the newly introduced "remotes/push/e2ee/register"
and "remotes/push/e2ee/notify" endpoints.

This commit does the prep work for documenting bouncer endpoints:
* mark the older endpoints related to sending non-E2EE push
  notifications as "intentionally_undocumented" - we'll remove
  them in future.
* the remaining endpoints are marked pending-to-document with
  helpful comments.
2025-08-28 11:46:09 -07:00
Prakhar Pratyush
9785cb4a09 render_curl_example: Remove unused 'auth_email' & 'auth_api_key'.
The 'function' variable in 'APICodeExamplesPreprocessor.generate_text'
matches the pattern of API_ENDPOINT_NAME = r"/[a-z_\-/-{}]+:[a-z]+"

It is always of the form 'endpoint_path:endpoint_method'.

There's no possibility of multiple ':'.

This commit removes the unused code block in `render_curl_example`,
which was trying to get 'auth_email' & 'auth_api_key' from 'function'.
2025-08-28 11:46:09 -07:00
Kislay Verma
67ca49488f tests: Use make_realm to create type-correct realm objects.
Another step in the direction of improving node tests
and using type-correct organic data as much as possible.
2025-08-28 11:35:07 -07:00
Prakhar Pratyush
c604ecb902 push_notifications: Log roundtrip time since worker decided to send.
Adds a log for the end-to-end latency from when the worker decided
to send push notifications & received a success response from bouncer.

Fixes part of #35368.
2025-08-28 11:08:02 -07:00
Lauryn Menard
28035c9743 help: Expand browse & subscribe to a channel mobile tab information.
Expands the mobile tab for "Browse and subscribe to channels" to
include information about subscribing to a channel via a link and
the long-press channel menu.
2025-08-28 10:14:56 -07:00
Lauryn Menard
e5514d575d create-channel: Add test for invalid user ID in subscribers param. 2025-08-28 10:13:02 -07:00
Lauryn Menard
8ee59e9277 api-docs: Revise create channel endpoint documentation. 2025-08-28 10:13:02 -07:00
Lauryn Menard
910ca975ab api-docs: Improve rendering of create channel python example. 2025-08-28 10:13:02 -07:00
Lauryn Menard
224499b58f api-docs: Revise folder_id parameter for adding/updating channels.
Revises the description of the `folder_id` parameters in the
api/create-channel, api/subscribe and api/update-stream endpoints.
2025-08-28 10:13:02 -07:00
Karl Stolley
2660c876fa recents: Align filter tops top left, right sidebars. 2025-08-28 10:11:25 -07:00
Karl Stolley
b71352c4dc inbox: Align filters to left, right sidebars. 2025-08-28 10:11:25 -07:00
Karl Stolley
a5ab61f83a right_sidebar: Eliminate gap between filter, vdots area. 2025-08-28 10:11:25 -07:00
Karl Stolley
545b14abfa right_sidebar: Establish last-item/next-heading concord. 2025-08-28 10:11:25 -07:00
Karl Stolley
4f08718163 sidebars: Add easily adjustable space below sidebar filters. 2025-08-28 10:11:25 -07:00
Karl Stolley
b3fb672b5d sidebars: Bring left, right sidebar tops into concord. 2025-08-28 10:11:25 -07:00
Karl Stolley
176ba669c2 left_sidebar: Zero out space below Views. 2025-08-28 10:11:25 -07:00
Aman Agrawal
a13f4e4832 hash_util: Use user_id instead of email to generate DM emails. 2025-08-28 10:08:36 -07:00
Aman Agrawal
0a264a8d60 people: Add function to URL slug from user_ids.
This is similar to `emails_to_slug` which will removed
from future commits.
2025-08-28 10:08:36 -07:00
Aman Agrawal
f5dc7f41be people: Extract function to convert full name to URL slug. 2025-08-28 10:08:36 -07:00
Shubham Padia
9a0ac354ed starlight_help: Move @types/mdast away from dev dependencies.
@types/mdast was in dev dependencies while it shouldn't have been, we
move that away from dev dependencies and bump the version. We need the
package when running the astro build step.
2025-08-28 10:07:25 -07:00
Shubham Padia
dd0f1e1154 help: Convert last of the loose lists to tight.
We kept these lists loose intentionally due to the nature of the content
in them. But based on
https://chat.zulip.org/#narrow/channel/19-documentation/topic/new.20help.20center.3A.20bullet.20list.20spacing/near/2233272,
we want to keep the behaviour consistent across all lists.

We cannot convert loose lists with tips and tables since removing
the preceding line for tips and tables will break our custom markdown
implementation. Issue tracked in #35533.
2025-08-28 10:07:25 -07:00
opmkumar
ea97d1a77a hotkey: Enable spectators to copy via keyboard in web-public channels.
Fixes #35782.
2025-08-28 10:05:25 -07:00
Mohammad Reza Kianifar
daadf110d9 scheduled_messages: Add support for self-DM identification.
Similar to drafts, identify when a scheduled message will be sent to
the logged-in user. This allows the UI to show 'You' as the header for
self-scheduled messages, improving the user experience.
2025-08-28 10:04:37 -07:00
Mohammad Reza Kianifar
e2d1c233ba get_recipient_ids: Include user ID for self-messages using DM group.
When using direct message groups as the preferred method for 1:1 or
self-messages, the get_recipient_ids function should include the
user ID for self-messages. Without this, the UI cannot detect who
was the recipient of the message.
2025-08-28 10:04:37 -07:00
Aman Agrawal
2671aff7c3 left_sidebar: Allow user to navigation on section headers. 2025-08-28 10:00:59 -07:00