paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-05 22:43:42 +00:00
Code Issues Packages Projects Releases Wiki Activity
15,706 Commits 30 Branches 160 Tags
a3a03bd6a56f86c157c2a8d1cd6ae551111e0b19
Commit Graph

64 Commits

Author SHA1 Message Date
Raghav Jajodia
a3a03bd6a5 mypy: Added Dict, List and Set imports. 
Fixed mypy errors associated with the upgrade.
 2017-03-04 14:33:44 -08:00
Tim Abbott
4e171ce787 lint: Clean up E126 PEP-8 rule. 2017-01-23 22:06:13 -08:00
Rohith Asrk
9088c46e4c templates: Fix filename ending with .html.txt. 
Fixes a part of #3136.
 2017-01-21 22:44:13 -08:00
Tim Abbott
00d48bff7d Digest: Fix URIs for emoji and friends in email links. 
It turns out we were using malformed URLs in the image tags
(containing just a hostname, but no http(s)!) in what we were passing
to the Django templates for our digest/, which resulted in the Django
templates treating these URLs as http.  Gmail recently cracked down on
loading images in HTTP, causing the emoji links to appear broken in
emails Zulip sends.

Fixes #3258.
 2017-01-21 22:25:51 -08:00
Tim Abbott
3f8d4193da lint: Fix % comprehensions being used without a tuple. 2017-01-09 11:45:11 -08:00
Rishi Gupta
f5d5b2525c notifications.py: Change email template file endings from .text to .txt. 
We use .txt for all other emails (i.e. ones that don't go through
notifications.py) in the codebase.
 2017-01-06 10:42:28 -08:00
Tim Abbott
39f0ffdedd Move static/third/gemoji to static/generated/emoji. 
Fixes #1153.
 2016-12-27 20:16:23 -08:00
Robert Hönig
ef3069a5d3 mypy: Convert the isinstances function in /zerver/lib/ to use typing.Text. 2016-12-25 10:33:45 -08:00
Robert Hönig
0917493588 mypy: Convert zerver/lib to use typing.Text. 2016-12-25 10:33:45 -08:00
nikolay
abc2ff4a06 pep8: Fix many rule E128 violations. 
[Tweaked by tabbott to adjust some approaches used in wrapping]
 2016-12-03 13:33:31 -08:00
Rafid Aslam
c5316b4002 lint: Fix E127 pep8 violations. 
Fix pep8: E127 continuation line over-indented for visual indent
style issue.
 2016-12-01 10:23:55 -08:00
paxapy
ff1e97603d context_processors: use a common context for emails. 
Fixes #1611.
 2016-11-08 11:37:16 -08:00
Rishi Gupta
9e6e1a1e69 Remove several instances of datetime.datetime.utcnow(). 
Change to the timezone-aware django.utils.timezone.now() where django is
available.
 2016-11-07 20:13:53 -08:00
Rishi Gupta
9e5ec2fd29 notifications.send_future_email: Use timezone aware times. 
Previous behavior raises an AmbiguousTimeError during daylight savings hour!
 2016-11-07 20:13:53 -08:00
Tim Abbott
b41fc75767 notifications: Remove unused field from template context. 
While one often might want to put the user's name in an email
template, `name` here was the user's full name, not their first name,
and thus reads as quite formal.
 2016-09-08 17:03:00 -07:00
Rishi Gupta
084bc63cad Change Day 2 email to be sent 24 hours after the user signs up. 
Old behavior is to do something tricky that relies on the server being on
Pacific Time and the users being in the US. The goal is to have this message
appear during business hours, since click through rates are higher during
business hours. Our server is now on the East Coast though and our users are
in every timezone, so until we do something smarter this seems like a better
heuristic. We're also trying to cleanse our codebase of non-timezone-aware
datetime.datetime objects.
 2016-08-26 15:59:30 -07:00
Tim Abbott
797a7ef97b notifications: Don't spoof emails as from users by default. 
The previous default configuration resulted in delivery problems if
the Zulip server was authorized in the SPF records for the domains of
all users on the Zulip server.
 2016-08-24 14:10:52 -07:00
Tim Abbott
685d63b6cc notifications: Update digest email link URLs to use realm.uri. 
This is preparation for fully supporting each realm having its own
subdomain in Zulip.
 2016-08-17 22:58:35 -07:00
Tim Abbott
91ad923d80 notifications: Use realm.uri in unsubscribe links. 2016-08-17 22:44:38 -07:00
Tim Abbott
48ed7e2e31 notifications: Use realm_uri for click here link. 2016-08-17 22:19:53 -07:00
Tim Abbott
5f12136e7c notifications: Fix broken one click unsubscribe link. 2016-08-17 22:19:53 -07:00
Tim Abbott
6ef79ac66c notifications: Remove support@zulip.com comment in docstring. 2016-08-17 22:19:53 -07:00
Tim Abbott
4fbb8c3eee templates: Add new context variables to all templates. 
This adds a few new helpful context variables that we can use to
compute URLs in all of our templates:
* external_uri_scheme: http(s)://
* server_uri: The base URL for the server's canonical name
* realm_uri: The base URL for the user's realm

This is preparatory work for making realm_uri != server_uri when we
add support for subdomains.
 2016-08-13 16:27:35 -07:00
Tim Abbott
ed01842f95 notifications: Fix missed message emails with multiple senders. 
Previously, missed message emails with multiple senders would
incorrectly have a "," outside the quoted sender name part of the from
address string, resulting in confusing email output.
 2016-08-12 12:28:06 -07:00
Eklavya Sharma
07e36d87a2 Remove return where no return value is expected. 
zerver.lib.notifications.send_future_email has return type None.
So replace `return send_future_email(...` by `send_future_email(...`.
 2016-07-22 11:14:33 -07:00
Tim Abbott
e876f12b83 settings: Extract settings.WELCOME_EMAIL_SENDER. 2016-07-19 15:28:41 -07:00
Tim Abbott
7725c62892 Use VERBOSE_SUPPORT_OFFERS in day1 emails. 2016-07-19 15:28:41 -07:00
Steve Howell
9d7716f368 Add message.topic_name() helper function. 
This little helper will facilitate adding a new Topic
table in the future.
 2016-07-14 09:54:56 -07:00
Eklavya Sharma
4f633bcd0b zerver/lib/notifications.py: Fix string encoding/decoding. 
Correctly encode and decode strings in convert_html_to_markdown.
It wasn't possible to use universal_newlines=True since
Popen.communicate doesn't encode/decode strings correctly on
python 2.
 2016-07-13 16:00:46 -07:00
Umair Khan
f15dfc69fb Make code Python 3 compatible. 
Make convert_html_to_markdown function Python 3 compatible.
 2016-07-13 11:24:18 -07:00
Umair Khan
8538ba8ea8 Remove do_send_missedmessage_events function. 2016-07-08 10:58:25 -07:00
Umair Khan
06355105f5 Missed message emails should come from user email. 
Fixes #448
FIxes #612
 2016-07-08 10:58:25 -07:00
Eklavya Sharma
9d2a539aaa zerver/lib/notifications.py: Add hints for mypy. 
Add type hints for mypy using isinstance in assert and if.
 2016-07-07 10:02:08 -07:00
Umair Khan
33e6b471e2 Fix spelling of mesage_count_by_recipient_subject. 2016-06-22 09:02:35 -07:00
Eklavya Sharma
a2668a2853 zerver/lib/notifications.py: Fix an annotation. 2016-06-21 02:20:36 +05:30
Eklavya Sharma
78565a96c9 zerver/lib/notifications.py: Fix string annotations. 2016-06-15 15:25:28 -07:00
Eklavya Sharma
5a5934a76f Fix annotations clashing with Message model fields. 2016-06-13 20:01:02 +05:30
Eklavya Sharma
c654c4032d zerver/models.py: Annotate get_display_recipient. 
get_display_recipient's annotation clashes with other wrong annotations.
Fix those wrong annotations.
Since get_display_recipient returns a Union, use isinstance checks and
casts to make mypy checks succeed.
 2016-06-12 23:34:57 +05:30
Conrad Dean
e7f0698884 Annotate zerver/lib/notifications.py. 2016-06-03 23:45:29 -07:00
Tim Abbott
7fd2956f29 clear_followup_emails_queue: Rename confusing local variable. 2016-06-03 23:45:29 -07:00
Tim Abbott
762a3188ee Fix missing whitespace after # in comments. 2016-05-02 22:10:47 -07:00
Varshit
4e1060076d Purge 'from typing import *' from zerver/. 
This is a partial implementation of #636.
 2016-04-07 14:07:07 -07:00
Tim Abbott
2059f650ab Add PEP-484 type annotations to zerver/lib/. 2016-04-03 15:40:23 -07:00
Tim Abbott
5bacda3662 python3: Fix usage of .keys()/.values() to handle iterators. 
This fixes the places where we use the result of .keys(), .items(),
and .values() that wouldn't work with an iterator to wrap them with
list().
 2016-01-26 21:11:25 -08:00
Tim Abbott
6528b18ad3 Switch all urllib/urlparse usage to six.moves.urllib. 
This provides Python 2+3 compatibility for our use of urllib.

Also add a test to avoid future regressions.
 2016-01-26 21:09:43 -08:00
Tim Abbott
f3783fb4a1 Apply Python 3 futurize transform libfuturize.fixes.fix_print_with_import. 2015-11-01 09:26:16 -08:00
Tim Abbott
43abd83d1c Apply Python 3 futurize transform lib2to3.fixes.fix_ws_comma. 2015-11-01 09:26:14 -08:00
Tim Abbott
06f6ee6566 Apply Python 3 futurize transform lib2to3.fixes.fix_idioms. 2015-11-01 09:25:47 -08:00
Tim Abbott
d0afb75619 Clarify documentation for SMTP delivery code. 
(imported from commit 3b13f39fd56e9c381201911479c1326883c38445)
 2015-08-21 10:33:36 -07:00
David Roe
3f7cb34b00 enterprise => voyager 
(imported from commit 04be792bb480d5e5db1c91d296d1000cf1682571)
 2015-08-21 10:33:35 -07:00