paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-22 07:21:23 +00:00
Code Issues Packages Projects Releases Wiki Activity
28,509 Commits 30 Branches 160 Tags
a4b51a33f802aae73c6c6ad2aec84acbe7af9340
Commit Graph

3210 Commits

Author SHA1 Message Date
RobbieClarken
b3a6c0a253 zerver/tests: Test currently_used_upload_space function. 2018-05-15 10:50:38 -07:00
RobbieClarken
efc63d4ca0 zerver/tests: Test S3 file upload with undefined content type. 2018-05-15 10:42:10 -07:00
RobbieClarken
b9fff04f39 zerver/tests: Add test for resize_emoji for images that need resizing. 2018-05-15 10:42:10 -07:00
RobbieClarken
69a5ce102f zerver/tests: Remove unecessary re-open on files in tests. 
The get_test_image_file helper function returns a file handle so we can
call the read method on this directly.
 2018-05-15 10:42:10 -07:00
RobbieClarken
f34d9dc910 zerver/tests: Test get_realm_for_filename when filename doesn't exist. 2018-05-15 10:42:10 -07:00
Baron Chandler
52d53f4a81 test_subs: Ensure gather_subscriptions_helper excludes deleted streams. 2018-05-15 10:11:32 -07:00
Tim Abbott
a2ed06314d send_test_email: Throw an error if email not configured. 
This should help minimize confusion when folks try to use this before
properly configuring outgoing email.

Thanks to Bruce Eckel for the report.
 2018-05-14 12:02:36 -07:00
RobbieClarken
2cca5dc79f zerver/tests: Test upload when mimetype is supplied as a query param. 2018-05-14 10:58:24 -07:00
Joshua Pan
231b487bca tests: Cover check_config() in zerver/lib/management.py. 
Add a comment to code to clarify what the config check does.
 2018-05-14 10:46:21 -07:00
Darshan Markandaiah
607cab2a53 tests: Add 100% test coverage to zerver/apps.py. 
Tweaked by tabbott to rename to test_cache.py and remove the
sender_name argument (Since it was kinda confusing).
 2018-05-14 10:36:10 -07:00
Eeshan Garg
5c0d4660c1 models: Add history_public_to_subscribers to Stream.to_dict(). 
This commit also updates all the relevant parts where this attribute
could be useful, e.g. payloads for user subscriptions.
 2018-05-13 09:15:07 -07:00
Shubham Padia
295fcb8536 models: Add is_announcement_only to stream_dict in actions.py. 
Adds `is_announcement_only` to `stream_dict`s in order to access
the property in the frontend.
 2018-05-13 09:11:51 -07:00
Shubham Padia
897ed17f0c api: Allow realm_admins to make a stream announcement_only. 2018-05-13 09:11:51 -07:00
Shubham Padia
bb8577ba94 stream: Only realm admins can post to an announcement_only streams. 
If a non-admin tries to post to an announcement_only stream, error
message will be shown.
 2018-05-13 09:11:51 -07:00
Vishnu Ks
08d20dce23 docs: Cover the missing case in DocPageTest. 2018-05-13 08:56:04 -07:00
Vishnu Ks
99186952f6 integrations: Make integration_doc endpoint work only on ajax. 2018-05-13 08:56:04 -07:00
Aditya Bansal
5416d137d3 zerver/tests: Change use of typing.Text to str. 2018-05-12 15:22:39 -07:00
Aditya Bansal
2f3b2fbf59 zerver/tests: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
Tim Abbott
81e17c7d47 test_i18n: Stop using six.moves for SimpleCookie. 
This requires a 'type: ignore' because of a typeshed bug.
 2018-05-09 20:45:45 -07:00
Tim Abbott
4c1777f146 tests: Add a good set of unit tests for UserActivityInterval. 
This system was written years ago and has been working well the whole
time, but having unit tests for it will help future developers in
understanding what the intent is.
 2018-05-09 20:45:02 -07:00
Tim Abbott
fba45bb9d3 archive: Add functions for accessing web-public streams. 
These will be helpful for variable upcoming projects to support the
web-public streams feature.
 2018-05-08 12:12:15 -07:00
Tim Abbott
f24630fd4a events: Include data for whether push notifications are enabled. 
This is primarily useful for the mobile app, but could also be used to
control whether we display push-notifications related settings to
users in the web UI.
 2018-05-08 11:45:13 -07:00
Eeshan Garg
34d1b0ebf1 webhooks: Add helper to extract and validate HTTP event headers. 
This is a part of our efforts to close #6213.
 2018-05-05 15:48:37 -07:00
Tim Abbott
956bd74905 attachments: Send events for attachment updates. 
We send add events on upload, update events when sending a message
referencing it, and delete updates on removal.

This should make it possible to do real-time sync for the attachments
UI.

Based in part on work by Aastha Gupta.
 2018-05-04 16:22:27 -07:00
Tim Abbott
69c4645bd2 attachments: Stop fetching attachments in / endpoint. 
We only use this data in a rarely-used settings screen, and it can be
large after years of posting screenshots.

So optimize the performance of / by just loading these data when we
actually visit the page.

This saves about 300ms of runtime for loading the home view for my
user account on chat.zulip.org.
 2018-05-04 16:22:26 -07:00
Tim Abbott
59d3fefc07 bots: Improve performance of fetching core bot data. 
This eliminates the need to call user_ids_to_users inside the
get_service_dicts_for_bots code path, saving a database query.

This completes my refactor to fix backend performance issues in this
code path.  Previously, our messy layering of queries that resulted in
Zulip doing work even if none of the bots actually had Services or
config_data.
 2018-05-04 13:44:43 -07:00
Vishnu Ks
733da0ac07 settings: Fix 500 when trying to change email to disposable email. 
Fixes #9240
 2018-05-04 10:52:38 -07:00
Tim Abbott
508dc5b6ed decorators: Add new decorators for guest users. 
These decorators will be part of the process for disabling access to
various features for guest users.

Adding this decorator to the subscribe endpoint breaks the guest users
test we'd just added for the subscribe code path; we address this by
adding a more base-level test on filter_stream_authorization.
 2018-05-04 10:25:52 -07:00
Tim Abbott
8b26f912af streams: Limit access to public streams for guest users. 
With most of the tests tests written by Shubham Dhama.
 2018-05-04 09:47:58 -07:00
Tim Abbott
7cbff8b521 push registration: Use standard error message for auth problems. 
This avoids adding an unnecessary new translated string.
 2018-05-04 09:04:39 -07:00
Tim Abbott
43098a6f7c zilencer: Add automated signup system for push notifications. 
Based on an initial version by Rishi Gupta.

Fixes #7325.
 2018-05-03 21:27:49 -07:00
Tim Abbott
51517fa188 request: Add new str_validator validator type. 
This is helpful for cases where an argument is supposed to be a normal
string, and we want to use a Zulip validator function to do basic
things like check its length.
 2018-05-03 21:11:02 -07:00
Tim Abbott
f2e84f25a0 management: Refactor checkconfig code to live in library. 
This makes it possible to call this from other management commands.
 2018-05-03 21:11:02 -07:00
Tim Abbott
ad0cfb3512 validators: Add check_string_fixed_length. 
This will be useful in some upcoming work on zilencer.
 2018-05-03 14:30:03 -07:00
Tim Abbott
594451707d check_capped_string: Clean up corner case. 
We were rejecting strings of length equal to the max.

While we're at it, fix the unnecessary period in the error message,
which doesn't align with similar validators.
 2018-05-03 14:30:03 -07:00
Armaan Ahluwalia
8fe54a533a test_home: Change requiring pygments.css to requiring app-styles.js. 
This commit changes the tests based on the fact that pygments.css
will no longer be found in the template during testing. pygemnts.css
is being compiled by webpack under app-styles and so we look for the
stubentry for app-styles instead.

Tweaked by tabbott to do a cleaner test.
 2018-05-02 17:18:11 -07:00
Aditya Bansal
c38b70566c views/archive.py: Make 'StreamDoesNotExist' return a error msg page. 2018-05-02 15:23:33 -07:00
Aditya Bansal
5d7907b59f public_archives: Add basic infra for displaying topics. 
We add very basic infra so that we can view any discussion which
happened under a topic of a global public stream without
authorization.
 2018-05-02 15:23:33 -07:00
Umair Khan
29e3a1d576 two_factor: Add templates for 2-factor-auth setup. 
Note from Tim: We'll likely need to do some work on the strings in
these before translating, so I removed some translation tags.
 2018-05-02 15:20:49 -07:00
novokrest
036bc120c3 outgoing_webhook: Extend process_success() return value to tuple. 
Change return value type of OutgoingWebhookServiceInterface.process_success
to 2-elements tuple as (success_message, failure_message)
 2018-05-02 11:57:08 -07:00
Tim Abbott
a0e8a37e7f topics: Fix get_topics_backend logic for zephyr realms. 
This removes a check on invite_only, that should have been a check on
history_public_to_subscribers.  In addition to fixing a bug for zephyr
realms, it also makes "more topics" work correctly for realms using
the new settings for stream history being public to subscribers.
 2018-05-02 09:02:57 -07:00
Rohitt Vashishtha
2f6da2661f push_notifications: Format blockquotes properly in text_output. 
New output is of the format:

Hamlet said:
> Polonius said:
> > This is the.
> > Second layer of nesting.
> First layer of nesting.

Fixes #9251.
 2018-05-02 08:57:17 -07:00
Vishnu Ks
8705ac1091 portico: Add noindex tags for non root realms. 
There may be further work required for the /integrations pages.
 2018-05-01 15:28:30 -07:00
Rohitt Vashishtha
6c96ba79e0 test_bugdown: Fix ignore-testcase feature for markdown_test_cases. 
We accidentally were 'return'ing on encountering an ignored case, and thus
exiting the loop, not running further testcases.
 2018-05-01 09:24:15 -07:00
Angelika Serwa
f4f64243dd custom_profile_fields: Support changing the sort order of the fields. 
Tweaked by tabbott for variable naming and the URL.

Closes #8879.
 2018-04-30 18:17:41 -07:00
Tim Abbott
de30474ddd test_custom_profile_data: Don't do a database query on import. 
This is a general code cleanlyness improvement.

While we're at it, we combine together two test classes that didn't
have a particularly good reason for existing.
 2018-04-30 10:57:23 -07:00
Yashashvi Dave
0a9fbe2ce6 zerver/tests/test_custom_profile_data.py: Refactor tests. 
Refactor tests to include generic function for invalid
assertion and remove repetitive assertion code.
 2018-04-30 10:53:23 -07:00
Yashashvi Dave
a97a00a4c6 custom fields: Replace field id with field name in error message. 2018-04-30 10:53:23 -07:00
Yashashvi Dave
0d7d94d0db custom fields: Add support for custom URL field type. 2018-04-30 10:53:23 -07:00
Yashashvi Dave
4033f210af custom fields: Add support for custom date field type. 2018-04-30 23:04:25 +05:30