This follow-up commit replaces the current left sidebar channel list
filter input implementation with the redesigned input component.
Note: This commit removes `clear_search` method from `stream_list.ts`,
since the `.input-button` onclick handler over at `inputs.ts` handles
the clearing of the filter input fields by sending an empty text input
event. This input event triggers the filter update handler of the
module, in this case the `update_streams_for_search` function and
resets the filter list, eliminating the need for a separate per-module
input clearing/resetting workflow.
Fixes part of #34476.
Firstly, this commit modifies the styling of the vdots icon in the user
list header, to match the height of the user list filter input. Other
than that, this commit also makes some non-visual structural changes
to the icon-related code for code quality improvements.
This follow-up commit replaces the current right sidebar user list
filter input implementation with the redesigned input component.
Fixes part of #34476.
This commit serves as the base for the ongoing effort to standardize
redesigned input elements throughout the Zulip Web UI. It introduces a
new Handlebars partial block for inputs, located at
web/templates/components/input.hbs.
The partial can be used with the partial block syntax: {{#> input}},
allowing contributors to pass in the input element as a template. This
approach wraps the input with a consistent structure that includes
support for an icon and an action button. It also applies the necessary
styling to ensure visual and functional consistency across the web UI.
This commit also implements the filter input component at
/devtools/inputs/ showroom page for design discussions and prototyping.
Instead of changing the height of the button subheader depending
on the width of the modal, which was fiddly and error prone, we now
let grid determine the height of the button subheader, and determine
the height of the body through javascript resize calculations.
This commit fixes code to correctly show the long group
names by clipping them and showing ellipsis in group rows
in left panel and in the header shown in right section.
Group names are handled in a different way than stream
names because we need to show deactivated icons as well
for stream names.
Previously, when a topic is mentioned, the server generated a
permalink using the earliest accessible message of the topic.
This commit updates it to rather use the latest message of the
topic.
This commit fixes a bug where clicking the copy icon in the
'#copy_email_address_modal' did not copy the email address
displayed to the clipboard.
It was because we didn't set the 'text' option to specify
the explicit text to copy.
Fixes: #35062.
Changes the tab for the current web app instructions to be "Via
left sidebar" and adds a tab for web app instructions "Via personal
settings".
Also, includes a tip for resetting a channel's notifications to the
default via hovering over the channel name in the notifications
table and clicking the icon to reset to default notifications.
Fixes#34862.
In the `zulip.yaml` file, the commit
54b5182 - user_groups: Add API support to reactivate a user group
was merged without updating the feature level to the correct format.
This commit fixes that feature level.
This part of the UI was removed from the sidebar in commit
2feee9d756. There is still unreachable
codeblock inside right sidebar.
This commit removes the unreachable code.
Previously, we included channel, topic, sender name and search
qeries (if present) in the empty feed banner.
With this commit, we will now not include channel, topic and sender
name and we only display the search queries when there are excluded
stop words.
Fixes: #34872
Otherwise, this fails on `match.group(1)` as there is no match group.
The server would ideally respond with a 521 or 556 code[^1] on initial
connection, but aiosmtpd does not provide that option.
[^1]: https://www.rfc-editor.org/rfc/rfc7504
This fixes an accidental change introduced in #32578.
Forwarding a message and choosing DM should result in
an empty recipient box instead of showing current
recipients.
This commit fixes the kbd element text being centered in dark theme
but not in light theme. Aligns text for all kbd elements not just
in dark theme.
Fixes:zulip#35059.
We reset the internal state while opening the stream settings
overlay to reflect that "Subscribed" tab will be selected.
We did set show_subscribed value to "True" but did not
set show_not_subscribed value to "False".
Due to this opening the overlay, after closing the overlay
when "Not subscribed" tab was selected, resulted in left
panel being shown empty with "Subscribed" tab selected
even when there were subscribed streams because both
show_subscribed and show_not_subscribed were set to "True".
This commit fixes it by setting show_not_subscribed to
"False" as well when resetting the state.
This renames the function to `contains_no_partial_conversations`. The
function initially was created to determine whether its appropriate to
collapse recipient/sender headings. Since then it has many other use
cases, so it's renamed to clearly describe what it does instead.
When there is only one user group, the tooltip appears on the upper side
of the "group-row" and gets hidden.
This commit sets `overflow: visible` which is default value, causing the
tooltip position to invert when there is only one user group.
The "sub_unsub_status" spinner was inside the div with the "check" class
, causing the tooltip to appear over the spinner, which should only be
visible on the check icon.
This commit moves the "sub_unsub_status" spinner div outside, ensuring
the tooltip is now visible only when hovering over the check icon.
