Commit Graph

158 Commits

Author SHA1 Message Date
apoorvapendse
edf6b7389f message_row: Add cursor:pointer for edit notices.
Fixes: https://chat.zulip.org/#narrow/channel/137-feedback/topic/.60cursor.3A.20pointer.60.20applied.20to.20whole.20message.20content/near/2172361
2025-05-13 09:51:16 -07:00
apoorvapendse
5a21f42000 message_row: Remove cursor:pointer for messagebox.
Related article: https://adamsilver.io/blog/buttons-shouldnt-have-a-hand-cursor/

Fixes: https://chat.zulip.org/#narrow/channel/137-feedback/topic/.60cursor.3A.20pointer.60.20applied.20to.20whole.20message.20content/with/2167059
2025-05-09 09:05:32 -07:00
Karl Stolley
1f19ea6454 message_feed: Remove unnecessary opacity value. 2025-04-16 13:17:19 -07:00
Karl Stolley
3278fc36ca variables: Correct instances of misspelled 'message'. 2025-04-16 13:17:19 -07:00
Sayam Samal
b5e41e1ca0 css: Use CSS variable for bookend and date row spacer lines. 2025-04-16 10:44:51 -07:00
Sayam Samal
71609a3032 message_row: Consolidate date row and bookend styles to message_row.css. 2025-04-16 10:44:51 -07:00
Anders Kaseorg
f2a171a881 Revert "css: Remove unused transition property."
This reverts commit 7d08f32ebb.

The commit message is factually incorrect, and the change broke our
fade-out transitions.  visibility can be transitioned, and there is a
specific rule for what that means.  This is critical for transitioning
opacity in the fade-out direction: if you fail to also transition
visibility, then the element disappears immediately regardless of
opacity.

https://developer.mozilla.org/en-US/docs/Web/CSS/visibility#interpolation

Signed-off-by: Anders Kaseorg <anders@zulip.com>
2025-04-03 10:59:08 -07:00
Aman Agrawal
7d08f32ebb css: Remove unused transition property.
`visibility` cannot be animated since it is a boolean.

This fixes composition failure error in Chrome dev tools when
these animations are triggered that the animation has
no visible change.
2025-04-03 10:44:33 -07:00
apoorvapendse
82f4ec0d6c message_row: Restore copy button in edit textbox.
Fixes: https://chat.zulip.org/#narrow/channel/9-issues/topic/missing.20copy.20button.20for.20View.20Original.20Message/near/2142823
2025-04-02 13:47:22 -07:00
Karl Stolley
a1bba7a453 message_row: Better flexibly align hover controls. 2025-04-02 09:43:58 -07:00
Karl Stolley
11fdd5f005 message_row: Restore padding to senderless content box. 2025-04-02 09:43:58 -07:00
Karl Stolley
46b33f0d26 message_row: Better target first children. 2025-04-02 09:43:58 -07:00
Karl Stolley
465971171d rendered_markdown: Adjust content blocks for link focus ring. 2025-04-01 17:47:06 -07:00
ubaidrmn
382a828eec message_edit: Fix stale syntax upon cancelling upload in preview.
Previously, canceling an upload in preview mode &
returning to editing left the syntax unchanged
(e.g., still showing "Uploading"). This happened
because the `replaceFieldText` function does not
work when the text area's display is none.

To fix this, instead of hiding the textarea in
preview mode, we use a grid to overlap it with
the preview container. This is the same thing we
are doing in the compose box. We have also added
css to ensure the textarea remains hidden behind
the transparent preview container
in preview mode.
2025-03-25 11:31:45 -07:00
Aman Agrawal
8858f03847 compose: Revert send button color to that in 9.x.
This reverts commits 9501082e99 and 
a8cfd2fb04.
2025-03-19 09:00:49 -07:00
Karl Stolley
7f8899bf99 message_edit: Preserve width of Save button when showing spinner. 2025-03-18 13:15:10 -07:00
Tim Abbott
29f3acaf1e message_edit: Use brand colors for save button.
Matching the blue/info color that we're using for the send button
hasn't felt good.
2025-03-17 14:15:12 -07:00
Aman Agrawal
5c1bba369d message_list_hover: Optimize code for show edit message icon.
Doing a lot of DOM manipulation on message hover leads to
tooltips being not hidden / displayed when they should be.

This commit is an attempt to optimize that code to do minimal updates.
2025-03-17 11:00:04 -07:00
Aman Agrawal
49a9197c52 compose: Use info colors for send button. 2025-03-17 10:23:48 -07:00
Karl Stolley
42e1b104e2 action_buttons: Remove bottom margin from Bootstrap. 2025-03-14 13:00:54 -07:00
Karl Stolley
4dfa0c1b45 action_buttons: Display only a focus-visible ring. 2025-03-14 13:00:54 -07:00
Karl Stolley
56e5a6237e action_buttons: Match height, width to Vlad's specifications. 2025-03-14 13:00:54 -07:00
Anushrut pandit
3d9cbd5bd7 message_row: Fix focus ring cutoff near date rows.
In direct messages, the blue message focus ring could, at certain zoom
levels, be clipped near date rows.

The cause was a redundant background-color on .date_row interacting
badly with zoom. We previously debugged this problem more broadly and
fixed it in #25806, but missed this redundant declaration.

Fixes #33571.
2025-03-14 12:48:50 -07:00
Aman Agrawal
4029d80c01 compose: Use standard primary button colors for compose send button. 2025-03-14 10:07:05 -07:00
harshbansal8705
f1e6371bf8 message_editing: Fix unclickable area in bouncing "...".
The bug occurred because clicking on .message-editing-animation was
not triggering the click on .edit-notifications. This commit prevents
this behaviour by setting its property pointer-events to none.

Fixes: #33950
2025-03-13 17:06:47 -07:00
Karl Stolley
4454811191 message_view: Better tolerate different opening Markdown elements. 2025-03-13 14:42:14 -07:00
Karl Stolley
5bf38e30e7 message_edit: Match button height to compose Send button. 2025-03-11 12:30:48 -07:00
Karl Stolley
4b4dc6b556 message_edit: Allow Save/Cancel buttons to properly size and flex. 2025-03-07 15:24:24 -08:00
evykassirer
674d26a66b message_row: Remove stale CSS for zulip-icon-more-vertical.
This was introduced in 5d293c82cd but shortly after
60aa58dfb9 renamed the use of zulip-icon-more-vertical
to zulip-icon-more-vertical-spread, so the CSS classname is
no longer being used there.

See also, the TODO from 60aa58d.
2025-03-04 23:08:35 -08:00
Karl Stolley
7fde5fd0a4 message_area: Hide action icons based on container query. 2025-03-04 16:00:03 -08:00
Karl Stolley
45f2e239b9 message_area: Establish message-lists container. 2025-03-04 16:00:03 -08:00
Anders Kaseorg
e381dfd448 styles: Remove obsolete ‘transition: none …’ workaround.
https://github.com/kristerkari/stylelint-high-performance-animation/issues/216
was fixed upstream.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
2025-03-04 15:30:11 -08:00
Karl Stolley
1f8b2b9046 stars: Placehold container width in local echo. 2025-02-25 15:53:26 -08:00
Tim Abbott
7f391b8530 css: Move message_length_toggle styles to message_row.css.
The main goal is to have it in the right file, but also it doesn't
need to be nested as it was.
2025-02-25 12:26:57 -08:00
Tim Abbott
e1ce78770a css: Consolidate bookend styles. 2025-02-25 12:26:57 -08:00
Aman Agrawal
f5dfc43ce9 bookend: Only show links on the last bookend.
Fixes #33060.
2025-02-25 12:26:57 -08:00
Karl Stolley
509a71a666 message_row: Mock available icons to prevent post-echo reflow. 2025-02-20 10:26:36 -08:00
opmkumar
2a15da47d9 message_edit: Show typing indicator for message editing.
This commit adds typing indicators for message editing in stream
as well as in dm, if the send typing notification
for corresponding is enabled.

Based on earlier work in #28585.

Co-authored-by: Rohan Gudimetla <rohan.gudimetla07@gmail.com>

Fixes #25719.
2025-02-12 15:08:56 -08:00
Karl Stolley
e352ab628c message_row: Refine grid for better-fitting action icons. 2025-02-12 13:54:52 -08:00
Karl Stolley
eda9b1a271 me_messages: Improve grid for me-message alignment. 2025-01-22 16:18:31 -08:00
Karl Stolley
1878758baf message_row: Prevent avatar margin from shifting grid row. 2025-01-22 16:18:31 -08:00
Karl Stolley
38c6b82022 message_row: Refine action-button layout to better scale. 2025-01-22 16:18:31 -08:00
Karl Stolley
90279af1ea action_buttons: Remove noop font-size declaration.
A 16px conversion at 16px/1em is unnecessary, and there are no
other font-size declarations in the area. So the base font-size
should be inherited as expected, allowing the button icons to
scale.
2025-01-22 16:18:31 -08:00
Karl Stolley
0d0aaa8586 compose: Introduce scrolling buttons in gridded layout. 2025-01-14 15:52:02 -08:00
whilstsomebody
f1dd8d88c9 compose: Add background and border colors for message limit.
Added colors to notify users when the message length is near
the limit or has exceeded it. Used distinct colors for each
case to provide clear feedback.

Fixes: #32171.
2025-01-07 17:57:15 -08:00
Anders Kaseorg
cac3bca409 dependencies: Upgrade JavaScript dependencies.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-11-27 09:54:56 -08:00
Sayam Samal
543a6c51dc bootstrap: Rename btn-* -> button-* classes.
This commit is a part of the efforts to rename btn-related classes
and variables to align with Zulip's no-abbreviations policy and
streamline the search results.
2024-11-14 12:03:36 -08:00
Sayam Samal
ef929efa1f message_edit: Rename disable-btn class.
This commit is a part of the efforts to rename btn-related classes
and variables to align with Zulip's no-abbreviations policy and
streamline the search results.
2024-11-14 12:03:36 -08:00
Anders Kaseorg
f023fa6fc0 styles: Be specific about which properties are transitioned.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-10-23 14:56:39 -07:00
Shubham Padia
7a0a71b7d1 message_edit: Use display: grid instead of relative positioning.
Fixes #31750.
The control buttons of the edit box were flickering b/w default cursor
and pointer cursor after c1d155d923.
The addition of `position: relative` to `.edit-content-container` was
causing that. We've now added a div to apply position:relative to, this
div does not have any edit controls in it's children.
2024-09-30 17:40:37 -07:00