This reverts commit 7d08f32ebb.
The commit message is factually incorrect, and the change broke our
fade-out transitions. visibility can be transitioned, and there is a
specific rule for what that means. This is critical for transitioning
opacity in the fade-out direction: if you fail to also transition
visibility, then the element disappears immediately regardless of
opacity.
https://developer.mozilla.org/en-US/docs/Web/CSS/visibility#interpolation
Signed-off-by: Anders Kaseorg <anders@zulip.com>
`visibility` cannot be animated since it is a boolean.
This fixes composition failure error in Chrome dev tools when
these animations are triggered that the animation has
no visible change.
Previously, canceling an upload in preview mode &
returning to editing left the syntax unchanged
(e.g., still showing "Uploading"). This happened
because the `replaceFieldText` function does not
work when the text area's display is none.
To fix this, instead of hiding the textarea in
preview mode, we use a grid to overlap it with
the preview container. This is the same thing we
are doing in the compose box. We have also added
css to ensure the textarea remains hidden behind
the transparent preview container
in preview mode.
Doing a lot of DOM manipulation on message hover leads to
tooltips being not hidden / displayed when they should be.
This commit is an attempt to optimize that code to do minimal updates.
In direct messages, the blue message focus ring could, at certain zoom
levels, be clipped near date rows.
The cause was a redundant background-color on .date_row interacting
badly with zoom. We previously debugged this problem more broadly and
fixed it in #25806, but missed this redundant declaration.
Fixes#33571.
The bug occurred because clicking on .message-editing-animation was
not triggering the click on .edit-notifications. This commit prevents
this behaviour by setting its property pointer-events to none.
Fixes: #33950
This was introduced in 5d293c82cd but shortly after
60aa58dfb9 renamed the use of zulip-icon-more-vertical
to zulip-icon-more-vertical-spread, so the CSS classname is
no longer being used there.
See also, the TODO from 60aa58d.
This commit adds typing indicators for message editing in stream
as well as in dm, if the send typing notification
for corresponding is enabled.
Based on earlier work in #28585.
Co-authored-by: Rohan Gudimetla <rohan.gudimetla07@gmail.com>
Fixes#25719.
A 16px conversion at 16px/1em is unnecessary, and there are no
other font-size declarations in the area. So the base font-size
should be inherited as expected, allowing the button icons to
scale.
Added colors to notify users when the message length is near
the limit or has exceeded it. Used distinct colors for each
case to provide clear feedback.
Fixes: #32171.
This commit is a part of the efforts to rename btn-related classes
and variables to align with Zulip's no-abbreviations policy and
streamline the search results.
This commit is a part of the efforts to rename btn-related classes
and variables to align with Zulip's no-abbreviations policy and
streamline the search results.
Fixes#31750.
The control buttons of the edit box were flickering b/w default cursor
and pointer cursor after c1d155d923.
The addition of `position: relative` to `.edit-content-container` was
causing that. We've now added a div to apply position:relative to, this
div does not have any edit controls in it's children.