Tim Abbott
693b9110df
Fix weird import of get_user_profile_by_email from decorator.py.
2016-02-03 19:29:44 -08:00
Tim Abbott
23705f4f16
Remove duplicate self._log_data initialization.
2016-02-03 19:29:07 -08:00
Tim Abbott
df1670ef59
Fix various float initialization to use 0.0 instead of 0.
...
This is needed to type-check these values.
2016-02-03 19:29:07 -08:00
Tim Abbott
fc02ea9f67
do_add_default_stream: Fix return value if stream exists.
...
Discovered using mypy static type checker.
2016-02-03 19:28:48 -08:00
Tim Abbott
e6e2584c5a
test_runner: Cleanup fast_tests_only types.
2016-02-03 19:25:19 -08:00
Tim Abbott
ee6062691a
Fix missing None in check_none_or return.
2016-02-03 19:25:18 -08:00
Tim Abbott
f03bfc5816
Fix missing prefix cache error output.
2016-02-03 19:25:18 -08:00
Tim Abbott
8654b57c7b
bugdown: Move definition of current_node above set_text function using it.
2016-02-03 19:25:18 -08:00
Tim Abbott
8dcdb1d8a8
actions: Remove duplicate import of RealmFilter.
...
Apparently we were importing it twice in the same import statement.
Discovered using mypy.
2016-02-03 19:25:17 -08:00
Tim Abbott
e9f39922a0
notify_subscriptions_*: Fix use of leaked stream variable.
...
While I believe this actually produced correct output since users are
always subscribed to streams within their realm, this code was
definitely wrong.
Discovered using the mypy type-checking tool.
2016-02-03 19:25:17 -08:00
Tim Abbott
aad3bff193
Harden style rule for % comprehensions and fix existing errors.
2016-02-02 23:08:19 -08:00
Tim Abbott
5bacda3662
python3: Fix usage of .keys()/.values() to handle iterators.
...
This fixes the places where we use the result of .keys(), .items(),
and .values() that wouldn't work with an iterator to wrap them with
list().
2016-01-26 21:11:25 -08:00
Tim Abbott
f5de149976
python3: specify explicit sorting algorithm for subscriptions.
2016-01-26 21:11:25 -08:00
Tim Abbott
bd0918cd5a
python3: Use zip from the six.moves package.
2016-01-26 21:11:24 -08:00
Tim Abbott
757e89260e
Migrate use of StringIO to Python 2+3 compatible six.moves.cStringIO.
...
And add a check for additional usage of the original StringIO module.
2016-01-26 21:09:43 -08:00
Tim Abbott
1f44417fc1
Switch to using Python 3 style division everywhere.
...
Also add testing for this to our Python 3 compatibility test suite.
2016-01-26 21:09:43 -08:00
Tim Abbott
6528b18ad3
Switch all urllib/urlparse usage to six.moves.urllib.
...
This provides Python 2+3 compatibility for our use of urllib.
Also add a test to avoid future regressions.
2016-01-26 21:09:43 -08:00
Tim Abbott
700055c194
Apply modernize transform libmodernize.fixes.fix_file.
...
This replaces use of file() with open() which is python 3 compatible,
and also adds it to our python 3 support test suite.
2016-01-26 21:09:42 -08:00
Tim Abbott
83dd51dcd6
Remove now-obsolete get_message_by_id_dbwarn transition code.
2016-01-26 21:05:11 -08:00
Tim Abbott
eecd1513b3
Don't access/store full Client objects in Tornado queue servers.
...
At present, we only do a few simple checks on the client type inside
the event system, and this saves database/memcached queries.
Note that this preserves the structure of the marshalled name in
to_dict/from_dict as client_type to avoid an unnecessary migration.
2016-01-26 21:04:32 -08:00
Tim Abbott
e3b6bfa3ca
Remove code for pickle event queue store.
...
Since we've had the JSON store in all environments for some time, we
no longer need this legacy code.
2016-01-26 20:59:34 -08:00
Tim Abbott
f6073d1708
Move HTTPResponse construction out of event_queue.py.
2016-01-26 20:59:19 -08:00
Tim Abbott
a9bf4b4cc7
Store the client name for the current handler in ClientDescriptor.
2016-01-26 20:58:01 -08:00
Tim Abbott
c7e3c3ce38
Look up client descriptors by handler_id.
...
Previously, client descriptors were referenced directly from the
handler object. Once we split the Tornado process into separate queue
and connection servers, these will no longer be in the same process,
so we need to reference them by ID instead.
2016-01-26 20:57:25 -08:00
Tim Abbott
ea6211c041
Allocate handler ids in AsyncDjangoHandler setup process.
2016-01-26 20:56:53 -08:00
Tim Abbott
ae760a351e
Move most of ClientDescriptor.finish_current_handler into library.
2016-01-26 20:56:08 -08:00
Tim Abbott
7df61fccbd
Add user_profile_email field to ClientDescriptor.
2016-01-26 20:55:59 -08:00
Tim Abbott
2ea0daab19
Track Tornado handlers by uniquely assigned IDs rather than objects.
...
This is early preparation for splitting apart Tornado into a queue
server and a frontend server.
2016-01-26 20:55:41 -08:00
Tim Abbott
8b42fdd0d7
Move get_events logic into a backend function in event_queue.py.
...
This commit is somewhat ugly, but its purpose is to be early
preparation for splitting Tornado into a queue server and a frontend
server, and this code belongs, by and large, in the queue server
component.
2016-01-26 20:51:54 -08:00
Tim Abbott
5a6154c8ba
test_helpers: Fetch streams from cache in subscribe_to_stream.
2016-01-26 20:41:01 -08:00
Tim Abbott
f9791558e9
test_runner: Support continuing running tests after a failure.
2016-01-26 20:41:01 -08:00
Tim Abbott
fdf708039b
Disable empty-stream notifications for email gateway bot.
2016-01-23 11:37:52 -08:00
Alexander Trost
84f7a1f1ea
Make rabbitmq, redis, and memcached configurable via user settings.py.
...
Previously these were hardcoded in zproject/settings.py to be accessed
on localhost.
[Modified by Tim Abbott to adjust comments and fix configure-rabbitmq]
2016-01-21 22:07:56 -08:00
Tim Abbott
6d29dd2884
Fix do_remove_default_stream handling of nonstandard input.
...
Previously:
* It wouldn't raise an exception if the stream didn't exist
* It didn't correctly handle being passed a stream name
that differed in case from the stream name in the database.
2016-01-09 22:52:35 -08:00
Tim Abbott
8099aa5470
Fix passing notifications_stream to set_default_streams.
...
Previously, this would throw an IntegrityError, because it had just
been added in the loop.
2016-01-09 22:52:35 -08:00
Tim Abbott
bddf971554
alert_words: Only fetch and cache non-null alert word sets.
...
This removes from our cache a moderate amount of totally useless alert
word data corresponding to users who don't have any alert words.
Thanks to @dbiollo for the suggestion!
2016-01-09 20:01:38 -08:00
Tim Abbott
84114ab31f
Simplify realm_user_count to do just do a database count() query.
...
Just doing the database query is more readable, and has about the same
performance as before in the case where active user dicts for the
realm are in cache (and is substantially better in the rare case that
this isn't in the cache).
Thanks to @dbiollo for the perf investigation and suggestion!
2016-01-09 20:01:37 -08:00
Tim Abbott
023f45190f
rest_dispatch: Add support for using with websockets integration.
2015-12-12 18:14:08 -08:00
Tim Abbott
a79e89b28f
Cleanup remaining usage of % comprehensions without explicit tuples.
2015-12-05 15:29:42 -08:00
Tim Abbott
74853709a8
Rename NOTIFICATION_STREAM_NAME to clarify it's a default.
2015-12-05 14:14:44 -08:00
Tim Abbott
6b1494927d
set_default_streams: Don't force-create notifications stream.
2015-12-05 14:14:44 -08:00
Tim Abbott
f6f8f1fe36
Use new-style classes consistently for Python 3 support.
...
Also add the fixer for this to our list of fixers we check.
2015-11-04 08:01:52 -08:00
Tim Abbott
33295180a9
Apply Python 3 futurize transform libmodernize.fixes.fix_unicode_type.
2015-11-01 09:35:06 -08:00
Tim Abbott
f7878a61e1
Apply Python 3 futurize transform libmodernize.fixes.fix_xrange_six.
2015-11-01 09:35:06 -08:00
Tim Abbott
5ffb4deb8d
Apply Python 3 futurize transform libmodernize.fixes.fix_raise_six.
2015-11-01 09:35:05 -08:00
Tim Abbott
cd6f8e9191
Apply Python 3 futurize transform libmodernize.fixes.fix_map.
2015-11-01 09:35:05 -08:00
Tim Abbott
ffc900fe6e
Apply Python 3 futurize transform libmodernize.fixes.fix_int_long_tuple.
2015-11-01 09:26:17 -08:00
Tim Abbott
2ea0663a4a
Apply Python 3 futurize transform libmodernize.fixes.fix_imports_six.
2015-11-01 09:26:16 -08:00
Tim Abbott
b3ac668779
Apply Python 3 futurize transform libmodernize.fixes.fix_filter.
2015-11-01 09:26:16 -08:00
Tim Abbott
651b011514
Apply Python 3 futurize transform libmodernize.fixes.fix_basestring.
2015-11-01 09:26:16 -08:00
