paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-12 09:58:06 +00:00
Code Issues Packages Projects Releases Wiki Activity
10,992 Commits 30 Branches 160 Tags
aa228c9719c47e562aab873ad66eef8cf0caaf13
Commit Graph

1310 Commits

Author SHA1 Message Date
Zev Benjamin
50e1cb7ab3 socket: Specify reasons everywhere we close the SockJS object 
(imported from commit 7314fa975b9408caba2c5f1374c8259d67784ad0)
 2014-01-30 15:57:32 -05:00
Zev Benjamin
3df1097c95 socket: Wrap module in an anonymous function call 
This is so we can have some class variables.

(imported from commit 6311444bb2739daebc6c5da2b7ea7eabdd88689d)
 2014-01-30 15:57:31 -05:00
Zev Benjamin
9020f37141 socket: Add comment about the close() call in _try_to_reconnect() 
(imported from commit 87e32adcb9eeb066b6f3ecd85550d00263e0a4e9)
 2014-01-30 15:57:30 -05:00
Zev Benjamin
b8444daddd socket: Pass wait_time as an option to _try_to_reconnect 
(imported from commit 15a88c6da084f4834258868bc08b2cd983899820)
 2014-01-30 15:57:29 -05:00
Zev Benjamin
1ed176b5ef socket: Log the reason the SockJS connection was lost 
(imported from commit 069067f9f979e7255f97f4943d6513076b2706bd)
 2014-01-30 15:57:29 -05:00
Steve Howell
b3a551f402 Stop using raw operators in narrow.activate(). 
Have narrow.activate() user filter.operators() to produce
operators that have operand/operator fields, so that its callees
don't need to be backward compatible with the tuple format.

(imported from commit e408e33074d1be2d112bb3cdc081ec3616c908ee)
 2014-01-30 15:57:28 -05:00
Tim Abbott
a7b1b29bf0 Move get_updates into a module. 
(imported from commit 9a6c0ab1e76dd96abad8626bc5b1fdbd234b2645)
 2014-01-30 15:57:28 -05:00
Tim Abbott
33690d1dc6 Clean up argument to get_updates_success. 
(imported from commit 2583c79f83e1e3e540a00ba8afae5a07dff70845)
 2014-01-30 15:57:28 -05:00
Jason Michalski
90995889fc Fix scroll when muting and unmuting streams 
(imported from commit 9bd22cd12dfa50cf8fd9d87eb659a4543c5c78c4)
 2014-01-30 01:48:15 -05:00
Jason Michalski
bf57839e85 Remove scrollTop workaround for hash changes 
Now that we are not scrolling the document we can remove the workaround
to prevent browsers from scrolling on hash changes.

(imported from commit 67fdaa4980d4d54d80ca9c259bbee567b8eeb917)
 2014-01-30 01:48:15 -05:00
Jason Michalski
21c2aea755 Fix scroll position on narrow and unnarrow 
Change the offset to hold of the selected message as an offset from the
top of the screen. Then use the current offset and scrollTop to compute
the new scrollTop.

(imported from commit 718e95d3435c0f84cbb7663a9bb2bc2789314203)
 2014-01-30 01:48:15 -05:00
Jason Michalski
b0c5e2dbd0 Fix scroll on opening subscriptions details 
Move the animated scroll from body to the app div.

(imported from commit 2d2062d7a917616a60f414a633dd2f827ae840a0)
 2014-01-30 01:48:15 -05:00
Jason Michalski
9cc1dc242c Move the mouse handlers from window to app 
(imported from commit 0331496a578c47f73b6c9e81d8a79e26e8d7a9a3)
 2014-01-30 01:48:15 -05:00
Jason Michalski
198648447f Change viewport to use the app div not the document for size 
Now that we are scrolling the app we should have viewport respect this
CSS change.

(imported from commit dec5450563a6f5ac23499819ec382030e3a910dc)
 2014-01-30 01:48:15 -05:00
Steve Howell
967d3c9c65 Use .operator to get operator for mixpanel. 
(imported from commit 7c70a592b2efd769acab9b178c08a345785b889b)
 2014-01-30 13:24:43 -05:00
Steve Howell
53027b71a4 Use operator/operand inside the Filter instance methods. 
Avoid tuples in the methods inside Filter.prototype.

(imported from commit beed799e767d9645735a2bd4eefb5d431c04f17f)
 2014-01-30 12:53:08 -05:00
Steve Howell
b18307b667 Start using operator/operands internally in Filter class. 
By having Filter.canonicalize_tuple() call filter_term(),
we make it so that Filter objects get operator/operand
fields in their terms when we initialize this.

This mostly caused test breakage for tests that were doing
assert.deepEqual; now we just check to make sure that the
field we need are there.

(imported from commit 63b2516dc72edeb11e76a1fa4442570b9c605baa)
 2014-01-30 12:53:08 -05:00
Steve Howell
12626ead66 Populate terms with named fields in filter_term(). 
Consumers of Filter.parse() can now reference
search term parts like so: term.operand, term.operator

(Legacy code can still use term[0] and term[1].)

(imported from commit 06d0da65f13f1eb7e3ba8eac0e69448aab2735ab)
 2014-01-30 12:53:08 -05:00
Steve Howell
fdd57f5abe Extract filter_term() in filter.js 
(imported from commit 142464bb02817108726f9c118459c38e55b96bbf)
 2014-01-30 12:53:07 -05:00
Tim Abbott
abbe0f781f Don't wait 1 second before syncing updates manually controlled flags. 
(imported from commit 8526f5d77aee078b5bc282da093009e19f016a44)
 2014-01-30 12:48:36 -05:00
Tim Abbott
20457d695d Fix starring/unstarring of messages. 
This got broken in the local echo refactoring -- we accidentally
switched the update_starred function to be a toggle, which meant that
the message would be marked as starred and then unmarked as starred
moments later, due to the two update_starred calls for the initiating
browser (one from when the click happens, the second from when the
event returns from the server).

(imported from commit 8f83729fe5477cf052124c1c56ed9189b85b885c)
 2014-01-30 12:48:36 -05:00
Jessica McKellar
7085dca1ce Fix the Admin page not working for newly-knighted users. 
Previously, while you'd get the event saying you'd been knighted,
which would make the Administration tab visible, clicking on the tab
would error out because the admin page HTML was never sent over on
page load (since you weren't an admin at that point).

(imported from commit 90ad351533515bebece630d67baf4b142d320754)
 2014-01-29 12:41:22 -05:00
Jessica McKellar
20f2baa614 admin: Show a lock icon next to private streams. 
(imported from commit 26829016cf219b55aef0ef45187667b0a9bd86fd)
 2014-01-29 12:41:21 -05:00
Leo Franchi
e716a75d22 Properly render at-all and at-everyone mentions locally 
(imported from commit 9533b83dba6a61f6c09da755fca54e8a24ad61e6)
 2014-01-28 17:37:10 -05:00
Leo Franchi
1666403850 Find message objects in any lists when updating, as update might come from server 
(imported from commit fa70180c9a228bff39efd846d465d0f1fa9bb4e7)
 2014-01-28 17:31:02 -05:00
Jason Michalski
c573efd437 Ignore stream description update events for unknown streams 
Clients can receive description updates for streams which are not in
stream_data. We should ignore the updates and warn that this has
occurred.

(imported from commit 3cd5a98a133012ae27ea0f43b03cc9d8e459e49c)
 2014-01-28 17:12:15 -05:00
Leo Franchi
91fb4f6b8c Fix clicking on link to message when sending outside this narrow 
(imported from commit 6eeeb3b4c06021be21f48c8c5f2869904cd13b09)
 2014-01-28 16:03:11 -05:00
Leo Franchi
ffb816391c Use our own fenced code preprocessor, fixing output mismatches 
(imported from commit 3d4abb1043349e30adf265342ee7c946a99b3ce2)
 2014-01-28 15:35:32 -05:00
Leo Franchi
daecc7993a Add a fenced code parser in javascript 
(imported from commit 42b1dc18ca34cbbdf3cda6e833adde631a9d88f5)
 2014-01-28 15:35:32 -05:00
Leo Franchi
dd7d31c7a6 Allow an empty home view when unnarrowing 
(imported from commit 69f1a84b23ae8942db58851a1a1c6723c26df560)
 2014-01-28 15:35:31 -05:00
Leo Franchi
dc3c6f34fc Convert python-regex inline flag style to JS regex flags 
(imported from commit 16c58fa54c0b87931d873290b175461ceb176d62)
 2014-01-27 12:30:42 -05:00
Leo Franchi
b83be2cd32 Properly avoid realm filter work in non-local-echo case 
(imported from commit 9c01109e6900509690841306fb4a23464321de61)
 2014-01-27 12:30:42 -05:00
Leo Franchi
1fdb586c13 Make sure then_select_id is a number to call .toFixed() 
(imported from commit 58635110c737ccb38e74cce8b4feb5d93dfbf5cc)
 2014-01-27 12:30:42 -05:00
Leo Franchi
a82bc689e8 Render /me message on the frontend 
(imported from commit ce4a44624b7084464d5c6ce8e04eef03ee23c9e3)
 2014-01-27 12:30:42 -05:00
Leo Franchi
883157893c Use a UserMessage flag to indicate /me messages 
(imported from commit ea503b0d3eb6e90230c0859be96ede60faf5c2bd)
 2014-01-27 12:07:48 -05:00
Leo Franchi
5441409044 Consolidate emoji tests and test on frontend as well 
(imported from commit 3244a93209b56b655b80633713a3f58ae46d06ff)
 2014-01-27 12:07:48 -05:00
Leo Franchi
78f0cc1c4d Don't set realm filters unless we have local echo 
(imported from commit bbb7d87a869d6f1bd99a45581f8f557a97f30cce)
 2014-01-27 11:56:25 -05:00
Leo Franchi
6d9edcf06f Re-enable local echo for staging 
(imported from commit e8b579e2289271732d3998cbe16854e39e55d5d6)
 2014-01-24 16:09:44 -05:00
Leo Franchi
3b07c164fb Fix realm filters with multiple groups 
(imported from commit 9652cf8acbe51e25bcf053980b6caa9565b57e45)
 2014-01-24 16:09:44 -05:00
Leo Franchi
97fb3e74af Support subject links in local echo 
(imported from commit 916fecccc834053ea0354936119c6591af273938)
 2014-01-24 16:09:44 -05:00
Jason Michalski
62435e167f Add frontend stream description event handling 
Update the stream page when receiving stream description change events.

(imported from commit 84f6f3846a3197f14a24611cdc06350fae90f9dd)
 2014-01-24 14:47:44 -05:00
Jason Michalski
1f98c4f4ce Add support for updating the stream description 
The stream description can now be updated, but the UI is not yet updated
on success.

(imported from commit f45e0a9d5138d828ae98d6d49645ab3ddc966704)
 2014-01-24 14:47:44 -05:00
Jason Michalski
4104f00229 [schema] Add description to streams and display it 
A description was added to the streams and it is now displayed on the
subscriptions page. It can not be set in the UI yet.

(imported from commit 81d08b65eee42dba87cd99dd5bd30106c4eb6c6a)
 2014-01-24 14:47:44 -05:00
Leo Franchi
ea04d027cf Don't allow editing of local-only messages 
(imported from commit 4fcac6b4b7a5f917944934d06eae757d7cca8170)
 2014-01-24 14:01:19 -05:00
Leo Franchi
9ec5cde8b0 Disable local echo for staging temporarily 
(imported from commit dd4dcf1382f8511f49fc223223fa3dbba1634ef8)
 2014-01-24 14:01:18 -05:00
Leo Franchi
f528ac659d Only attempt to reorder a message if we had it in the message list originally 
(imported from commit 0b2802c1f1b6b17cd9f52dd9cecdf84f6f1cf5b0)
 2014-01-24 14:01:18 -05:00
Leo Franchi
b1ac754448 Don't local echo messages that we can't apply locally to the narrow filter 
(imported from commit 372063352f17caa4990195ace4757bb68c53523a)
 2014-01-24 14:01:18 -05:00
Leo Franchi
063484a917 Only clear the compose box if a message was locally echoed 
(imported from commit a90a566f61e939e34eab9666743848e47c122400)
 2014-01-24 14:01:18 -05:00
Steve Howell
e63d9d32e2 Remove an unneeded call to build_stream_list(). 
We were calling build_stream_list() twice in succession for
no good reason.  The call to build_stream_list() inside
populate_subscriptions was pulled out to happen right after
its two callers.

(imported from commit 816ae2fd34224d8baf4e4bcccdb670143795bb42)
 2014-01-24 12:23:41 -05:00
Steve Howell
4015189094 Release page_params.{un,}subbed_info during initialization. 
(imported from commit 410eeb7978281ae9b9e2a28fe26dcae10a65518d)
 2014-01-24 12:23:41 -05:00