paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 15:03:34 +00:00
Code Issues Packages Projects Releases Wiki Activity
2,148 Commits 30 Branches 160 Tags
aba2192ec269e793cb994a77d8c64adf55bc8ba4
Commit Graph

723 Commits

Author SHA1 Message Date
Zev Benjamin
d980afcf25 Actually convert to JSON instead of hacking it with string concatenation 
Old browsers might not have the global JSON object, so we may have to
include something like https://github.com/douglascrockford/JSON-js
for old browsers in the future.

(imported from commit e30a291d1212f2a00b543551b3a77082c7406eec)
 2012-11-09 18:08:31 -05:00
Jeff Arnold
c800186553 Make tab not autocomplete on the compose box subject field 
(imported from commit 7b305a3ca5ae5864255c4eca5464560f92b708b0)
 2012-11-09 17:57:20 -05:00
Waseem Daher
cb0f48b59d Restyle subscriptions 'undo button' slightly. 
Some stylistic tweaking to the solution to Trac #127.

(imported from commit 5f9a84c91716e6e57cce2cef1d8ca0915e4b135f)
 2012-11-09 17:13:15 -05:00
Luke Faraone
ed1caec147 Document the selctors in signup.js per trac #327 
(imported from commit b21f5c4dbdc1b4dc5dbdc5a3152fdc8cbbb872ef)
 2012-11-09 15:03:08 -05:00
Jessica McKellar
3af5e246be Don't cache your personal gravatar across gravatar updates. 
(imported from commit 06f82faaa350db8a64cebef24b738b5e93bebb98)
 2012-11-09 12:44:09 -05:00
Jessica McKellar
3df5d0faf3 Don't disable hotkeys on buttons in general -- just the send button. 
The original check has become too broad now that we have more buttons,
and specifically this lets you use the search hotkey to start a new
search after you've been searching up and down.

(imported from commit 0e691ff55ff9d4be8d406d1eb47fc2062758d28b)
 2012-11-09 11:44:06 -05:00
Luke Faraone
3928f763e9 Make unsubbing an undoable action. 
(imported from commit 713fdad5aa5d138b9e95a14dccaeba0d9d612c1c)
 2012-11-08 14:42:50 -05:00
Jessica McKellar
1801292320 Update autocomplete lists only on case-insensitive new additions. 
That way your autocomplete isn't polluted by multiple casings of the
same subject.

(imported from commit 0f28029be45bb48981f2e29ccb9f1490c1a56c94)
 2012-11-07 14:51:51 -05:00
Jessica McKellar
a2c6975ca2 Be case-insensitive about subjects when collapsing and narrowing. 
(imported from commit 0baf20179c037c3eac82d8db20c6ec8062bb136a)
 2012-11-07 14:51:51 -05:00
Keegan McAllister
3b78280786 search_button_handler: Remove unnecessary id lookup 
(imported from commit e6da0cfa0b39e48c63464eaf91673c3133ad4cd4)
 2012-11-07 11:51:03 -05:00
Keegan McAllister
3de0a0d1dd Use rows.id consistently 
(imported from commit 58098986b90609484e4a7c10688eeb27f2c126b2)
 2012-11-07 11:51:03 -05:00
Keegan McAllister
644702892b Return an int from rows.id 
I believe this is more correct for our one existing user,
update_selected_message.

(imported from commit a2f1a20c0d885a4e6de49c69d930844177549cbe)
 2012-11-07 11:51:03 -05:00
Luke Faraone
8bcbe55238 Clarify line in hotkey.js per trac #253 
(imported from commit d5bacdd4cef2f62ba22e3a47d25c3a656cf601c0)
 2012-11-07 10:43:42 -05:00
Keegan McAllister
bbb70b496b send_pointer_update: Use an absolute path for /json/update_pointer 
(imported from commit 8711df3f705023e763cf916a7dfbf43054d4823f)
 2012-11-06 17:04:10 -05:00
Keegan McAllister
3923e2eca6 subs: Use an absolute path for /json/subscriptions/list 
(imported from commit 82a2de5373e9170b27f4157c566e7ee23ba1f278)
 2012-11-06 17:04:10 -05:00
Keegan McAllister
5f20d71065 Rename people_hash -> people_set 
And use 'true' for consistency with stream_list_as_set.

(imported from commit 1cfb0a64eae368388cb2e0e57162d3b3d5ef88c1)
 2012-11-06 17:04:10 -05:00
Keegan McAllister
22dc487a72 Rename stream_list_hash -> stream_set 
This makes the intent more clear, since the values are all 'true'.

(imported from commit 1f1d6e206af9f2258b55bc77e7722158c2ffac98)
 2012-11-06 17:04:10 -05:00
Keegan McAllister
651566ba16 Use an Object for associative stream_list_hash, not an array 
From the Google JavaScript Style Guide:

    If you need a map/hash use Object instead of Array in these cases because
    the features that you want are actually features of Object and not of Array.
    Array just happens to extend Object (like any other object in JS and
    therefore you might as well have used Date, RegExp or String).

(imported from commit 048e7a640137f3919c0097a421b7b6c366b65cfe)
 2012-11-06 17:04:10 -05:00
Keegan McAllister
4f53457f2f show_all_messages: Use .empty() instead of .html("") 
(imported from commit 8df159bee6512856fd61eb5038e4b12470724553)
 2012-11-06 17:04:10 -05:00
Keegan McAllister
d6d34075ab Remove duplication in message validation 
NB: this does change which error will be flagged if multiple conditions apply.

(imported from commit 080bf7d764f1f16ad57b365ad9aa6bc48f3cff72)
 2012-11-06 17:04:10 -05:00
Keegan McAllister
366ca546e8 compose: Remove duplicated code in getters / setters 
(imported from commit 3a17ef6fbcf9b8b4a31a54656152a1d37dea4fa0)
 2012-11-06 17:04:10 -05:00
Keegan McAllister
fcf21177fe compose.start: Reformat default opts 
(imported from commit e0266265dbe81d19f3a666b2f822dffd2d8793d5)
 2012-11-06 17:04:09 -05:00
Zev Benjamin
58684965da Don't show the 'load more' button when the user has no messages 
(imported from commit f763535480e5efcf0d345f22e076a97ba1f5809c)
 2012-11-06 16:40:52 -05:00
Zev Benjamin
c21a255b37 Hide the 'load more' button sooner if there are no more messages to load 
(imported from commit ac046851c3a74a6f053e5f3c3b2950526a49cc46)
 2012-11-06 16:40:52 -05:00
Zev Benjamin
39db8bf5d5 Use symbolic name for constant 
(imported from commit cafb513c082b1ff1cf2169d90c3e4a77a9af5a9e)
 2012-11-06 16:40:52 -05:00
Zev Benjamin
9875164908 Select the first ever message the user receives 
(imported from commit 0fd6fa03175d9787a5e5a93d6172309a5eb47bfc)
 2012-11-06 16:40:52 -05:00
Zev Benjamin
df10d184a7 Only load initial messages if we know we will have some 
(imported from commit af6bec8bdcd5dc1a643662e7531a3ec75298ffa0)
 2012-11-06 16:40:52 -05:00
Jessica McKellar
4cad5f6e96 settings: Update name and gravatar without a reload. 
(imported from commit 961c9f64d7c39b4345ece036062854e8d474d2c0)
 2012-11-06 16:33:22 -05:00
Jessica McKellar
0700b96f37 Hover the sender name on gravatar and e-mail hovers as well. 
This clarifies that clicking on any of those three pieces of
information will pop up the user info tooltip.

(imported from commit 1e57550d66acbb2e8d5d244d2997bbd394c334c3)
 2012-11-06 16:33:21 -05:00
Waseem Daher
c654520c73 Display email on currently moused-over message. 
(imported from commit ae27dc6068fefa9df7b5a03992df0253da9ec61a)
 2012-11-06 16:33:21 -05:00
Waseem Daher
ce2023b348 Make 'v' the new hotkey for "Show all private messages". 
(imported from commit a7299633bf363cf832ff7099c963bc56abfdf734)
 2012-11-06 13:37:24 -05:00
Keegan McAllister
43af871759 ui: Fix punctuation in a comment 
(imported from commit 9ca5317cd73485891c136876d4e19e986f04c579)
 2012-11-06 11:25:11 -05:00
Keegan McAllister
54e8df4393 Fix missing newline at end of reload.js 
(imported from commit 30faacb6b3c0d6d57265c464459c2c088cd9244f)
 2012-11-06 11:25:11 -05:00
Keegan McAllister
f1809b8f9c add_display_time: Note unescaped variable 
(imported from commit 17d683e2bf0e5eabfb1cb2cdb6a1db18d140b5c9)
 2012-11-06 11:25:11 -05:00
Keegan McAllister
080c169e90 same_recipient: Fix spacing 
(imported from commit 75247bbbb496870236ab26f827daeb3fbe7bb7f3)
 2012-11-06 11:25:11 -05:00
Keegan McAllister
b56446513f Don't set default opts in select_message_by_id 
These are set again in select_message and we don't use them before then.

(imported from commit 9d1f5ebd7f87890817d6cb4411d62f1e7d1cd053)
 2012-11-06 11:25:11 -05:00
Keegan McAllister
f9b346666a Comment use of .outerHeight(true) 
(imported from commit 1b0f8da2c76dc5bc7504b4d4aa026351d1ab6627)
 2012-11-06 11:25:11 -05:00
Keegan McAllister
ca25c4d4a5 Consolidate report_{message,success,error} 
(imported from commit 21deb6a41438bf7697bd8a3c46a428ca0034f2b0)
 2012-11-06 11:25:11 -05:00
Zev Benjamin
b9c86ca49c Be more robust and aggressive about cleaning up recipients in the huddle compose box 
(imported from commit 6fe4ca445b6559e91a9b23088f3effdde4f18d7b)
 2012-11-05 18:09:11 -05:00
Zev Benjamin
fc9a47a26f Factor recipient splitting out into a function 
(imported from commit a00b090d0446dc9b80a33a92c68e37cd9aece251)
 2012-11-05 18:07:11 -05:00
Zev Benjamin
dc95a2b8f3 More regex robustification 
(imported from commit 1f7c7c660b0446f0724ff339b9326b9b8a5fe5a0)
 2012-11-05 18:07:11 -05:00
Jeff Arnold
986b780c69 Increase the bottom line. 
(imported from commit c1ac8a3be566713b61f971fb1da0214d2c1aef9c)
 2012-11-05 16:03:50 -05:00
Keegan McAllister
eac7040bd0 hotkey: Reduce keydown/keypress duplicated code 
(imported from commit 9d279166607105cffca6b18bdce9324be91be9f4)
 2012-11-05 15:38:23 -05:00
Keegan McAllister
94a635a379 hotkey: Rename keydown_handler -> current_key_handler 
Since it's used for both keydown and keypress.

(imported from commit 23ac169b20ec33d961f982a7deb0fa721b8173f7)
 2012-11-05 15:38:23 -05:00
Keegan McAllister
288fc6f2ee hotkey: Implement and use the contract on key handlers 
The comment on keydown_handler says that these functions should

   "return a new handler, or 'false' to decline to handle the event."

(imported from commit 8cd23ee69ef900fcb7c7c211fe6ad36f54f02ba9)
 2012-11-05 15:38:23 -05:00
Keegan McAllister
14f7f46c24 hotkey: Document more clearly what key 13 is 
(imported from commit a91ca23d9586374defbe5cc29fd9b1969a99be09)
 2012-11-05 15:38:23 -05:00
Keegan McAllister
fed4d6f69e hotkey: Expand on forward declaration comment 
(imported from commit f23414655dbf3caa2220b938cd93959753eae8fe)
 2012-11-05 15:38:22 -05:00
Keegan McAllister
3b66748967 hotkey: Use $.each instead of 'in' 
This is simpler and more consistent with the rest of our code.

(imported from commit 5188b8047952fe4e6556a26f10ab93123d67e03f)
 2012-11-05 15:38:22 -05:00
Keegan McAllister
4cd5cdbcd6 Revert "Clean up how we deal with the message type tabs" 
This reverts commit 429e055d3eca65af8bc0fe58481a7becf9ced66a.

There is some inconsistency between the names 'huddle' and 'personal' that is
breaking things.

(imported from commit 4c81853fca9d88d13ce8f23e2d6884c33cdc57d2)
 2012-11-05 15:01:49 -05:00
Keegan McAllister
477bad9536 Clean up how we deal with the message type tabs 
(imported from commit 429e055d3eca65af8bc0fe58481a7becf9ced66a)
 2012-11-05 11:49:01 -05:00