paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 04:53:36 +00:00
Code Issues Packages Projects Releases Wiki Activity
30,703 Commits 30 Branches 160 Tags
ac24fdd4ebd0ba015ca79c2002ed593eff95f65c
Commit Graph

1798 Commits

Author SHA1 Message Date
Steve Howell
047a81dd2c refactor: Move clear_topics into topic_zoom.js. 
This sets up some subsequent changes.
 2018-10-24 16:54:35 -07:00
Steve Howell
acb7149386 Extract topic_zoom.js. 
This small modules nicely breaks down the
responsibilities of topic_list and stream_list
when it comes to zooming in and out of topics
(also known as hitting "more topics" or "All
Streams).

Before this, neither module was clearly in
charge, and there were kind of complicated
callback mechanisms.  The stream_list code
was asking topic_list to create click handlers
that called back into stream_list.

Now we just topic_zoom set up its own click
handlers and delegate out to the other two
modules.
 2018-10-24 16:54:35 -07:00
Steve Howell
c58a99b156 PM sidebar: Expand PM sidebar for huddles. 
This fixes a regression from here:

    88b4a9f2d7

The fix didn't account for how huddles are
represented as comma-delimited strings.

We also simplify the logic by extracting a
function and doing early-exit for simple
cases.
 2018-10-22 12:22:26 -07:00
Steve Howell
328e2ff316 Fix "Copy link to conversation" links. 
This cleans up the code for stream links
and creates nicer, more correct links for
PMs.

Fixes #10605
 2018-10-22 12:22:26 -07:00
Steve Howell
adf616d3f1 Add pm_perma_link helper. 2018-10-22 12:22:26 -07:00
Steve Howell
8c49985058 url decoding: Handle your own id being in PM slugs. 
Internally we generally omit our own id and email
in data structures related to PMs, except when we
are the sender, but if we receive "perma links"
we will need to filter out our id.
 2018-10-22 12:22:26 -07:00
Aditya Bansal
a4b51a33f8 timerender.js: Remove use of legacy font awesome base class 'icon-vector'. 2018-10-15 19:22:57 +05:30
Rohitt Vashishtha
11e4011d5f transmit.js: Use people.get_mention_syntax. 2018-10-13 16:42:50 -07:00
Rohitt Vashishtha
38cddf7d54 compose_actions: Use people.get_mention_syntax in reply_with_mention. 2018-10-13 16:42:50 -07:00
Rohitt Vashishtha
b18f9def06 people.js: Add get_mention_syntax to conditionally get @user|id syntax. 
This is intended to replace all function calls for generating mention
syntax for a target user.
 2018-10-13 16:42:34 -07:00
Steve Howell
27ef6a9991 compose pill: Add has_unconverted_data() helper. 2018-10-12 11:20:30 -07:00
Steve Howell
3225f81a92 compose pills: Add get_user_ids_string(). 
This helper will be useful for typing indicators.
 2018-10-12 11:20:30 -07:00
Steve Howell
3b9a5afcee input_pill: Add is_pending() helper. 2018-10-12 11:20:30 -07:00
Steve Howell
3545bc1893 settings: Confirm before deleting user groups. 
Fixes #10498.
 2018-10-12 10:38:56 -07:00
Cynthia Lin
a11c56f02a people: Format times without leading zeroes. 2018-10-04 17:02:09 -07:00
Cynthia Lin
6d0aa68591 custom profile fields: Add and restyle default user profile fields. 
Refactor selectors to utilize SCSS features.

Fixes some issues in #10545.
 2018-10-04 17:02:09 -07:00
Harshit Bansal
20aee7b116 emoji: Change fallback emojiset for text emojiset. 
Now that we have added back support for `google-blob` emojiset,
changing the fallback emojiset for `text` emojiset to `google-blob`
make sense.
 2018-09-21 18:34:12 -07:00
Akash Nimare
0a7b487617 hotkey: Update test for hotkey deprecation. 
This commit adds a test for hotkey deprecation since
we need to test the 'CMD' hotkey on macOS.
 2018-09-21 10:59:55 -07:00
Steve Howell
b991bbe431 Add coverage for message_events.update_messages(). 2018-09-11 15:17:51 -04:00
Rohitt Vashishtha
d5459f09fd typeahead: Insert extended mention syntax for users with same full name. 
Fixes #374.
 2018-08-31 14:16:47 -07:00
Rohitt Vashishtha
e497816a42 people: Track users with same full names. 
This commit exposes the function is_duplicate_full_name()
that can be used to discern if we cannot identify a user
just by their full name in the interface and have to use
his user id as well to distinguish them from other users.
 2018-08-31 14:16:47 -07:00
Rohitt Vashishtha
ef5940a864 markdown.js: Add @user|id syntax to support users with same name. 2018-08-31 14:16:47 -07:00
Steve Howell
7b2f5ccabc Rename markdown-help to message-formatting. 
This just makes the id match the name of the
menu item.
 2018-08-31 11:51:22 -07:00
Pragati Agrawal
e1ed0ee8e0 org settings: Disable topic editing checkbox when message editing is off. 
This checkbox has no effect in this case, so it makes sense to display
it as such.

Fixes: #10327.
 2018-08-31 11:49:54 -07:00
Yashashvi Dave
e398b25429 user popover: Remove repetitive "Last seen" text from all last seens. 
This text was unnecessary.

Fixes part of #10303.
 2018-08-28 16:04:52 -07:00
Marco Burstein
6f57cd4d23 upload: Use a placeholder when uploading. 
Use the placeholder `[uploading file]()` when uploading before the
upload has completed. This behavior prevents an image from being
improperly placed when typing after starting an upload. This is based
on GitHub's handling of image uploading.

Also, add tests to the `upload` Node tests and update existing tests to
account for the new behavior.

Fix #10305.
 2018-08-26 23:33:24 -07:00
Marco Burstein
fa22cf18f6 compose_ui: Create the compose_ui.replace_syntax function. 
`replace_syntax` will replace text inside of a compose textbox. Also,
add tests to the `compose_ui` Node tests for this function.
 2018-08-26 23:33:24 -07:00
Steve Howell
c8fbc0706f tests: Test misc things with input pills. 2018-08-26 22:32:08 -07:00
Steve Howell
53fee3606c tests: Test arrowing between input pills. 2018-08-26 22:32:08 -07:00
Steve Howell
a3b573a07c tests: Test pasting into pill input area. 2018-08-26 22:32:08 -07:00
Steve Howell
892085723f tests: Test copying text from input pills. 2018-08-26 22:32:08 -07:00
Steve Howell
1600529a8b tests: Clean up duplicate setup for input_pill. 
We just set pill_input.before to a noop for all
of our tests in set_up, and callers can always
override it with more specific implementations.
 2018-08-26 22:32:08 -07:00
Steve Howell
3745d44bed node tests: Add test for input pill exit button. 2018-08-26 22:32:08 -07:00
Harshit Bansal
9bd56d0ce4 build_emoji: Change emoji sprite sheets to use hyphens in names. 
Use of hyphens is more consistent with our other emoji infra names.
 2018-08-26 22:16:23 -07:00
Steve Howell
37acb3e2cb tests: Test left arrow for pill input. 2018-08-25 06:51:15 -04:00
Steve Howell
c9fab959b9 tests: Test comma behavior for input pills. 2018-08-25 06:51:15 -04:00
Steve Howell
383567aa73 tests: Test enter-key behavior for input pills. 2018-08-24 10:00:04 -07:00
Steve Howell
572990b7f4 tests: Add set_up() helper for input_pill tests. 2018-08-24 10:00:04 -07:00
Steve Howell
9e0c8e50d1 tests: Cover removePill function for input_pill. 
We simulate hitting backspace while focused on
particular pill.
 2018-08-24 10:00:04 -07:00
Steve Howell
bee592b44e node tests: Bring list_cursor to 100% coverage. 
We had some indirect coverage of this already, so
this mostly focuses on error cases and corner
cases.
 2018-08-24 10:00:04 -07:00
Shubham Dhama
c8a8dbb86a org settings: Remove redundant lines for disabling non-existent checkbox. 
In commit c293bb82c4 we changed
id_realm_invite_by_admins_only and realm_invite_required checkboxes to a
single dropdown so these lines are redundant now.
 2018-08-23 11:52:59 -07:00
Joshua Pan
eca4266cde drafts: Don't save drafts with 2 or less characters. 
Fixes #10357.
 2018-08-22 16:52:18 -07:00
Joshua Pan
2aeabf24a6 frontend: Create data structure for starred messages. 2018-08-21 13:42:23 -07:00
Yashashvi Dave
6622f995b0 user profile popover: Rename user last seen. 
Rename "Last seen just now" to "Just now",
and "Unknown" to "More than 2 weeks ago"
in user profile popover.
 2018-08-21 11:42:59 -07:00
Yashashvi Dave
1e27cb18eb user profile popover: Hide popover when user clicks on edit-profile-btn. 2018-08-21 11:42:59 -07:00
Yashashvi Dave
03f5422ce8 custom profile field: Minor tweaks in field-table in admin settings. 
This commit add minor changes in profile field table in
admin settings:
 - Hide table header if there is no field
 - Fix width of table column
 2018-08-21 11:42:59 -07:00
Yashashvi Dave
463fb622b6 custom profile field: Remove all static use of field-type name or id. 
This commit removes all static use of field-type's name or id in
frontend.
 2018-08-21 11:37:51 -07:00
Yashashvi Dave
6e65235a6d zerver/lib/events.py: Add FIELD_TYPE_CHOICES_DICT to page_params. 
This commit add FIELD_TYPE_CHOICES_DICT to page_params and replace
FIELD_TYPE_CHOICES.

FIELD_TYPE_CHOICES_DICT includes all field types with keyword, id
and display name. Using this field-type-dict, we can access field
type information by it's keyword, and remove all static use of
field-type'a name or id in frontend.
This commit also modifies functions in js where this page_params
field-types is used.
 2018-08-21 11:37:51 -07:00
Joshua Pan
793ec9e266 tests: Test all update_display_settings events. 2018-08-19 14:51:31 -04:00
Joshua Pan
e0426e42cd tests: Test all realm update dispatch events. 2018-08-19 14:51:31 -04:00