4 Commits

Author	SHA1	Message	Date
Steve Howell	fa6f642c9c	refactor: Remove global argument.current_realm.	2018-11-07 10:44:48 -08:00
Steve Howell	e1113c7011	refactor: Remove the global arguments.current_message. ... The Markdown processor makes it fairly simple for the helper classes to access the `md` engine. We now write `_md_engine.zulip_message` to avoid having the current message in the global namespace. Note that we do reuse engines for multiple messages, but each engine is specific to a realm. And we therefore avoid even the theoretical possibility of leaking message data between realms.	2018-11-07 10:44:48 -08:00
Steve Howell	659c9dde00	bugdown: Avoid unnecessary realm queries. ... We now keep realm in the arguments variable, which avoids some lookups. We also test settings before even trying to get realms.	2018-11-07 10:08:46 -08:00
Shubham Dhama	49deb5acd3	bugdown: Move global variables to arguments.py. ... This has two advantages; * We can split bugdown/__init__.py into several modules, and each module can access these arguments by importing these * We get rid of the super-ugly `global db_data` construct, replacing it with a only slightly ugly monkey-ish patching of the `zerver.lib.bugdown.arguments` module, which is at least considerably more clear on reading as to what it's purpose is.	2018-07-09 15:45:45 +05:30