paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-12 01:47:41 +00:00
Code Issues Packages Projects Releases Wiki Activity
15,647 Commits 30 Branches 160 Tags
b8f2685b18474a3d69e94e94dede03a5ed60a7f6
Commit Graph

2018 Commits

Author SHA1 Message Date
Brock Whittaker
6ed7ba8935 Blur all links after clicking. 
The links don’t have to stay focused and produce unintended side
effects.
 2016-12-14 15:37:43 -08:00
Brock Whittaker
660144a79d Blur the active element on settings/streams modal exit. 
This blurs any focused element so that you can’t accidentally enter
into anything on a hidden modal.
 2016-12-14 15:37:43 -08:00
Brock Whittaker
a460fcddef Add Date Headers to Floating Bar and Message Headers. 
This adds the date of a block of messages to the floating recipient
bar along with message headers of blocks that are the first of a
particular day.
 2016-12-13 20:36:39 -08:00
Bojidar Marinov
8b44ace3a8 frontend: Make global notifications live-update on changes. 
Fixes #2527
 2016-12-13 20:22:13 -08:00
Brock Whittaker
65288848b1 Fix Hiding Stream Creation Prompt on "Enter". 
The stream creation prompt would be hidden if someone clicked “Enter”
and the form failed. This is presumably due to some bootstrap magic.
 2016-12-13 13:16:51 -08:00
Bickio
868f343980 Do not open compose box if user sidebar search is empty. 
Fixes #2357.
 2016-12-13 11:04:08 -08:00
Brock Whittaker
1886f0a015 redesign: Convert subscriptions page to overlay. 
This is a major change to the /#subscriptions page, converting it to
by a side-by-side list of streams and their settings in an overlay.
There are no new features added/removed, but it's a huge changeset,
because it replaces the old navigation logic and moves the stream
creation modal to appear in the right side of this overlay.
 2016-12-09 11:08:08 -08:00
Igor Tokarev
0bac986f26 Fixed compose box PM recipient typeahead handling of focus. 
This closes #2315.
 2016-12-07 22:13:47 -08:00
Tommy Ip
fe4a0e72fc Add new button to download ~/.zuliprc from settings page. 
Added new option to download .zuliprc file directly from settings
page.  This should help reduce friction when setting up new
bots/integrations. This new feature is available in the bot cards and
the 'show your API key' section. One caveat is that the filename is
automatically set to 'zuliprc' instead of '.zuliprc', since as most
browsers do not allow filenames to start with a dot.

Fixes #2327.
 2016-12-07 21:28:41 -08:00
Rafid Aslam
7856217a63 Migrate JS modules to CommonJS style. 
Closes #1488.
 2016-12-07 16:11:52 -08:00
Yago González
e65c42cb5f eslint: Turn on errors for new-cap rule. 
Now the eslint rule "new-cap" is set as: ["error", { "newIsCap": true, "capIsNew": false }]
 2016-12-07 05:33:16 -08:00
Rafid Aslam
ce94fb2eb1 deps: Change zxcvbn download method from download-zxcvbn to npm. 
- Replace download-zxcvbn with downloading it from npm.
- Change zxcvbn.js path to node_modules (because npm put it to
`node_modules` directory.
- Bump `PROVISION_VERSION` in `version.py` to 2.4.

Fixes #2423.
 2016-12-06 17:54:56 -08:00
Rafid Aslam
0951b838ca deps: Update zxcvbn to 4.4.1 
Update zxcvbn to 4.4.1, and change `crack_time` to
`crack_times_seconds` because `crack_time` has been changed to
`crack_times_seconds` in 4.4.1.
 2016-12-06 17:51:33 -08:00
Zac Pullar-Strecker
e6e11aefb3 settings: Add option to disable websockets. 
This can be useful in scenarios where the network doesn't support
websockets.  We don't include it in prod_settings_template.py since
it's a very rare setting to need.

Fixes #1528.
 2016-12-05 21:55:22 -08:00
K.Kanakhin
7bf10ec74f update-sockjs: Update sockjs from version 0.3.4 to 1.1.1. 
- Add browserify to npm dependencies.
- Add SockJS-client to npm dependencies.
- Add npm postinstall script to generate browser version of SockJS-client
  from npm package.
- Change deprecated SockJS object property 'protocol_whitelist' to
  'transports'.
- Fix settings.
 2016-12-05 21:36:10 -08:00
lonerz
abde152d9c eslint: change array-callback-return from warning to error. 2016-12-05 21:21:19 -08:00
lonerz
dc6849952b eslint: change space-before-function-paren from warning to error. 
Also fix violations.
 2016-12-05 09:50:37 -08:00
lonerz
a8b39e6c0f Switch yoda eslint rule from warning to error (in .eslintrc) 2016-12-04 19:48:10 -08:00
lonerz
025fe9980b Switch no-empty eslint rule from warning to error (in .eslintrc) 2016-12-05 01:35:14 +00:00
Rafid Aslam
0290aeb6ab lint: Fix several no-unused-vars eslint rule violations. 
These changes were extracted by tabbott from the original commit
to merge now because they have been reviewed as safe.
 2016-12-03 18:43:47 -08:00
Rafid Aslam
426cb13e23 Remove enforce_arity function from util.js. 
Remove `enforce_arity` function from util.js, because it is
not used anymore.
 2016-12-03 18:43:46 -08:00
kevv87
1fb9220354 lint: Remove old jslint linter. 
Now that we're using eslint, jslint is no longer required.
 2016-12-02 18:49:42 -08:00
Tim Abbott
2c940b93ab js: Fix some minor whitespace issues. 2016-12-02 18:39:30 -08:00
AZtheAsian
5e9918135b eslint: change quote-props from off to error and fix violations. 2016-12-02 18:35:53 -08:00
Krzysztof Zbudniewek
b8fc3f0e65 eslint: change space-before-blocks from warning to error and fix violations 2016-12-02 17:40:09 -08:00
AZtheAsian
9c0ebc7359 eslint: change no-else-return to error and fix violations 2016-12-02 14:43:09 -08:00
AZtheAsian
ed0bc831be eslint: change one-var from warning to error and fix violations 2016-12-02 11:25:16 -07:00
Tommy Ip
b3f4feb996 eslint: change max-len from warning to error and fix violations. 2016-12-02 14:16:33 +00:00
kevv87
e6369fc29b eslint: change no-plusplus from warning to 2 and fix violations. 2016-12-01 14:27:17 -08:00
Tommy Ip
c90da24541 eslint: change keyword-spacing from warning to error and fix violations. 2016-12-01 14:22:15 -08:00
aakash-cr7
d99b17070e edit: Fix traceback when saving edits to unsent messages. 
7b0c6459b4 accidentally failed to update
one of the calleers of update_private_messages, resulting in this code
path failing consistently.

Fixes #2416.
 2016-12-01 10:39:43 -08:00
Tommy Ip
7b2c313f37 eslint: change brace-style from warning to error and fix violations. 2016-12-01 10:20:22 -08:00
Brock Whittaker
4935f0c693 popovers: Hide actions popover once the muting button is clicked. 
The popover shouldn’t still display once a valid action on the popover
has been taken.

Fixes #2366.
 2016-11-29 16:47:03 -08:00
Arpith Siromoney
f7dc2f33cd Change name of eslintrc file to .eslintrc.json 
Currently it does this for the eslintrc files in zulip,
zulip/frontend_tests and static/js

This commit also fixes json style issues (quotes)
 2016-11-29 08:58:39 -08:00
Tim Abbott
3d1bcb05e1 tornado: Move event_queue.py to zerver/tornado/. 
Fixes #729.
 2016-11-26 22:29:28 -08:00
Calvin Lee
4e5c4c5ffb streams: Add support for setting stream description during creation. 
Add new box for stream description in the stream creation form,
modify backend so its contents end up as the stream description.

Fixes: #2283.
 2016-11-26 16:55:35 -08:00
Steve Howell
604079a9d4 Fix formatting for Group PMs in the right sidebar. 
We now sort users by the lower case value of their
full names in each of the links in the "GROUP PMs"
section of the right sidebar.  We still use "+n others"
for big huddles.
 2016-11-26 11:48:52 -08:00
Steve Howell
d953eca14c Make group PMs reply-to's more consistent in case. 
We now sort lists of users ids deterministically, and we also
sort list of emails deterministically and without regard to case.

This probably fixes the bug #2343, although I never got a great
repro on that.
 2016-11-26 11:48:52 -08:00
Steve Howell
578b276523 node tests: Add tests for message_store.js. 2016-11-26 11:48:52 -08:00
Steve Howell
af9ff9a030 Have unread.num_unread_for_person accept a user_id. 
(It used to take an email as its parameter.)
 2016-11-26 11:48:52 -08:00
Steve Howell
772571fd82 Use data-user-ids-string in Private Messages sidebar. 
This commit also changed message_store.recent_private_messages
to use user_ids_string instead of reply_to.
 2016-11-26 11:48:52 -08:00
Steve Howell
aadfe133e2 buddy list: Use user_ids in DOM list elements. 2016-11-26 11:48:52 -08:00
aakash-cr7
79b4ac8155 Add tooltips to buttons appearing when message is not delivered. 2016-11-26 10:13:48 -08:00
Arpith Siromoney
29d3019262 Switch no-loop-func eslint rule from warning to error (in .eslintrc) 
The one error that needed to be fixed was in static/js/echo.js.
The function in the loop was being used by _.each(). This has been
replaced by iterating through the array using a while loop instead.
 2016-11-25 14:02:44 -08:00
Arpith Siromoney
497c7702cc Run eslint in tools/lint-all with npm run --silent lint 
This commit adds a basic eslintrc that emulates jslint defaults.
Rules that conflict with our existing code have been switched to
warnings instead of errors. Globals have been added to the eslintrc. The
bundled js file (generated by webpack) and blueslip.js are ignored with
.eslintignore.

To display warnings, run npm run lint-loud. This runs eslint without the
--quiet option on static/js and frontend_tests.

npm run --silent lint is run by tools/lint-all (in addition to jslint).
The --silent option is used to suppress the default output from npm run.

Fixes #535.
 2016-11-18 16:15:45 -08:00
Vladislav Manchev
d7e1e4a2c0 Add initial implementation of custom realm filters. 
This PR was abandoned by Vladislav and then substantially modified by
Igor Tokarev and Tim Abbott to complete it and fix a number of bugs.

Fixes #544.
 2016-11-17 17:11:25 -08:00
Steve Howell
8f96853fcb presence: Convert presence_info to use user IDs. 
When we filtered buddy lists, a recent change introduced some
bugs related to case-insensitive emails.  We now circumvent the
bug by indexing presence_info with user_ids.
 2016-11-17 13:27:28 -08:00
Brock Whittaker
5d2b81358c Code Simplification and Emoji Drag Fix. 
There’s no need for four separate `$(sel).is()` statements, one will
do. This also added .drag to the list to ignore.
 2016-11-17 11:21:15 -08:00
Brock Whittaker
2663215625 Do not close message compose box on drag. 
On the drag to resize emoji box action, do not close the message
compose box.
 2016-11-17 11:21:15 -08:00
Steve Howell
82a497ec08 Remove spurious blueslip error for topic lists. 
If we update an unread count for a topic that is not part of
our truncated list, we don't need to complain.
 2016-11-16 22:01:30 -08:00